Re: [PATCH] module.c: add missing ifdefs for CONFIG_UNUSED_SYMBOLS

view
thread

!MAILaRCHIVE_VOTE_RePLACE

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

[view in full thread]

From: Denys Vlasenko <vda.linux@...>

To: Andrew Morton <akpm@...>

Cc: <linux-kernel@...>

Subject: Re: [PATCH] module.c: add missing ifdefs for CONFIG_UNUSED_SYMBOLS

Date: Thursday, September 13, 2007 - 7:23 pm

On Friday 14 September 2007 00:00, Andrew Morton wrote:
quoted text> > In short, patch makes trivial changes which are "obviously correct"
> > (famous last words).
> 
> The intent seems reasonable.  Would have preferred separate patches for the
> separate things though..
> 
> This:
> 
> akpm:/usr/src/25> grep '^+#' patches/modulec-add-missing-ifdefs-for-config_unused_symbols.patch                                                                 +#ifdef CONFIG_UNUSED_SYMBOLS
> +#endif
> +#ifdef CONFIG_UNUSED_SYMBOLS
> +#endif
> +#ifdef CONFIG_UNUSED_SYMBOLS
> +#endif
> +#ifdef CONFIG_UNUSED_SYMBOLS
> +#endif
> +#ifdef CONFIG_UNUSED_SYMBOLS
> +#endif
> +#ifdef CONFIG_UNUSED_SYMBOLS
> +#endif
> +#ifdef CONFIG_UNUSED_SYMBOLS
> +#endif
> +#ifdef CONFIG_UNUSED_SYMBOLS
> +#endif
> +#ifdef CONFIG_UNUSED_SYMBOLS
> +#endif
> +#ifdef CONFIG_UNUSED_SYMBOLS
> +#endif
> +#ifdef CONFIG_UNUSED_SYMBOLS
> +#endif
> 
> is a bit of a maintenance problem though.  Can you think of a way in whcih
> we can cut down on that?

Attached patch reduces number of inserted #ifdefs from 11 to 8.
--
vda

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH] module.c: add missing ifdefs for CONFIG_UNUSED_SYMBOLS, Denys Vlasenko, (Thu Sep 13, 6:30 pm)

Re: [PATCH] module.c: add missing ifdefs for CONFIG_UNUSED_S..., Andrew Morton, (Thu Sep 13, 7:00 pm)

Re: [PATCH] module.c: add missing ifdefs for CONFIG_UNUSED_S..., Denys Vlasenko, (Thu Sep 13, 7:23 pm)

Navigation

Popular discussions


linux-kernel:
Greg KH	Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Jan Engelhardt	intel iommu (Re: -mm merge plans for 2.6.23)
Roland Dreier	Re: Integration of SCST in the mainstream Linux kernel
Andrew Morton	Re: 2.6.24-rc3-mm1 make headers_check fails
git:

linux-netdev:
Ingo Molnar	iwlwifi: fix build bug in "iwlwifi: fix LED stall"
Jarek Poplawski	[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Gerrit Renker	[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
Frans Pop	svc: failed to register lockdv1 RPC service (errno 97).
openbsd-misc:

Colocation donated by: