Re: cpu hotplug support broken in 2.6.23-rc3

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Pavel Machek <pavel@...>
Cc: Rafael J. Wysocki <rjw@...>, Jeff Chua <jeff.chua.linux@...>, <rusty@...>, <vatsa@...>, <zwane@...>, kernel list <linux-kernel@...>, Len Brown <lenb@...>
Date: Thursday, September 13, 2007 - 4:01 pm

On Tue, 2007-09-04 at 09:27 +0200, Pavel Machek wrote:

Ok, I can reproduce it and I tracked down what happens:

When the CPU goes offline, the clock event source for this CPU (lapic)
is removed from the clock events framework. This also clears the
information that the CPU is using C-States which stop the local APIC
timer.

Now you put the CPU online again and the local APIC timer is used, but
the C-State information is not evaluated again in ACPI. This means that
the clock events code does not know that the APIC might stop. In the
worst case this will happen and make the CPU wait for timer interrupts
forever.

The problem only appears when you are on battery (c3/c4 available) or on
those broken machines, where C2 is in reality C3 (e.g. akpm's VAIO)

I have an yet untested fix, which preserves the broadcast state across
the offline state, but Len is looking into it as well, whether we can
just reevaluate the power states (and the broadcast flags) when a cpu
becomes online again. If Len can do that easily for 2.6.23, I'd prefer
that.

	tglx


-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
cpu hotplug support broken in 2.6.23-rc3, Pavel Machek, (Mon Aug 27, 6:43 am)
Re: cpu hotplug support broken in 2.6.23-rc3, Gautham R Shenoy, (Wed Aug 29, 4:08 am)
Re: cpu hotplug support broken in 2.6.23-rc3, Pavel Machek, (Sun Sep 2, 11:58 pm)
Re: cpu hotplug support broken in 2.6.23-rc3, Pavel Machek, (Mon Aug 27, 6:58 am)
Re: cpu hotplug support broken in 2.6.23-rc3, Jeff Chua, (Mon Aug 27, 10:36 am)
Re: cpu hotplug support broken in 2.6.23-rc3, Michal Piotrowski, (Mon Aug 27, 11:22 am)
Re: cpu hotplug support broken in 2.6.23-rc3, Pavel Machek, (Mon Aug 27, 5:32 pm)
Re: cpu hotplug support broken in 2.6.23-rc3, Jeff Chua, (Tue Aug 28, 10:21 am)
Re: cpu hotplug support broken in 2.6.23-rc3, Pavel Machek, (Sun Sep 2, 11:47 pm)
Re: cpu hotplug support broken in 2.6.23-rc3, Rafael J. Wysocki, (Mon Sep 3, 6:19 am)
Re: cpu hotplug support broken in 2.6.23-rc3, Thomas Gleixner, (Mon Sep 3, 8:35 am)
Re: cpu hotplug support broken in 2.6.23-rc3, Pavel Machek, (Tue Sep 4, 3:27 am)
Re: cpu hotplug support broken in 2.6.23-rc3, Thomas Gleixner, (Thu Sep 13, 4:01 pm)
Re: cpu hotplug support broken in 2.6.23-rc3, Pavel Machek, (Fri Sep 14, 8:38 am)
Re: cpu hotplug support broken in 2.6.23-rc3, Thomas Gleixner, (Fri Sep 14, 8:50 am)
RE: cpu hotplug support broken in 2.6.23-rc3, Pallipadi, Venkatesh, (Fri Sep 14, 2:49 pm)
RE: cpu hotplug support broken in 2.6.23-rc3, Thomas Gleixner, (Fri Sep 14, 3:18 pm)
Re: cpu hotplug support broken in 2.6.23-rc3, Thomas Gleixner, (Fri Sep 14, 9:15 am)
Re: cpu hotplug support broken in 2.6.23-rc3, Thomas Gleixner, (Sat Sep 15, 5:49 am)
Re: cpu hotplug support broken in 2.6.23-rc3, Pavel Machek, (Tue Oct 2, 5:45 am)
Re: cpu hotplug support broken in 2.6.23-rc3, Andrew Morton, (Sat Sep 15, 6:18 am)
Re: cpu hotplug support broken in 2.6.23-rc3, Thomas Gleixner, (Sat Sep 15, 9:28 am)
Re: cpu hotplug support broken in 2.6.23-rc3, Andrew Morton, (Sat Sep 15, 6:01 pm)
Re: cpu hotplug support broken in 2.6.23-rc3, Thomas Gleixner, (Sat Sep 15, 9:44 am)
Re: cpu hotplug support broken in 2.6.23-rc3, Rafael J. Wysocki, (Mon Aug 27, 5:59 pm)
Re: cpu hotplug support broken in 2.6.23-rc3, Pavel Machek, (Mon Aug 27, 5:58 pm)
Re: cpu hotplug support broken in 2.6.23-rc3, Rafael J. Wysocki, (Tue Aug 28, 6:30 am)
Re: cpu hotplug support broken in 2.6.23-rc3, Akinobu Mita, (Tue Aug 28, 9:00 am)