Re: [ofa-general] [PATCH v2] iw_cxgb3: Support "iwarp-only" interfaces to avoid 4-tuple conflicts.

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Steve Wise <swise@...>
Cc: <rdreier@...>, <sean.hefty@...>, <netdev@...>, <linux-kernel@...>, <general@...>
Date: Thursday, September 13, 2007 - 3:54 pm

> The iWARP driver must translate all listens on address 0.0.0.0 to the

I've only given this a high level review at this point, and while the 
patch looks okay on first pass, is there a way to move some of this 
functionality to either the rdma_cm or iw_cm?  I don't like the idea of 
every iwarp driver having to implement address/listen list maintenance. 
  I may have some ideas after re-examining it.


There are a couple of areas that I made a note to look at in more detail 
(because I didn't understand everything that was happening), but I did 
have one minor nit - most uses of list_del_init can just be list_del.

- Sean
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [ofa-general] Re: [PATCH v2] iw_cxgb3: Support "iwarp-on..., Evgeniy Polyakov, (Mon Sep 17, 12:17 pm)
Re: [PATCH v2] iw_cxgb3: Support "iwarp-only" interfaces to ..., Evgeniy Polyakov, (Sun Sep 16, 10:22 am)
Re: [ofa-general] [PATCH v2] iw_cxgb3: Support "iwarp-only" ..., Sean Hefty, (Thu Sep 13, 3:54 pm)