On Thu, Sep 13, 2007 at 08:34:00PM +0200, Sam Ravnborg wrote:

quoted text
> A few. Please address them and resubmit with full changelog and
> proper attribution (if possible) and a signed-of-by.

sure

quoted text
> I would strongly prefer the name "build-pkg".

right

quoted text
> The prefix -pkg is just to use the magic in top-level Makefile to
> dicert it to the right Makefile.

yeah, i had something a bit like originally but didn't like the name
so changed it and poked the top-level Makefile

quoted text
> I would like to attribute whoever made this somehow.

so would i, i assume it was davej + others so i cc'd him on this
hoping for feedback

quoted text
> This becomes obsolete when target is named -pkg

yes

quoted text
> Here we could do a $(MAKE) KBUILD_SRC= clean
> This will leave all files needed for building external modules
> but delete the rest (almost).

ok, i'll try that

quoted text
> set -e to bail out on error could do it for now.

will do

quoted text
> kbuild will not like it either so you can drop this FIXME

ok


quoted text
> > +# This relies on the following environment variables being sane and
> > +# passed in from the Makefiles:
> > +#
> > +#    INSTALL_MINTREE_PATH
> > +#    KERNELVERSION

quoted text
> Could we pass this as parameters. This makes it explicit.
> You do not need to check them since this script is not
> supposed to be used stand-alone.

can do

quoted text
> > +if [ "$srctree" != "$objtree" ] ; then
> > +    cp --parents $(find -type f -name "Makefile*" -o -name "Kconfig*" -not -ipath "$objtree/*Makefile" ) ${tgtdir}
>                                                                                                ^
> Why this wildcard??? (objtree/>*<Makefile)
> Seems to be a typing error.

no, it's so we catch things like

linux/build/Makefile

 *and*

linux/build/foo/bar/Makefile

quoted text
> > +#rm -rf ${tgtdir}/Documentation
> Remove this line since it is commented out

right, actually, it can be uncommented but the 'make help' fails; i'm
not sure if we need make help to work since most of the other targets
won't anyhow

so should i remove it (leaving 'make help' as usable) or remove it?

quoted text
> > +rm -f ${tgtdir}/scripts/*.o
> > +rm -f ${tgtdir}/scripts/*/*.o
> If we do the make clean this is not needed.

ok

quoted text
> Something less hardcoded are preferred. Maybe like:
> cp -a `ls | grep -v ^asm` asm-generic $(tgtdir}/include

ok (though i'm not a big fan of ls | grep as a rule, it tends to be
fragile when people do dumb things)

quoted text
> Here we use readlink but in next line we use $ARCH.
> We should be consitent and use ARCH all over.

i tried to preserve as much logic as possible from the original
script, at least initially

i'll change that

quoted text
> > +if [ "$ARCH" = "x86_64" ]; then
> > +    cp -a asm-i386 ${tgtdir}/include
> > +fi
> Too hardcoded.
> Here we could use some sed magic to extract a potential ALTARCH from asm-${ARCH}/Kbuild
> My sed skills are too limited to do this in a minute... :-(

what about something like?

    sed -n "s/^ALTARCH[[:space:]]:=[[:space:]]\(.*$\)\+/\1/p"

(i'm sure there is a better way though)

quoted text
> This part I did not check up on - I assume it is correct.

it all seems to work
-
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/