Home » Mailing list archives » linux-kernel » 2007 » September » 13

Re: [PATCH] Fix race with shared tag queue maps

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Linus Torvalds <torvalds@...>
To: Jens Axboe <jens.axboe@...>
Cc: <linux-kernel@...>, <linux-scsi@...>, <orgis@...>, <arekm@...>, <ed.lin@...>, Andrew Morton <akpm@...>, <James.Bottomley@...>
Subject: Re: [PATCH] Fix race with shared tag queue maps
Date: Thursday, September 13, 2007 - 11:16 am

On Thu, 13 Sep 2007, Jens Axboe wrote:

You don't need the "smp_mb__before_clear_bit()" there.

The regular "clear_bit()" needs it, but the "test_and_xxx()" versions are 
architecturally defined to be memory barriers, exactly because they are 
regularly used for locking.

This is even documented - see Documentation/atomic_ops.txt.

		Linus
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] Fix race with shared tag queue maps, Jens Axboe, (Thu Sep 13, 8:26 am)
Re: [PATCH] Fix race with shared tag queue maps, Arkadiusz Miskiewicz, (Fri Sep 14, 2:19 am)
Re: [PATCH] Fix race with shared tag queue maps, Linus Torvalds, (Thu Sep 13, 11:16 am)
Re: [PATCH] Fix race with shared tag queue maps, Jens Axboe, (Thu Sep 13, 11:22 am)
Re: [PATCH] Fix race with shared tag queue maps, Linus Torvalds, (Thu Sep 13, 11:42 am)
Re: [PATCH] Fix race with shared tag queue maps, Jens Axboe, (Fri Sep 14, 3:47 am)