On Wed, Sep 12, 2007 at 05:38:17PM -0700, Andrew Morton wrote:Partially implemented - my point 1 seems to have been addressed but not point 2. Point 2 is rather important, otherwise you can end up with a port in stopped mode with no way to get it transmitting. Also, it doesn't seem to be tweaking the DTR signal at all, so how does it tell the remote end to stop transmitting? Essentially, the author needs to search for CRTSCTS in serial_core.c and *carefully* consider whether they need to modify those places as well. I stress carefully, because at the moment we start the tty whenever we move from CRTSCTS to no CRTSCTS. If you're moving CRTSCTS->CDTRDSR then you only want to do this iff DSR is asserted. -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: -
| Kamalesh Babulal | [BUG] Linux 2.6.25-rc2 - Kernel Ooops while running dbench |
| Vu Pham | Re: [Scst-devel] Integration of SCST in the mainstream Linux kernel |
| Greg Kroah-Hartman | [PATCH 002/196] Chinese: rephrase English introduction in HOWTO |
| Gabriel C | Re: Linux 2.6.21-rc2 |
git: | |
| Gerrit Renker | [PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side) |
| Jarek Poplawski | [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock(). |
| David Miller | Re: [GIT]: Networking |
| Jeff Garzik | Re: [bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin" |
