Re: DTR/DSR Patch

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Andrew Morton <akpm@...>
Cc: Michael Westermann <michael@...>, <linux-kernel@...>
Date: Thursday, September 13, 2007 - 3:47 am

On Wed, Sep 12, 2007 at 05:38:17PM -0700, Andrew Morton wrote:

Partially implemented - my point 1 seems to have been addressed but not
point 2.  Point 2 is rather important, otherwise you can end up with a
port in stopped mode with no way to get it transmitting.

Also, it doesn't seem to be tweaking the DTR signal at all, so how does
it tell the remote end to stop transmitting?

Essentially, the author needs to search for CRTSCTS in serial_core.c and
*carefully* consider whether they need to modify those places as well.
I stress carefully, because at the moment we start the tty whenever
we move from CRTSCTS to no CRTSCTS.  If you're moving CRTSCTS->CDTRDSR
then you only want to do this iff DSR is asserted.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
DTR/DSR Patch, Michael Westermann, (Fri Aug 31, 9:17 am)
Re: DTR/DSR Patch, Andrew Morton, (Wed Sep 12, 8:38 pm)
Re: DTR/DSR Patch, Russell King, (Thu Sep 13, 3:47 am)