login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2007
»
September
»
12
Re: [patch] sunrpc: make closing of old temporary sockets work (was: problems with lockd in 2.6.22.6)
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From: J. Bruce Fields
Subject:
Re: [patch] sunrpc: make closing of old temporary sockets work (was: problems with lockd in 2.6.22.6)
Date: Wednesday, September 12, 2007 - 12:55 pm
On Wed, Sep 12, 2007 at 09:40:57PM +0200, Wolfgang Walter wrote:
quoted text
> On Wednesday 12 September 2007, J. Bruce Fields wrote: > > On Wed, Sep 12, 2007 at 04:14:06PM +0200, Neil Brown wrote: > > > So it is in 2.6.21 and later and should probably go to .stable for .21 > > > and .22. > > > > > > Bruce: for you :-) > > > > OK, thanks! But, (as is alas often the case) I'm still confused: > > > > > if (!test_and_set_bit(SK_OLD, &svsk->sk_flags)) > > > continue; > > > - if (atomic_read(&svsk->sk_inuse) || test_bit(SK_BUSY, &svsk->sk_flags)) > > > + if (atomic_read(&svsk->sk_inuse) > 1 > > > + || test_bit(SK_BUSY, &svsk->sk_flags)) > > > continue; > > > atomic_inc(&svsk->sk_inuse); > > > list_move(le, &to_be_aged); > > > > What is it that ensures svsk->sk_inuse isn't incremented or SK_BUSY set > > after that test? Not all the code that does either of those is under > > the same serv->sv_lock lock that this code is. > > > > This should not matter - SK_CLOSED may be set at any time. > > svc_age_temp_sockets only detaches the socket, sets SK_CLOSED and then > enqueues it. If SK_BUSY is set its already enqueued and svc_sock_enqueue > ensures that it is not enqueued twice.
Oh, got it. And the list manipulation is safe thanks to sv_lock. Neat, thanks. Can you verify that this solves your problem? --b. -
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
Re: [patch] sunrpc: make closing of old temporary sockets ...
, Neil Brown
, (Wed Sep 12, 7:14 am)
Re: [patch] sunrpc: make closing of old temporary sockets ...
, J. Bruce Fields
, (Wed Sep 12, 11:42 am)
Re: [patch] sunrpc: make closing of old temporary sockets ...
, Wolfgang Walter
, (Wed Sep 12, 12:40 pm)
Re: [patch] sunrpc: make closing of old temporary sockets ...
, J. Bruce Fields
, (Wed Sep 12, 12:55 pm)
Re: [patch] sunrpc: make closing of old temporary sockets ...
, Wolfgang Walter
, (Wed Sep 12, 3:18 pm)
Re: [patch] sunrpc: make closing of old temporary sockets ...
, Wolfgang Walter
, (Fri Sep 14, 2:12 am)
Re: [patch] sunrpc: make closing of old temporary sockets ...
, J. Bruce Fields
, (Fri Sep 14, 7:29 am)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
FUJITA Tomonori
Re: [Scst-devel] Integration of SCST in the mainstream Linux kernel
Ingo Molnar
Re: [RFC/RFT PATCH] sched: automated per tty task groups
Benjamin Herrenschmidt
[git pull] Please pull powerpc.git merge branch
Vivek Goyal
Re: [PATCH v4] sched: automated per session task groups
Bart Van Assche
Re: Integration of SCST in the mainstream Linux kernel
git
:
Mike Miller
git message
Junio C Hamano
Re: [PATCH] Detached HEAD (experimental)
Stefan Richter
Re: [kernel.org users] [RFD] On deprecating "git-foo" for builtins
Jeff King
Re: [PATCH] t7004: test that "git-tag -u" implies "-s"
A Large Angry SCM
Re: [RFC] origin link for cherry-pick and revert
git-commits-head
:
Linux Kernel Mailing List
libata: disable ATAPI AN by default
Linux Kernel Mailing List
ARM: 5905/1: ARM: Global ASID allocation on SMP
Linux Kernel Mailing List
Documentation/timers/hpet_example.c: only build on X86
Linux Kernel Mailing List
ALSA: hda - Enable beep on Realtek codecs with PCI SSID override
Linux Kernel Mailing List
i915: Don't whine when pci_enable_msi() fails.
linux-netdev
:
Arnaldo Carvalho de Melo
Re: [PATCH 06/37] dccp: Limit feature negotiation to connection setup phase
Gerrit Renker
[PATCH 1/5] dccp: Initialisation framework for feature negotiation
Daniel Lezcano
getsockopt(TCP_DEFER_ACCEPT) value change
David Miller
Re: 2.6.27.18: bnx2/tg3: BUG: "scheduling while atomic" trying to ifenslave a seco...
Jeff Garzik
Re: [PATCH] drivers/net: remove network drivers' last few uses of IRQF_SAMPLE_RANDOM
openbsd-misc
:
Stuart Henderson
Re: Kuro5hin: OpenBSD Founder Theo deRaadt Has Conflict of Interest With AMD
Christian Weisgerber
Re: CARP with a single public IP address
Marco Peereboom
Re: OpenBSD culture?
"RALOVICH, Kristóf"
Re: thinkpad windows refund
Kevin
Re: uvm_mapent_alloc: out of static map entries on 4.3 i386
Colocation donated by:
Syndicate