To: Andy Whitcroft <apw@...>, <balbir@...>, Andrew Morton <akpm@...>
Cc: Nick Piggin <npiggin@...>, Linux Memory Management List <linux-mm@...>, Joachim Deguara <joachim.deguara@...>, Christoph Lameter <clameter@...>, Mel Gorman <mel@...>, Eric Whitney <eric.whitney@...>, linux-kernel <linux-kernel@...>
On Wed, 2007-09-12 at 16:41 +0100, Andy Whitcroft wrote:
Problem isolated to memory controller patches. This patch seems to fix
this particular problem. I've only run the test for a few minutes with
and without memory controller configured, but I did observe reclaim
kicking in several times. W/o this patch, system would panic as soon as
I entered direct/zone reclaim--less than a minute.
Lee
--------------------------------
PATCH 2.6.23-rc4-mm1 Memory Controller: initialize all scan_controls'
isolate_pages member.
We need to initialize all scan_controls' isolate_pages member.
Otherwise, shrink_active_list() attempts to execute at undefined
location.
Signed-off-by: Lee Schermerhorn <lee.schermerhorn@hp.com>
mm/vmscan.c | 2 ++
1 file changed, 2 insertions(+)
Index: Linux/mm/vmscan.c
===================================================================
--- Linux.orig/mm/vmscan.c 2007-09-10 13:22:21.000000000 -0400
+++ Linux/mm/vmscan.c 2007-09-12 15:30:27.000000000 -0400
@@ -1758,6 +1758,7 @@ unsigned long shrink_all_memory(unsigned
.swap_cluster_max = nr_pages,
.may_writepage = 1,
.swappiness = vm_swappiness,
+ .isolate_pages = isolate_pages_global,
};
current->reclaim_state = &reclaim_state;
@@ -1941,6 +1942,7 @@ static int __zone_reclaim(struct zone *z
SWAP_CLUSTER_MAX),
.gfp_mask = gfp_mask,
.swappiness = vm_swappiness,
+ .isolate_pages = isolate_pages_global,
};
unsigned long slab_reclaimable;
-
