Randy,

This patch is fine, and I am committing it to the for_mm kgdb tree.

I am also adding the "depends on NET" to the KGDBOE_NOMODULE section, 
which would otherwise to a select on KGDBOE. We have to cover the case 
for KGDB as a module and not as a module.

Thanks,
Jason.

Randy Dunlap wrote:
quoted text
> On Wed, 12 Sep 2007 13:15:12 -0500 Matt Mackall wrote:
>
>   
>> NETCONSOLE shouldn't be necessary. Otherwise this looks ok to my
>> kconfig-addled brain.
>>     
>
> Correct.  Patch corrected.  Thanks.
>
> ---
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Fix kgdb build problems:
>   Building modules, stage 2.
> ERROR: "netpoll_cleanup" [drivers/net/kgdboe.ko] undefined!
> ERROR: "netpoll_setup" [drivers/net/kgdboe.ko] undefined!
> ERROR: "netpoll_parse_options" [drivers/net/kgdboe.ko] undefined!
> ERROR: "netpoll_poll" [drivers/net/kgdboe.ko] undefined!
> ERROR: "netpoll_send_udp" [drivers/net/kgdboe.ko] undefined!
> ERROR: "netpoll_set_trap" [drivers/net/kgdboe.ko] undefined!
> make[1]: *** [__modpost] Error 1
>
>
> Add 'select' for net-poll related config symbols, but
> make KGDBOE 'depend on' NET.  We don't want to 'select' CONFIG_NET,
> but if it is already enabled, the 'select's will enable the rest
> of the needed interfaces.
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
>  lib/Kconfig.kgdb |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> --- linux-2.6.23-rc4-mm1.orig/lib/Kconfig.kgdb
> +++ linux-2.6.23-rc4-mm1/lib/Kconfig.kgdb
> @@ -174,9 +174,10 @@ endchoice
>  
>  config KGDBOE
>  	tristate "KGDB: On ethernet" if !KGDBOE_NOMODULE
> -	depends on m && KGDB
> +	depends on m && KGDB && NET
>  	select NETPOLL
>  	select NETPOLL_TRAP
> +	select NET_POLL_CONTROLLER
>  	help
>  	  Uses the NETPOLL API to communicate with the host GDB via UDP.
>  	  In order for this to work, the ethernet interface specified must
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2005.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________
> Kgdb-bugreport mailing list
> Kgdb-bugreport@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/kgdb-bugreport
>   

-
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/