login
Header Space

 
 

[PATCH 03/15] Call spu_acquire_saved() before calculating the SPU note sizes

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <linuxppc-dev@...>
Cc: Jeremy Kerr <jk@...>, <linux-kernel@...>
Date: Wednesday, September 12, 2007 - 3:43 am

It makes sense to stop the SPU processes as soon as possible. Also if we
dont acquire_saved() I think there's a possibility that the value in
csa.priv2.spu_lslr_RW won't be accurate.

Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
---
 arch/powerpc/platforms/cell/spufs/coredump.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/arch/powerpc/platforms/cell/spufs/coredump.c b/arch/powerpc/platforms/cell/spufs/coredump.c
index 6663669..21283f6 100644
--- a/arch/powerpc/platforms/cell/spufs/coredump.c
+++ b/arch/powerpc/platforms/cell/spufs/coredump.c
@@ -135,7 +135,9 @@ static int spufs_arch_notes_size(void)
 
 	fd = 0;
 	while ((ctx = coredump_next_context(&fd)) != NULL) {
+		spu_acquire_saved(ctx);
 		rc = spufs_ctx_note_size(ctx, fd);
+		spu_release_saved(ctx);
 		if (rc < 0)
 			break;
 
-- 
1.5.1.3.g7a33b

-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 14/15] Respect RLIMIT_CORE in spu coredump code, Michael Ellerman, (Wed Sep 12, 3:43 am)
[PATCH 15/15] Add DEFINE_SPUFS_ATTRIBUTE(), Michael Ellerman, (Wed Sep 12, 3:43 am)
Re: [PATCH 15/15] Add DEFINE_SPUFS_ATTRIBUTE(), Michael Ellerman, (Wed Sep 12, 3:49 am)
Re: [PATCH 15/15] Add DEFINE_SPUFS_ATTRIBUTE(), Arnd Bergmann, (Wed Sep 12, 4:47 am)
Re: [PATCH 15/15] Add DEFINE_SPUFS_ATTRIBUTE(), Michael Ellerman, (Wed Sep 12, 10:05 pm)
Re: [PATCH 15/15] Add DEFINE_SPUFS_ATTRIBUTE(), Arnd Bergmann, (Thu Sep 13, 8:17 am)
[PATCH 11/15] Combine spufs_coredump_calls with spufs_calls, Michael Ellerman, (Wed Sep 12, 3:43 am)
[PATCH 12/15] Cleanup ELF coredump extra notes logic, Michael Ellerman, (Wed Sep 12, 3:43 am)
[PATCH 10/15] Add contents of npc file to SPU coredumps, Michael Ellerman, (Wed Sep 12, 3:43 am)
[PATCH 05/15] Write some SPU coredump values as ASCII, Michael Ellerman, (Wed Sep 12, 3:43 am)
[PATCH 03/15] Call spu_acquire_saved() before calculating th..., Michael Ellerman, (Wed Sep 12, 3:43 am)
[PATCH 02/15] Remove ctx_info and ctx_info_list, Michael Ellerman, (Wed Sep 12, 3:43 am)
speck-geostationary