Home » Mailing list archives » linux-kernel » 2007 » September » 11

Re: [PATCH -mm] add-a-rounddown_pow_of_two-routine-to-log2h.patch fix

Previous thread: BUG POWERPC: snd-powermac hangs since 'Merge 32 and 64 bits asm-powerpc/io.h' by Dave Vasilevsky on Saturday, September 1, 2007 - 12:58 am. (1 message)

Next thread: [PATCH] skge: unbalanced parenthesis fix by Mariusz Kozlowski on Saturday, September 1, 2007 - 2:10 am. (3 messages)
[view original message]
From: Mariusz Kozlowski <m.kozlowski@...>
To: Andrew Morton <akpm@...>
Cc: Robert Day <rpjday@...>, lkml <linux-kernel@...>
Subject: [PATCH -mm] add-a-rounddown_pow_of_two-routine-to-log2h.patch fix
Date: Saturday, September 1, 2007 - 1:55 am

Hello,


	This patch fixes the unbalanced parenthesis inroduced by

add-a-rounddown_pow_of_two-routine-to-log2h.patch.


Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>


 include/linux/log2.h |    2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)


--- linux-2.6.23-rc4-mm1-a/include/linux/log2.h	2007-09-01 07:23:28.000000000 +0200

+++ linux-2.6.23-rc4-mm1-b/include/linux/log2.h	2007-09-01 07:29:27.000000000 +0200

@@ -186,7 +186,7 @@ unsigned long __rounddown_pow_of_two(uns

 (						\

 	__builtin_constant_p(n) ? (		\

 		(n == 1) ? 0 :			\

-		(1UL << ilog2(n)) :		\

+		(1UL << ilog2(n))) :		\

 	__rounddown_pow_of_two(n)		\

  )


-
[view original message]
From: Andrew Morton <akpm@...>
To: Mariusz Kozlowski <m.kozlowski@...>
Cc: Robert Day <rpjday@...>, lkml <linux-kernel@...>
Subject: Re: [PATCH -mm] add-a-rounddown_pow_of_two-routine-to-log2h.patch fix
Date: Tuesday, September 11, 2007 - 11:43 pm

umm, could we get some users of this thing, preferably in some code

path which people use?

-
[view original message]
From: Robert P. J. Day <rpjday@...>
To: Mariusz Kozlowski <m.kozlowski@...>
Cc: Andrew Morton <akpm@...>, lkml <linux-kernel@...>
Subject: Re: [PATCH -mm] add-a-rounddown_pow_of_two-routine-to-log2h.patch fix
Date: Saturday, September 1, 2007 - 2:46 am

oh, crap ... how did that happen?  sorry.


rday

--

========================================================================

Robert P. J. Day

Linux Consulting, Training and Annoying Kernel Pedantry

Waterloo, Ontario, CANADA


http://crashcourse.ca

========================================================================

-
Previous thread: BUG POWERPC: snd-powermac hangs since 'Merge 32 and 64 bits asm-powerpc/io.h' by Dave Vasilevsky on Saturday, September 1, 2007 - 12:58 am. (1 message)

Next thread: [PATCH] skge: unbalanced parenthesis fix by Mariusz Kozlowski on Saturday, September 1, 2007 - 2:10 am. (3 messages)