SSB uses a bool (SSB_PCMCIAHOST_POSSIBLE) to determine whether to
build in PCMCIA support or not, as the PCMCIA host code itself is
also only a bool, make SSB_PCMCIAHOST_POSSIBLE depend on PCMCIA=y.

Without this, SSB_PCMCIAHOST_POSSIBLE evaluates to y when PCMCIA
is built as a module, which results in link errors due to the
pcmcia_access_configuration_register() accesses, where the symbol
is only defined in a module.

Signed-off-by: Paul Mundt <lethal@linux-sh.org>

--

 drivers/ssb/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-2.6.23-rc4-mm1.orig/drivers/ssb/Kconfig	2007-09-11 15:15:52.000000000 +0900
+++ linux-2.6.23-rc4-mm1/drivers/ssb/Kconfig	2007-09-12 10:51:53.000000000 +0900
@@ -37,7 +37,7 @@
 
 config SSB_PCMCIAHOST_POSSIBLE
 	bool
-	depends on SSB && PCMCIA && EXPERIMENTAL
+	depends on SSB && PCMCIA=y && EXPERIMENTAL
 	default y
 
 config SSB_PCMCIAHOST
-

[ message continues ]

There we go. The usual SELECT dependency hell again...
Would changing SSB_PCMCIAHOST_POSSIBLE to tristate also fix it?
What would be the sideeffects?

I think this PCMCIA=y is not good, because it's perfectly
legal to build PCMCIA as module, while SSB and everything
that depends on SSB is also a module.
Would tristate fix that?

-- 
Greetings Michael.
-

[ message continues ]

I tried that first, if you do that you have to change the default to
SSB && PCMCIA, and then anything that depends on it also has to be a
tristate. That worked ok for SSB_PCMCIAHOST, but it didn't work ok for
the b43 wireless + PCMCIA, which is why I opted for the PCMCIA=y thing
instead, which makes sure that SSB_PCMCIAHOST can't be enabled if PCMCIA
is modular.
-

[ message continues ]

Ok, so much for "SELECT is easy and it works if used correctly..." :)
Well, let's apply that patch then. It needlessly restricts the
choice to not allow modular pcmcia in that case, though.

-- 
Greetings Michael.
-

[ message continues ]

That is the compromise, yes. Feel free to propose a better solution ;-)
-

[ message continues ]

I just ran into this link error (CONFIG_PCMCIA=m;
CONFIG_SSB_PCMCIAHOST=y).  No big deal; I don't have the hardware.


--
Joseph Fannin
jfannin@gmail.com

-

[ message continues ]

config SSB_PCMCIAHOST_POSSIBLE
        bool
        depends on SSB && PCMCIA && EXPERIMENTAL
        default y

config SSB_PCMCIAHOST
        bool "Support for SSB on PCMCIA-bus host (EXPERIMENTAL)"
        depends on SSB_PCMCIAHOST_POSSIBLE
        help

What tree are you using?

-- 
John W. Linville
linville@tuxdriver.com
-

[ message continues ]