Home » Mailing list archives » linux-kernel » 2007 » September » 11

[PATCH -mm] ssb: Make pcmciahost depend on PCMCIA=y

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Paul Mundt <lethal@...>
To: Andrew Morton <akpm@...>
Cc: Michael Buesch <mb@...>, <linux-kernel@...>
Subject: [PATCH -mm] ssb: Make pcmciahost depend on PCMCIA=y
Date: Tuesday, September 11, 2007 - 10:11 pm

SSB uses a bool (SSB_PCMCIAHOST_POSSIBLE) to determine whether to
build in PCMCIA support or not, as the PCMCIA host code itself is
also only a bool, make SSB_PCMCIAHOST_POSSIBLE depend on PCMCIA=y.

Without this, SSB_PCMCIAHOST_POSSIBLE evaluates to y when PCMCIA
is built as a module, which results in link errors due to the
pcmcia_access_configuration_register() accesses, where the symbol
is only defined in a module.

Signed-off-by: Paul Mundt <lethal@linux-sh.org>

--

 drivers/ssb/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-2.6.23-rc4-mm1.orig/drivers/ssb/Kconfig	2007-09-11 15:15:52.000000000 +0900
+++ linux-2.6.23-rc4-mm1/drivers/ssb/Kconfig	2007-09-12 10:51:53.000000000 +0900
@@ -37,7 +37,7 @@
 
 config SSB_PCMCIAHOST_POSSIBLE
 	bool
-	depends on SSB && PCMCIA && EXPERIMENTAL
+	depends on SSB && PCMCIA=y && EXPERIMENTAL
 	default y
 
 config SSB_PCMCIAHOST
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH -mm] ssb: Make pcmciahost depend on PCMCIA=y, Paul Mundt, (Tue Sep 11, 10:11 pm)
Re: [PATCH -mm] ssb: Make pcmciahost depend on PCMCIA=y, Michael Buesch, (Wed Sep 12, 6:09 am)
Re: [PATCH -mm] ssb: Make pcmciahost depend on PCMCIA=y, Paul Mundt, (Wed Sep 12, 6:17 am)
Re: [PATCH -mm] ssb: Make pcmciahost depend on PCMCIA=y, Michael Buesch, (Wed Sep 12, 6:59 am)
Re: [PATCH -mm] ssb: Make pcmciahost depend on PCMCIA=y, Paul Mundt, (Wed Sep 12, 9:43 pm)
Re: [PATCH -mm] ssb: Make pcmciahost depend on PCMCIA=y, Joseph Fannin, (Thu Sep 20, 3:42 pm)
Re: [PATCH -mm] ssb: Make pcmciahost depend on PCMCIA=y, John W. Linville, (Thu Sep 20, 4:33 pm)