Home » Mailing list archives » linux-kernel » 2007 » September » 11

[PATCH] powerpc: add new required termio functions

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Michael Neuling <mikey@...>
To: Linus Torvalds <torvalds@...>, <akpm@...>, <paulus@...>, Alan Cox <alan@...>, David S. Miller <davem@...>
Cc: <linux-kernel@...>, <linuxppc-dev@...>
Subject: [PATCH] powerpc: add new required termio functions
Date: Tuesday, September 11, 2007 - 10:04 pm

The "tty: termios locking functions break with new termios type" patch
(f629307c857c030d5a3dd777fee37c8bb395e171) breaks the powerpc compile.
This adds the required API to asm-powerpc.

Signed-off-by: Michael Neuling <mikey@neuling.org>
--
This needs to go up for 2.6.23.

Should we really put these definitions in asm-generic/termios.h as I'm
guessing other architectures are broken too?

coopers@include/ % git grep kernel_termios_to_user_termios_1
asm-arm/termios.h:#define kernel_termios_to_user_termios_1(u, k)
asm-cris/termios.h:#define kernel_termios_to_user_termios_1(u, k)
asm-h8300/termios.h:#define kernel_termios_to_user_termios_1(u, k)
asm-i386/termios.h:#define kernel_termios_to_user_termios_1(u, k)
asm-ia64/termios.h:#define kernel_termios_to_user_termios_1(u, k)
asm-m32r/termios.h:#define kernel_termios_to_user_termios_1(u, k)
asm-m68k/termios.h:#define kernel_termios_to_user_termios_1(u, k)
asm-mips/termios.h:#define kernel_termios_to_user_termios_1(u, k)
asm-v850/termios.h:#define kernel_termios_to_user_termios_1(u, k)
asm-x86_64/termios.h:#define kernel_termios_to_user_termios_1(u, k)

 include/asm-powerpc/termios.h |    3 +++
 1 file changed, 3 insertions(+)

Index: linux-2.6-ozlabs/include/asm-powerpc/termios.h
===================================================================
--- linux-2.6-ozlabs.orig/include/asm-powerpc/termios.h
+++ linux-2.6-ozlabs/include/asm-powerpc/termios.h
@@ -80,6 +80,9 @@ struct termio {
 
 #include <asm-generic/termios.h>
 
+#define user_termios_to_kernel_termios_1(k, u) copy_from_user(k, u, sizeof(struct termios))
+#define kernel_termios_to_user_termios_1(u, k) copy_to_user(u, k, sizeof(struct termios))
+
 #endif	/* __KERNEL__ */
 
 #endif	/* _ASM_POWERPC_TERMIOS_H */

-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] powerpc: add new required termio functions, Michael Neuling, (Tue Sep 11, 10:04 pm)
Re: [PATCH] powerpc: add new required termio functions, Heiko Carstens, (Wed Sep 12, 6:20 am)
Re: [PATCH] powerpc: add new required termio functions, Andrew Morton, (Wed Sep 12, 7:01 am)
Re: [PATCH] powerpc: add new required termio functions, Christoph Hellwig, (Wed Sep 12, 7:34 am)
Re: [PATCH] powerpc: add new required termio functions, Heiko Carstens, (Wed Sep 12, 7:52 am)
Re: [PATCH] powerpc: add new required termio functions, Christoph Hellwig, (Wed Sep 12, 9:49 am)
Re: [PATCH] powerpc: add new required termio functions, Alan Cox, (Fri Sep 14, 10:20 am)
Re: [PATCH] powerpc: add new required termio functions , Michael Neuling, (Wed Sep 12, 7:16 am)
Re: [PATCH] powerpc: add new required termio functions, Geoff Levand, (Tue Sep 11, 10:19 pm)
Re: [PATCH] powerpc: add new required termio functions, Linus Torvalds, (Tue Sep 11, 10:17 pm)
Re: [PATCH] powerpc: add new required termio functions , Michael Neuling, (Tue Sep 11, 10:34 pm)
Re: [PATCH] powerpc: add new required termio functions, Tony Breeds, (Tue Sep 11, 10:33 pm)