Home » Mailing list archives » linux-kernel » 2007 » September » 11

[PATCH 1/4] Generic AC97 mixer/modem (OSS): Use list_for_each_entry

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Matthias Kaehlcke <matthias.kaehlcke@...>
To: <perex@...>, <linux-kernel@...>, <akpm@...>
Subject: [PATCH 1/4] Generic AC97 mixer/modem (OSS): Use list_for_each_entry
Date: Tuesday, September 11, 2007 - 5:05 pm

Generic AC97 mixer/modem (OSS): Use list_for_each_entry instead of
list_for_each

Signed-off-by: Matthias Kaehlcke <matthias.kaehlcke@gmail.com>

--

diff --git a/sound/oss/ac97_codec.c b/sound/oss/ac97_codec.c
index fef56ca..0a3033b 100644
--- a/sound/oss/ac97_codec.c
+++ b/sound/oss/ac97_codec.c
@@ -815,7 +815,6 @@ int ac97_probe_codec(struct ac97_codec *codec)
 	int i;
 	char cidbuf[CODEC_ID_BUFSZ];
 	u16 f;
-	struct list_head *l;
 	struct ac97_driver *d;
 	
 	/* wait for codec-ready state */
@@ -891,8 +890,7 @@ int ac97_probe_codec(struct ac97_codec *codec)
 	mutex_lock(&codec_mutex);
 	list_add(&codec->list, &codecs);
 
-	list_for_each(l, &codec_drivers) {
-		d = list_entry(l, struct ac97_driver, list);
+	list_for_each_entry(d, &codec_drivers, list) {
 		if ((codec->model ^ d->codec_id) & d->codec_mask)
 			continue;
 		if(d->probe(codec, d) == 0)
@@ -1400,14 +1398,12 @@ EXPORT_SYMBOL(ac97_set_adc_rate);
 
 static int swap_headphone(int remove_master)
 {
-	struct list_head *l;
 	struct ac97_codec *c;
 	
 	if (remove_master) {
 		mutex_lock(&codec_mutex);
-		list_for_each(l, &codecs)
+		list_for_each_entry(c, &codecs, list)
 		{
-			c = list_entry(l, struct ac97_codec, list);
 			if (supported_mixer(c, SOUND_MIXER_PHONEOUT))
 				c->supported_mixers &= ~SOUND_MASK_PHONEOUT;
 		}

-- 
Matthias Kaehlcke
Linux Application Developer
Barcelona

              We build too many walls and not enough bridges
                             (Isaac Newton)
                                                                 .''`.
    using free software / Debian GNU/Linux | http://debian.org  : :'  :
                                                                `. `'`
gpg --keyserver pgp.mit.edu --recv-keys 47D8E5D4                  `-
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 0/4] Several sound drivers: Use list_for_each_entry(_..., Matthias Kaehlcke, (Tue Sep 11, 4:56 pm)
[PATCH 4/4] Routines for effect processor FX8010: Use list_f..., Matthias Kaehlcke, (Tue Sep 11, 5:12 pm)
[PATCH 3/4] Intel HD Audio: Use list_for_each_entry(_safe), Matthias Kaehlcke, (Tue Sep 11, 5:10 pm)
[PATCH 2/4] ESS Maestro 1/2/2E Sound Card: Use list_for_each..., Matthias Kaehlcke, (Tue Sep 11, 5:08 pm)
[PATCH 1/4] Generic AC97 mixer/modem (OSS): Use list_for_eac..., Matthias Kaehlcke, (Tue Sep 11, 5:05 pm)