Exactly my point from KS. The big mash-up will not really make much difference
in terms of Makefile clarity or whatever Thomas' point was. Apparently he
wanted to eliminate a few lines of code from the Makefile and merge
the header files completely?
Anyways, the end result will be roughly the same as it is now: i386 and x86-64
are shared in not completely obvious ways and if you change one you have to
test compile the other too.
Same old, same old, as always.
In the end it won't make much difference where the files are located
(although I frankly don't see the advantage of this intrusive move).
You always have to at least compile test both if you change one and I doubt
most people will be able to avoid this no matter how the Makefile looks
or where the files are.
Even if everything was merged together and only ifdefs remained that
fundamental fact would not change either.
A few more files could be also definitely shared, no argument. e.g.
the time subsystem will likely to be shared soon anyways. And probably
a few others. That should be better all done carefully step by step and
properly reviewed though, not in some kind of brutal "rewrite the world"
event.
My concern is mostly that he seems to want to merge some things between 32bit
and 64bit (like the APIC drivers or the crappy i386 maze-of-inlines
subarchitecture design) which ought not be together. I think I managed to
keep x86-64 a relatively clean port over-all, but I see this now going down
the drain :/
-Andi
-
