> -----Message d'origine-----
quoted text
> De : linux-kernel-owner@vger.kernel.org=20
> [mailto:linux-kernel-owner@vger.kernel.org] De la part de Nick Bowler
>=20
> I haven't read too much into the patch, but some quick=20
> comments.  Most applies
> throughout:
>=20
> > +#if (LINUX_VERSION_CODE >=3D 0x020616)
> KERNEL_VERSION(2,6,22) is much more readable than 0x020616.
>=20
> > +  return (struct iphdr*) skb->network_header;
> Should be return ip_hdr(skb);
>=20
> > +    skb->network_header =3D skb->data;
> Should be skb_reset_network_header(skb);
>=20
> > +    iph =3D skb->network_header.iph;
> Probably meant skb->nh.iph.
>=20
> > +  if ( iph->protocol =3D=3D 17 )            /* if UDP, */
> (snip)
> > +  if ( iph->protocol =3D=3D 6 )             /* if TCP, */
> Could use IPPROTO_UDP and IPPROTO_TCP instead of 17 and 6,=20
> respectively.
>=20
> Instead of littering the code with #if blah #else blah, you=20
> could also simply provide implementations for the 2.6.22=20
> functions #if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,22).
>=20

(Forwarding info by Samuel to lkml...)

Thanks for your comments, here is a new patch (bowler.patch) reflecting =
the changes you suggested. Unfortunately, and unsurprisingly for such =
cosmetic changes, the code still hangs.

I have added a great many debugging statements in order to pinpoint the =
problem (backtrace.patch); surprisingly, my custom backtraces didn't =
show up in the console, but a kernel call trace did (call_trace).

Here is the contents of the offending function. The {enter,exit}_func() =
calls are my debugging statements, and I have verified that only the =
else branch was compiled. As you can see, there are only function calls =
here, no memory manipulation nor dereferencing at all. What could =
possibly fail in this function? Shouldn`t the backtrace include one of =
the subcalls?

  void nl_spin_lock_irqsave(spinlock_t *lockptr, DWORD *flagptr)
  {
  enter_func(__LINE__);
  #if (LINUX_VERSION_CODE < KERNEL_VERSION(2,6,7))
          assert(lockptr);
          assert(flagptr);
          spin_lock_irqsave((spinlock_t *)lockptr, (*flagptr));
  #else
          spin_lock_irq((spinlock_t *)lockptr);
  #endif
  exit_func(__LINE__);
  }

- Samuel G=E9lineau