Re: sk98lin for 2.6.23-rc1

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Adrian Bunk <bunk@...>
Cc: Stephen Hemminger <shemminger@...>, Kyle Rose <krose@...>, James Corey <ploversegg@...>, Rob Sims <lkml-z@...>, <linux-kernel@...>, Jeff Garzik <jeff@...>, <netdev@...>
Date: Tuesday, September 11, 2007 - 10:29 am

Adrian Bunk wrote:
Sorry for a long answer, I'm trying to provide insight on two recent cases.

Thinking back to several drivers, when e100 was new I tried it because I 
had problems with eepro100 in the area of multiple cards, multiple 
cables on a single card, and jumbo packets. For a while I used both, 
until e100 worked where I need it. So I initially tried it because it 
had features I needed, and then dropped to older driver just to avoid 
having to decide.

With sk98lin, the driver worked flawlessly with all (3-4) systems, so I 
had no reason to try any other. When removing sk98lin was first 
proposed, I tried skge, first measurements showed it was 5-8% slower, 
NOT what I want, so I went back. For me there was no reliability issue, 
but I never tried it in a system with more than on NIC on the driver. 
Would "it's a little slower" be a valid bug report? Or would I have 
gotten "works fine for me" from people not beating it over Gbit? I 
didn't try sky2 until you suggested it, and I have reported my results 
previously, just stops working. Could it be my hardware? I tried it on 
one system, so yes, but sk98lin works for months.

So if you want people to try a new driver, I think it really has to have 
some benefits to the users, in terms of performance, reliability, or 
features. "Cleaner design" doesn't motivate, and it does raise the 
question of why the old driver wasn't just cleaned up. I've been doing 
software for decades, I appreciate why, but users in general just want 
to use their system. Which raises the question of why to delete drivers 
which work for many or even most users? Testing a new kernel is no 
longer a drop in a boot operation if modprobe.conf must be edited to get 
the network up, and the typical user isn't going to write that shell 
script to try one or the other driver.

Honestly, new drivers which offer little benefit to most users are the 
exception rather than the rule, so this may a corner case I would like 
to see sk98lin back in the kernel, for a while I can build my own 
kernels and patch it in, but until other drivers are drop-in, I probably 
won't change.

Separate but related: why keep skge and sky2? Are we going through this 
again in a year? Is the benefit worth the effort?

Hope some of this is helpful.

-- 
bill davidsen <davidsen@tmr.com>
  CTO TMR Associates, Inc
  Doing interesting things with small computers since 1979

-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
sk98lin for 2.6.23-rc1, Kyle Rose, (Thu Jul 26, 11:16 am)
Re: sk98lin for 2.6.23-rc1, Bill Davidsen, (Thu Jul 26, 7:52 pm)
Re: sk98lin for 2.6.23-rc1, Kyle Rose, (Thu Jul 26, 9:13 pm)
Re: sk98lin for 2.6.23-rc1, Stephen Hemminger, (Thu Jul 26, 3:17 pm)
Re: sk98lin for 2.6.23-rc1, Adrian Bunk, (Thu Jul 26, 12:57 pm)
Re: sk98lin for 2.6.23-rc1, Rob Sims, (Sun Jul 29, 11:01 pm)
Re: sk98lin for 2.6.23-rc1, Stephen Hemminger, (Wed Sep 5, 5:22 am)
Re: sk98lin for 2.6.23-rc1, Torsten Kaiser, (Wed Sep 12, 12:46 pm)
Re: sk98lin for 2.6.23-rc1, James Corey, (Wed Sep 5, 3:42 pm)
Re: sk98lin for 2.6.23-rc1, Bill Davidsen, (Sat Sep 8, 1:44 pm)
Re: sk98lin for 2.6.23-rc1, Adrian Bunk, (Sat Sep 8, 3:11 pm)
Re: sk98lin for 2.6.23-rc1, Bill Davidsen, (Mon Sep 10, 10:32 am)
Re: sk98lin for 2.6.23-rc1, Adrian Bunk, (Mon Sep 10, 11:39 am)
Re: sk98lin for 2.6.23-rc1, Kyle Moffett, (Tue Sep 11, 12:23 am)
Re: sk98lin for 2.6.23-rc1, Chris Stromsoe, (Sun Sep 9, 8:54 am)
Re: sk98lin for 2.6.23-rc1, Stephen Hemminger, (Tue Nov 6, 6:23 pm)
Re: sk98lin for 2.6.23-rc1, Chris Stromsoe, (Tue Nov 6, 9:42 pm)
Re: sk98lin for 2.6.23-rc1, Kyle Rose, (Sat Sep 8, 10:42 pm)
Re: sk98lin for 2.6.23-rc1, Adrian Bunk, (Sun Sep 9, 7:13 am)
Re: sk98lin for 2.6.23-rc1, Stephen Hemminger, (Tue Sep 11, 4:05 am)
Re: sk98lin for 2.6.23-rc1, James Corey, (Tue Sep 11, 6:20 pm)
Re: sk98lin for 2.6.23-rc1, Adrian Bunk, (Tue Sep 11, 7:54 am)
Re: sk98lin for 2.6.23-rc1, Bill Davidsen, (Tue Sep 11, 10:29 am)
Re: sk98lin for 2.6.23-rc1, Adrian Bunk, (Tue Sep 11, 11:03 am)
Re: sk98lin for 2.6.23-rc1, Willy Tarreau, (Tue Sep 11, 6:37 pm)
Re: sk98lin for 2.6.23-rc1, Willy Tarreau, (Sun Sep 9, 12:48 am)
Re: sk98lin for 2.6.23-rc1, Kyle Rose, (Wed Sep 5, 5:04 pm)
Re: sk98lin for 2.6.23-rc1, Stephen Hemminger, (Wed Sep 5, 7:00 pm)
Re: sk98lin for 2.6.23-rc1, Bill Davidsen, (Thu Jul 26, 7:38 pm)
Re: sk98lin for 2.6.23-rc1, Jeff Garzik, (Thu Jul 26, 7:41 pm)
Re: sk98lin for 2.6.23-rc1, Chris Stromsoe, (Thu Jul 26, 6:58 pm)
Re: sk98lin for 2.6.23-rc1, Jan Engelhardt, (Thu Jul 26, 12:28 pm)
Re: sk98lin for 2.6.23-rc1, Kyle Rose, (Thu Jul 26, 12:30 pm)
Re: sk98lin for 2.6.23-rc1, Jan Engelhardt, (Thu Jul 26, 12:41 pm)
Re: sk98lin for 2.6.23-rc1, Kyle Rose, (Thu Jul 26, 9:07 pm)