Home » Mailing list archives » linux-kernel » 2007 » September » 10

Re: [-mm patch] unexport sys_{open,read}

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Rene Herman <rene.herman@...>
To: Adrian Bunk <bunk@...>
Cc: Andrew Morton <akpm@...>, Al Viro <viro@...>, Christoph Hellwig <hch@...>, <perex@...>, <linux-kernel@...>
Subject: Re: [-mm patch] unexport sys_{open,read}
Date: Monday, September 10, 2007 - 6:56 pm

On 09/11/2007 12:41 AM, Adrian Bunk wrote:


I agree that doing things only half is semi-regularly worse than doing them 
not at all, and this specific case might be the worst example of all, as I 
read that using sys_open/read is actively harmful, so, well...

I read the thread since I tend to keep lots of external crap around. Not in 
any way that would mean I'd have any grounds for complaining about anything; 
mostly just driver stuff in various states of completeness that I never seem 
to get around to cleaning up enough to submit to anyone.

But as such, I can comment on the fact that I'm much more likely to notice 
the warning than I am to notice a thread on LKML, say. How much more likely 
I'd be to then also actually do anything about it before it just breaks 
anyway is another matter, but again, well...


In this case I believe it makes sense to just rip it out, but generally it 
doesn't need to be such a fully robotic yes/no decision, I'd say.

Rene.
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[-mm patch] unexport sys_{open,read}, Adrian Bunk, (Sun Sep 9, 4:25 pm)
Re: [-mm patch] unexport sys_{open,read}, Christoph Hellwig, (Sun Sep 9, 4:39 pm)
Re: [-mm patch] unexport sys_{open,read}, David Miller, (Mon Sep 10, 8:18 am)
Re: [-mm patch] unexport sys_{open,read}, Adrian Bunk, (Tue Sep 18, 10:10 am)
Re: [-mm patch] unexport sys_{open,read}, Christoph Hellwig, (Mon Sep 10, 8:21 am)
Re: [-mm patch] unexport sys_{open,read}, Andrew Morton, (Sun Sep 9, 5:59 pm)
Re: [-mm patch] unexport sys_{open,read}, Christoph Hellwig, (Mon Sep 10, 5:08 am)
Re: [-mm patch] unexport sys_{open,read}, Andrew Morton, (Mon Sep 10, 5:23 am)
Re: [-mm patch] unexport sys_{open,read}, Arjan van de Ven, (Mon Sep 10, 11:14 am)
Re: [-mm patch] unexport sys_{open,read}, Dave Jones, (Tue Sep 25, 5:17 pm)
Re: [-mm patch] unexport sys_{open,read}, Al Viro, (Mon Sep 10, 8:43 am)
Re: [-mm patch] unexport sys_{open,read}, Andrew Morton, (Mon Sep 10, 1:25 pm)
Re: [-mm patch] unexport sys_{open,read}, Adrian Bunk, (Mon Sep 10, 3:58 pm)
Re: [-mm patch] unexport sys_{open,read}, Andrew Morton, (Mon Sep 10, 4:17 pm)
Re: [-mm patch] unexport sys_{open,read}, Adrian Bunk, (Mon Sep 10, 6:18 pm)
Re: [-mm patch] unexport sys_{open,read}, Rene Herman, (Mon Sep 10, 6:15 pm)
Re: [-mm patch] unexport sys_{open,read}, Adrian Bunk, (Mon Sep 10, 6:41 pm)
Re: [-mm patch] unexport sys_{open,read}, Rene Herman, (Mon Sep 10, 6:56 pm)
Re: [-mm patch] unexport sys_{open,read}, Alan Cox, (Mon Sep 10, 1:44 pm)
Re: [-mm patch] unexport sys_{open,read}, Andrew Morton, (Mon Sep 10, 1:54 pm)
Re: [-mm patch] unexport sys_{open,read}, Greg KH, (Thu Sep 13, 7:23 pm)
Re: [-mm patch] unexport sys_{open,read}, Alan Cox, (Mon Sep 10, 8:31 am)
Re: [-mm patch] unexport sys_{open,read}, Adrian Bunk, (Mon Sep 10, 8:03 am)
Re: [-mm patch] unexport sys_{open,read}, Adrian Bunk, (Sun Sep 9, 6:22 pm)
Re: [-mm patch] unexport sys_{open,read}, Arjan van de Ven, (Sun Sep 9, 6:41 pm)
Re: [-mm patch] unexport sys_{open,read}, Adrian Bunk, (Sun Sep 9, 7:18 pm)