Re: [RFC] kbuild - introduce vdir to make life easier for x86_64

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Sam Ravnborg <sam@...>
Cc: Thomas Gleixner <tglx@...>, LKML <linux-kernel@...>, kbuild devel <kbuild-devel@...>
Date: Monday, September 10, 2007 - 6:40 pm

> The below are the minimal clean-up - a bit more could be done.

Looks good in principle. My only suggestion would be to name it something
differently than vdir. I know that's what GNU make calls it, but it's still
pretty cryptic. How about just fallback-dir ? 

Also what would be nice (I don't know if it's doable in make) would
be a separate variable (e.g. other-obj-... := ) that contains the fallback
names and that is double checked against the fallback directory. That
would document it clearly what's going on. Failing that stuffing 
them into a comment would be good at least.

-Andi

-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [RFC] kbuild - introduce vdir to make life easier for x8..., Andi Kleen, (Mon Sep 10, 6:40 pm)