Home » Mailing list archives » linux-kernel » 2007 » September » 10

Re: [PATCH] crypto: blkcipher_get_spot() handling of buffer at end of page

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Ingo Oeser <ioe-lkml@...>
To: Herbert Xu <herbert@...>
Cc: Bob Gilligan <gilligan@...>, <linux-kernel@...>, Linux Crypto Mailing List <linux-crypto@...>
Subject: Re: [PATCH] crypto: blkcipher_get_spot() handling of buffer at end of page
Date: Monday, September 10, 2007 - 3:46 pm

Hi Herbert,

On Monday 10 September 2007, Herbert Xu wrote:

What about using max() for this to make your intention obvious?

static inline u8 *blkcipher_get_spot(u8 *start, unsigned int len)
{
	u8 *end_page = (u8 *)(((unsigned long)(start + len - 1)) & PAGE_MASK); 
	return max(start, end_page);
}


Best Regards

Ingo Oeser 
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] crypto: blkcipher_get_spot() handling of buffer at e..., Bob Gilligan, (Fri Sep 7, 8:09 pm)
Re: [PATCH] crypto: blkcipher_get_spot() handling of buffer ..., Herbert Xu, (Sat Sep 8, 12:14 am)
Re: [PATCH] crypto: blkcipher_get_spot() handling of buffer ..., Herbert Xu, (Mon Sep 10, 3:58 am)
Re: [PATCH] crypto: blkcipher_get_spot() handling of buffer ..., Ingo Oeser, (Mon Sep 10, 3:46 pm)
Re: [PATCH] crypto: blkcipher_get_spot() handling of buffer ..., Herbert Xu, (Tue Sep 11, 4:40 am)
[PATCH] crypto: cleanup: Use max() in blkcipher_get_spot() t..., Ingo Oeser, (Tue Sep 11, 3:53 pm)
Re: [PATCH] crypto: cleanup: Use max() in blkcipher_get_spot..., Herbert Xu, (Wed Sep 19, 7:16 am)