Home » Mailing list archives » linux-kernel » 2007 » September » 10

[PATCH 12/13] Be more agressive about stealing when MIGRATE_RECLAIMABLE allocations fallback

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Mel Gorman <mel@...>
To: <akpm@...>
Cc: Mel Gorman <mel@...>, <linux-kernel@...>, <linux-mm@...>
Subject: [PATCH 12/13] Be more agressive about stealing when MIGRATE_RECLAIMABLE allocations fallback
Date: Monday, September 10, 2007 - 7:24 am

Subject: Be more agressive about stealing when MIGRATE_RECLAIMABLE allocations fallback

MIGRATE_RECLAIMABLE allocations tend to be very bursty in nature like when
updatedb starts.  It is likely this will occur in situations where MAX_ORDER
blocks of pages are not free.  This means that updatedb can scatter
MIGRATE_RECLAIMABLE pages throughout the address space.  This patch is more
agressive about stealing blocks of pages for MIGRATE_RECLAIMABLE.

Signed-off-by: Mel Gorman <mel@csn.ul.ie>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 mm/page_alloc.c |   23 +++++++++++++++++------
 1 file changed, 17 insertions(+), 6 deletions(-)

diff -rup -X /usr/src/patchset-0.6/bin//dontdiff linux-2.6.23-rc5-011-bias-the-placement-of-kernel-pages-at-lower-pfns/mm/page_alloc.c linux-2.6.23-rc5-012-be-more-agressive-about-stealing-when-migrate_reclaimable-allocations-fallback/mm/page_alloc.c
--- linux-2.6.23-rc5-011-bias-the-placement-of-kernel-pages-at-lower-pfns/mm/page_alloc.c	2007-09-02 16:22:27.000000000 +0100
+++ linux-2.6.23-rc5-012-be-more-agressive-about-stealing-when-migrate_reclaimable-allocations-fallback/mm/page_alloc.c	2007-09-02 16:22:47.000000000 +0100
@@ -713,7 +713,7 @@ int move_freepages(struct zone *zone,
 {
 	struct page *page;
 	unsigned long order;
-	int blocks_moved = 0;
+	int pages_moved = 0;
 
 #ifndef CONFIG_HOLES_IN_ZONE
 	/*
@@ -742,10 +742,10 @@ int move_freepages(struct zone *zone,
 		list_add(&page->lru,
 			&zone->free_area[order].free_list[migratetype]);
 		page += 1 << order;
-		blocks_moved++;
+		pages_moved += 1 << order;
 	}
 
-	return blocks_moved;
+	return pages_moved;
 }
 
 int move_freepages_block(struct zone *zone, struct page *page, int migratetype)
@@ -817,11 +817,22 @@ static struct page *__rmqueue_fallback(s
 
 			/*
 			 * If breaking a large block of pages, move all free
-			 * pages to the preferred allocation list
+			 * pages to the preferred allocation list. If falling
+			 * back for a reclaimable kernel allocation, be more
+			 * agressive about taking ownership of free pages
 			 */
-			if (unlikely(current_order >= (pageblock_order >> 1)))
+			if (unlikely(current_order >= (pageblock_order >> 1)) ||
+					start_migratetype == MIGRATE_RECLAIMABLE) {
+				unsigned long pages;
+				pages = move_freepages_block(zone, page,
+								start_migratetype);
+
+				/* Claim the whole block if over half of it is free */
+				if (pages >= (1 << (pageblock_order-1)))
+					set_pageblock_migratetype(page,
+								start_migratetype);
+
 				migratetype = start_migratetype;
-				move_freepages_block(zone, page, migratetype);
 			}
 
 			/* Remove the page from the freelists */
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 0/13] Reduce external fragmentation by grouping pages..., Mel Gorman, (Mon Sep 10, 7:20 am)
Re: [PATCH 0/13] Reduce external fragmentation by grouping p..., Andrew Morton, (Thu Sep 13, 9:01 pm)
Re: [PATCH 0/13] Reduce external fragmentation by grouping p..., Mel Gorman, (Fri Sep 14, 10:33 am)
Re: [PATCH 0/13] Reduce external fragmentation by grouping p..., Andrew Morton, (Sun Sep 16, 6:34 am)
[PATCH 13/13] Print out statistics in relation to fragmentat..., Mel Gorman, (Mon Sep 10, 7:24 am)
[PATCH 12/13] Be more agressive about stealing when MIGRATE_..., Mel Gorman, (Mon Sep 10, 7:24 am)
[PATCH 11/13] Bias the placement of kernel pages at lower pfns, Mel Gorman, (Mon Sep 10, 7:23 am)
[PATCH 10/13] Bias the location of pages freed for min_free_..., Mel Gorman, (Mon Sep 10, 7:23 am)
[PATCH 9/13] Do not group pages by mobility type on low memo..., Mel Gorman, (Mon Sep 10, 7:23 am)
[PATCH 8/13] Move free pages between lists on steal, Mel Gorman, (Mon Sep 10, 7:22 am)
[PATCH 7/13] Drain per-cpu lists when high-order allocations..., Mel Gorman, (Mon Sep 10, 7:22 am)
Re: [PATCH 7/13] Drain per-cpu lists when high-order allocat..., Nick Piggin, (Mon Sep 10, 11:05 am)
Re: [PATCH 7/13] Drain per-cpu lists when high-order allocat..., Mel Gorman, (Tue Sep 11, 5:34 am)
[PATCH 6/13] Group short-lived and reclaimable kernel alloca..., Mel Gorman, (Mon Sep 10, 7:22 am)
Re: Group short-lived and reclaimable kernel allocations, Paul Jackson, (Mon Sep 10, 3:44 pm)
Re: Group short-lived and reclaimable kernel allocations, Mel Gorman, (Mon Sep 10, 5:15 pm)
[PATCH 5/13] Choose pages from the per cpu list-based on mig..., Mel Gorman, (Mon Sep 10, 7:21 am)
[PATCH 4/13] Split the free lists for movable and unmovable ..., Mel Gorman, (Mon Sep 10, 7:21 am)
[PATCH 3/13] Fix corruption of memmap on ia64-sparsemem when..., Mel Gorman, (Mon Sep 10, 7:21 am)
[PATCH 2/13] Add a bitmap that is used to track flags affect..., Mel Gorman, (Mon Sep 10, 7:20 am)
[PATCH 1/13] ia64: parse kernel parameter hugepagesz= in ear..., Mel Gorman, (Mon Sep 10, 7:20 am)