login
Header Space

 
 

Re: v2.6.23-rc4-rt1 / new project URL

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Thomas Gleixner <tglx@...>
Cc: LKML <linux-kernel@...>, RT-Users <linux-rt-users@...>, Ingo Molnar <mingo@...>
Date: Friday, August 31, 2007 - 8:01 pm

On Fri, 2007-08-31 at 22:59 +0200, Thomas Gleixner wrote:

I'm not sure which latency tracing fixes these are, but Steven's
get_monotonic_cycles() changes are racy .. It might be a little
premature to include them .. It at least fouls latency tracing on my
test machine.


The PICK_OP changes got reviewed by Ingo , as of,

http://marc.info/?l=linux-rt-users&m=118638506125380&w=2

They do need one small fix tho .. Below ..

Signed-off-by: Daniel Walker <dwalker@mvista.com>

Index: linux-2.6.22/include/linux/spinlock.h
===================================================================
--- linux-2.6.22.orig/include/linux/spinlock.h	2007-09-01 00:08:04.000000000 +0000
+++ linux-2.6.22/include/linux/spinlock.h	2007-09-01 00:07:48.000000000 +0000
@@ -501,7 +501,7 @@ do {									\
 
 #define spin_trylock_irq(lock)	\
 	__cond_lock(lock, PICK_SPIN_OP_RET(__spin_trylock_irq,		\
-		__spin_trylock_irq, lock))
+		_spin_trylock_irq, lock))
 
 #define spin_trylock_irqsave(lock, flags) \
 	__cond_lock(lock, PICK_SPIN_OP_RET(__spin_trylock_irqsave, 	\


-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
v2.6.23-rc4-rt1 / new project URL, Thomas Gleixner, (Fri Aug 31, 4:59 pm)
Re: v2.6.23-rc4-rt1 / new project URL, Peter Zijlstra, (Mon Sep 10, 8:35 am)
Re: v2.6.23-rc4-rt1 / new project URL, Peter Zijlstra, (Wed Sep 26, 5:16 pm)
Re: v2.6.23-rc4-rt1 / new project URL, Steven Rostedt, (Wed Sep 26, 5:27 pm)
Re: v2.6.23-rc4-rt1 / new project URL, Daniel Walker, (Mon Sep 10, 11:18 am)
Re: v2.6.23-rc4-rt1 / new project URL, Peter Zijlstra, (Mon Sep 10, 12:15 pm)
[LOCKDEP] v2.6.23-rc4-rt1, Sven-Thorsten Dietrich, (Mon Sep 3, 3:13 am)
Re: v2.6.23-rc4-rt1 / new project URL, Daniel Walker, (Sat Sep 1, 11:50 am)
Re: v2.6.23-rc4-rt1 / new project URL, Daniel Walker, (Fri Aug 31, 8:01 pm)
Re: v2.6.23-rc4-rt1 / new project URL, Thomas Gleixner, (Sat Sep 1, 3:27 am)
Re: v2.6.23-rc4-rt1 / new project URL, Steven Rostedt, (Sun Sep 2, 9:16 pm)
Re: v2.6.23-rc4-rt1 / new project URL, Daniel Walker, (Sat Sep 1, 10:25 am)
speck-geostationary