On Sat, Aug 04, 2007 at 08:32:12PM +0200, Jesper Juhl wrote:
quoted text > I don't think dev_id can ever actually be NULL, so the whole block
> inside "if (!dev) {" could probably just go away. But I guess
> there's a good reason someone put that ULI526X_DBUG() in there - and
> if 'dev_id' /can/ actually be NULL then it's nice to have and in
> that case this patch actually fixes a possible crash (hence the
> version number update).
It *can* be null, in the case of another handler being registered on the
same irq number, passing NULL for the cookie.
Ack. Will apply.
Regards,
Kyle
-
unsubscribe notice To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Messages in current thread:
Re: [PATCH][RESEND] Semi-pointless NULL test in uli526x driver , Kyle McMartin , (Sat Aug 4, 2:14 pm)