Re: [1/4] 2.6.23-rc4: known regressions

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Andrew Morton <akpm@...>
Cc: Jan Dittmer <jdi@...>, Adrian Bunk <bunk@...>, Michal Piotrowski <michal.k.k.piotrowski@...>, Linus Torvalds <torvalds@...>, LKML <linux-kernel@...>, <linux-alpha@...>
Date: Friday, August 31, 2007 - 3:48 am

Here is the fix for alpha:



Subject: SLUB: Force inlining for functions in slub_def.h

Some compilers (especially older gcc releases) may skip inlining sometimes 
which will lead to link failures. Force the inlining of keyfunctions in 
slub_def.h to avoid these issues.

Signed-off-by: Christoph Lameter <clameter@sgi.com>
Acked-by: Jan Dittmer <jdi@l4x.org>

---
 include/linux/slub_def.h |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Index: linux-2.6/include/linux/slub_def.h
===================================================================
--- linux-2.6.orig/include/linux/slub_def.h	2007-08-30 14:12:25.000000000 -0700
+++ linux-2.6/include/linux/slub_def.h	2007-08-30 14:13:07.000000000 -0700
@@ -78,7 +78,7 @@ extern struct kmem_cache kmalloc_caches[
  * Sorry that the following has to be that ugly but some versions of GCC
  * have trouble with constant propagation and loops.
  */
-static inline int kmalloc_index(size_t size)
+static __always_inline int kmalloc_index(size_t size)
 {
 	if (!size)
 		return 0;
@@ -133,7 +133,7 @@ static inline int kmalloc_index(size_t s
  * This ought to end up with a global pointer to the right cache
  * in kmalloc_caches.
  */
-static inline struct kmem_cache *kmalloc_slab(size_t size)
+static __always_inline struct kmem_cache *kmalloc_slab(size_t size)
 {
 	int index = kmalloc_index(size);
 
@@ -166,7 +166,7 @@ static inline struct kmem_cache *kmalloc
 void *kmem_cache_alloc(struct kmem_cache *, gfp_t);
 void *__kmalloc(size_t size, gfp_t flags);
 
-static inline void *kmalloc(size_t size, gfp_t flags)
+static __always_inline void *kmalloc(size_t size, gfp_t flags)
 {
 	if (__builtin_constant_p(size) && !(flags & SLUB_DMA)) {
 		struct kmem_cache *s = kmalloc_slab(size);
@@ -183,7 +183,7 @@ static inline void *kmalloc(size_t size,
 void *__kmalloc_node(size_t size, gfp_t flags, int node);
 void *kmem_cache_alloc_node(struct kmem_cache *, gfp_t flags, int node);
 
-static inline void *kmalloc_node(size_t size, gfp_t flags, int node)
+static __always_inline void *kmalloc_node(size_t size, gfp_t flags, int node)
 {
 	if (__builtin_constant_p(size) && !(flags & SLUB_DMA)) {
 		struct kmem_cache *s = kmalloc_slab(size);
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[1/4] 2.6.23-rc4: known regressions, Michal Piotrowski, (Wed Aug 29, 11:26 am)
Re: [1/4] 2.6.23-rc4: known regressions, Jeff Chua, (Wed Aug 29, 3:07 pm)
Re: [1/4] 2.6.23-rc4: known regressions, Jan Dittmer, (Wed Aug 29, 2:04 pm)
Re: [1/4] 2.6.23-rc4: known regressions, Adrian Bunk, (Wed Aug 29, 7:47 pm)
Re: [1/4] 2.6.23-rc4: known regressions, Christoph Lameter, (Wed Aug 29, 8:39 pm)
Re: [1/4] 2.6.23-rc4: known regressions, Jan Dittmer, (Thu Aug 30, 3:10 am)
Re: [1/4] 2.6.23-rc4: known regressions, Christoph Lameter, (Thu Aug 30, 2:12 pm)
Re: [1/4] 2.6.23-rc4: known regressions, Jan Dittmer, (Thu Aug 30, 2:46 pm)
Re: [1/4] 2.6.23-rc4: known regressions, Christoph Lameter, (Fri Aug 31, 3:48 am)
Re: [1/4] 2.6.23-rc4: known regressions, Adrian Bunk, (Fri Aug 31, 4:03 am)
Re: [1/4] 2.6.23-rc4: known regressions, Christoph Lameter, (Wed Aug 29, 8:11 pm)