[PATCH] ACPI: EC: Check if boot_ec was really found in DSDT

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Linus Torvalds <torvalds@...>
Cc: Daniel Ritz <daniel.ritz-ml@...>, Luca Tettamanti <kronos.it@...>, <linux-kernel@...>, Len Brown <len.brown@...>, Andrew Morton <akpm@...>
Date: Friday, August 31, 2007 - 1:05 am

From: Alexey Starikovskiy <astarikovskiy@suse.de>

acpi_get_devices() returns success if it did not find any device.
We have to check for this case.

Signed-off-by: Alexey Starikovskiy <astarikovskiy@suse.de>
---

 drivers/acpi/ec.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
index 43749c8..3f7935a 100644
--- a/drivers/acpi/ec.c
+++ b/drivers/acpi/ec.c
@@ -886,7 +886,8 @@ int __init acpi_ec_ecdt_probe(void)
         printk(KERN_DEBUG PREFIX "Look up EC in DSDT\n");
         status = acpi_get_devices(ec_device_ids[0].id, ec_parse_device,
                         boot_ec, NULL);
-        if (ACPI_FAILURE(status))
+        /* Check that acpi_get_devices actually find something */
+        if (ACPI_FAILURE(status) || !boot_ec->handle)
             goto error;
     }
 

-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: Linux 2.6.23-rc4: BAD regression, Daniel Ritz, (Tue Aug 28, 7:29 pm)
Re: Linux 2.6.23-rc4: BAD regression, Luca Tettamanti, (Wed Aug 29, 7:21 pm)
Re: Linux 2.6.23-rc4: BAD regression, Daniel Ritz, (Thu Aug 30, 1:07 pm)
Re: Linux 2.6.23-rc4: BAD regression, Linus Torvalds, (Thu Aug 30, 1:21 pm)
[PATCH] ACPI: EC: Check if boot_ec was really found in DSDT, Alexey Starikovskiy, (Fri Aug 31, 1:05 am)
Re: [PATCH] ACPI: EC: Check if boot_ec was really found in D..., Alexey Starikovskiy, (Fri Aug 31, 1:29 am)
Re: mail client to send patches, Alexey Starikovskiy, (Fri Aug 31, 1:47 am)
Re: Linux 2.6.23-rc4: BAD regression, Luca, (Thu Aug 30, 3:17 pm)
Re: Linux 2.6.23-rc4: BAD regression, Alexey Starikovskiy, (Wed Aug 29, 12:41 am)
Re: Linux 2.6.23-rc4: BAD regression, Daniel Ritz, (Wed Aug 29, 3:35 pm)
Re: Linux 2.6.23-rc4: BAD regression, Alexey Starikovskiy, (Wed Aug 29, 3:45 pm)
Re: Linux 2.6.23-rc4: BAD regression, Daniel Ritz, (Wed Aug 29, 4:55 pm)
Re: Linux 2.6.23-rc4: BAD regression, Linus Torvalds, (Tue Aug 28, 7:42 pm)