linux-kernel mailing list

FromSubjectsort iconDate
Jason Gaston
[PATCH 2.6.23-rc4] i2c-i801: Documentation patch for Intel T...
This patch adds the Intel Tolapai SMBus Controller text to i2c-i801 documentation. Signed-off-by:  Jason Gaston <jason.d.gaston@intel.com> --- linux-2.6.23-rc4/Documentation/i2c/busses/i2c-i801.orig 2007-08-30 15:56:39.000000000 -0700 +++ linux-2.6.23-rc4/Documentation/i2c/busses/i2c-i801 2007-08-30 15:57:32.000000000 -0700 @@ -13,7 +13,8 @@ * Intel 631xESB/632xESB (ESB2) * Intel 82801H (ICH8) * Intel ICH9 - Datasheets: Publicly available at the Intel website + * Intel...
Aug 30, 7:02 pm 2007
Jason Gaston
[PATCH 2.6.23-rc4] i2c-i801: SMBus patch for Intel Tolapai
This updated patch adds the Intel Tolapai LPC and SMBus Controller DID's.  This patch relies on the irq Tolapai patch to pci_ids.h. Signed-off-by:  Jason Gaston <jason.d.gaston@intel.com> --- linux-2.6.23-rc4/drivers/i2c/busses/Kconfig.orig 2007-08-27 18:32:35.000000000 -0700 +++ linux-2.6.23-rc4/drivers/i2c/busses/Kconfig 2007-08-28 16:58:26.000000000 -0700 @@ -156,6 +156,7 @@ ESB2 ICH8 ICH9 + Tolapai This driver can also be built as a module. If so,...
Aug 30, 6:48 pm 2007
Jason Gaston
[PATCH 2.6.23-rc4] irq: irq and pci_ids patch for Intel Tola...
This updated patch adds the Intel Tolapai LPC and SMBus Controller DID's. Signed-off-by:  Jason Gaston <jason.d.gaston@intel.com> --- linux-2.6.23-rc4/arch/i386/pci/irq.c.orig 2007-08-27 18:32:35.000000000 -0700 +++ linux-2.6.23-rc4/arch/i386/pci/irq.c 2007-08-28 16:58:31.000000000 -0700 @@ -550,6 +550,7 @@ case PCI_DEVICE_ID_INTEL_ICH9_3: case PCI_DEVICE_ID_INTEL_ICH9_4: case PCI_DEVICE_ID_INTEL_ICH9_5: + case PCI_DEVICE_ID_INTEL_Tolapai_0: r->name = "PIIX/ICH"; ...
Aug 30, 6:46 pm 2007
Jason Gaston
[PATCH 2.6.23-rc4] ata_piix: IDE mode SATA patch for Intel T...
This updated patch adds the Intel Tolapai IDE mode SATA controller DID. Signed-off-by:  Jason Gaston <jason.d.gaston@intel.com> --- linux-2.6.23-rc4/drivers/ata/ata_piix.c.orig 2007-08-27 18:32:35.000000000 -0700 +++ linux-2.6.23-rc4/drivers/ata/ata_piix.c 2007-08-29 17:13:13.000000000 -0700 @@ -130,6 +130,7 @@ ich6m_sata_ahci = 8, ich8_sata_ahci = 9, piix_pata_mwdma = 10, /* PIIX3 MWDMA only */ + tolapai_sata_ahci = 11, /* constants for mapping table */ P0 = 0, /...
Aug 30, 6:44 pm 2007
Jason Gaston
[PATCH 2.6.23-rc4] ahci: RAID mode SATA patch for Intel Tola...
This patch adds the Intel Tolapai RAID controller DID's for SATA support. Signed-off-by:  Jason Gaston <jason.d.gaston@intel.com> --- linux-2.6.23-rc4/drivers/ata/ahci.c.orig 2007-08-27 18:32:35.000000000 -0700 +++ linux-2.6.23-rc4/drivers/ata/ahci.c 2007-08-28 16:58:11.000000000 -0700 @@ -411,6 +411,8 @@ { PCI_VDEVICE(INTEL, 0x292f), board_ahci_pi }, /* ICH9M */ { PCI_VDEVICE(INTEL, 0x294d), board_ahci_pi }, /* ICH9 */ { PCI_VDEVICE(INTEL, 0x294e), board_ahci_pi }, /* ICH9M */ + ...
Aug 30, 6:41 pm 2007
Clemens Kolbitsch
Copy large memory regions from & to userspace
Hi! Just a short question: What is the correct method of copying large areas of memory from userspace into userspace when running in kernel-mode? According to just about any type of documentation out there something like unsigned long *from = 0x08000000; unsigned long *to = 0x09000000; memcpy(to, from, 0x1000); should be avoided as copy_from_user, put_user, etc. should be used instead... Is there a third set of functions for direct from-userspace-to-userspace copying or is it legitimate t...
Aug 30, 6:29 pm 2007
Jesper Juhl
[PATCH] input: Silence 'unused variable' warning in iforce j...
In the iforce driver we currently get this warning drivers/input/joystick/iforce/iforce-packets.c: In function 'iforce_get_id_packet': drivers/input/joystick/iforce/iforce-packets.c:249: warning: unused variable 'status' if CONFIG_JOYSTICK_IFORCE_USB is not defined. The warning is easy to avoid by simply moving the variable inside the only case in the switch that actually use it. Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com> --- diff --git a/drivers/input/joystick/iforce/if...
Aug 30, 6:13 pm 2007
Satyam Sharma
Re: [PATCH] input: Silence 'unused variable' warning in ifor...
Hi, Hmm, would this not still give a warning when JOYSTICK_IFORCE_USB=y? [ I didn't know mixing code and declarations (not at top of statement block) was accepted style in the kernel ... ] IMHO either you should at least wrap that case inside a {} of its own (so that the int status; is at top of a statement block), or else, preferably, just add "__maybe_unused" to the first declaration that you removed just now. Satyam -
Aug 30, 6:57 pm 2007
Jesper Juhl
Re: [PATCH] input: Silence 'unused variable' warning in ifor...
On 31/08/2007, Satyam Sharma <satyam@infradead.org> wrote: Here's an updated patch that actually works as intended. In the iforce driver we currently get this warning drivers/input/joystick/iforce/iforce-packets.c: In function 'iforce_get_id_packet': drivers/input/joystick/iforce/iforce-packets.c:249: warning: unused variable 'status' if CONFIG_JOYSTICK_IFORCE_USB is not defined. The warning is easy to avoid by simply moving the variable inside the only case in the switch ...
Aug 30, 6:50 pm 2007
Al Boldi
Re: Who wants to maintain KR list for stable releases?
Exactly right. The important part in designing isn't the how-to but rather understanding the concepts involved. Once you have the concepts straight, implementation Agreed. But when I responded to this thread by changing the subject, because I felt it was somewhat OT to tracking, I meant to question the mentality of trying to nullify design suggestions for the mere reason of not submitting a prototype. Now, prototyping is a great way to refine your end-product, but it's a terrible waste...
Aug 30, 6:11 pm 2007
Hua Zhong
recent nfs change causes autofs regression
I am re-sending this after help from Ian and git-bisect. To me it's a show-stopper: I cannot find an acceptable workaround that I can implement. The problem: upgrading to 2.6.23-rc4 from 2.6.22 causes several autofs mounts to fail silently - they just not appear when they should. I believe it's caused by the NFS change that forces multiple mounts from different directories under the same server side filesystem to have the same mount options by default, otherwise it returns EBUSY. For example, i...
Aug 30, 5:07 pm 2007
Trond Myklebust
Re: recent nfs change causes autofs regression
Which is better than having it fail silently, or giving you a mount with the wrong mount options. If you need to mount the same filesystem with incompatible mount options on the same client, then there is a new mount option "nosharecache", which enables it. The new option is there in order to make it damned clear to sysadmins that this is a dangerous thing to do: mounts which don't share the same superblock also don't share the same data and attribute caches. Any file or directory which appears ...
Aug 30, 6:37 pm 2007
Hua Zhong
RE: recent nfs change causes autofs regression
Well, it depends on how you define "better". In this particular scenario, the maps read as follows: tools -fstype=nfs,udp,rw,intr,nosuid,nodev,rsize=8192,wsize=8192,mountvers=3,nfsve rs=3,actimeo=600 fs1.domain.com:/a/tools share -fstype=nfs,udp,rw,intr,nosuid,nodev,rsize=8192,wsize=8192,mountvers=3,nfsve rs=3 fs1.domain.com:/a/share The only difference is in the actimeo (I don't even know what it means). Is this enough to fail a mount? More importantly, it is a regression. My understand...
Aug 30, 6:47 pm 2007
Trond Myklebust
RE: recent nfs change causes autofs regression
"better" as in: "I now have a chance to notice, when my 'read-only Yes. The default values for acregmin, acregmax, acdirmin, acdirmax are not 600. If /a/tools and /a/share are on the same filesystem on the server, then the NFS client should warn you that you are about to do something that may result in cache coherency problems instead of silently allowing it, and then leaving you to debug the coherency issue. If you know what you are doing, then there is an option which allows you Your turn t...
Aug 30, 7:22 pm 2007
Hua Zhong
RE: recent nfs change causes autofs regression
There are two disjoint directories. I am wondering why there would be cache coherency issues in this case? Is this Linus nfs implementation specific or "working" as in "I can mount the directory and do my work". And there has Fine. These are all very nice theories, but I just want to report this regression and hope it won't cause any big problems for any users out there. -
Aug 30, 7:30 pm 2007
Trond Myklebust
RE: recent nfs change causes autofs regression
How is the NFS client to know that these directories are disjoint, or that no-one will ever create a hard link from one directory to another? To my knowledge, the only way to ensure this is to put them on different disk partitions. I don't know if all Unix systems have this issue, but I have been told That is too narrow a definition: the minimum should be "everyone can mount their directories and do their work". Your particular setup may be safe, but that is why we have overrides: the default s...
Aug 30, 7:37 pm 2007
Hua Zhong
RE: recent nfs change causes autofs regression
Every engineer in our organization mounts it too. No problem until now. It's not very conservative to suddenly change default behavior and break autofs mounts. There is not even one kernel message that "_tells_ user why No. I have no other choice as I explained before. Hua -
Aug 30, 7:44 pm 2007
Stefan Foerster
IBM ThinkPad T23: Uhhuh. NMI received for unknown reason 30 ...
Hi all, on my IBM ThinkPad T23 I often get the following messages (together with a beep from the speaker): ------------------- Message from syslogd@stefan2 at Thu Aug 30 22:02:17 2007 ... stefan2 kernel: Uhhuh. NMI received for unknown reason 30 on CPU 0. Message from syslogd@stefan2 at Thu Aug 30 22:02:17 2007 ... stefan2 kernel: Do you have a strange power saving mode enabled? Message from syslogd@stefan2 at Thu Aug 30 22:02:17 2007 ... stefan2 kernel: Dazed and confused, but trying to co...
Aug 30, 4:52 pm 2007
Steve French Aug 30, 4:19 pm 2007
Steven Rostedt
[PATCH] Add parenthesis to IRQ vector macros
It is not good taste to have macros with additions that do not have parenthesis's around them. This patch parethesizes the IRQ vector macros for x86_64 arch. Note, this caused me a bit of heart-ache debugging lguest64. Signed-off-by: Steven Rostedt <rostedt@goodmis.org> diff --git a/include/asm-x86_64/hw_irq.h b/include/asm-x86_64/hw_irq.h index 09dfc18..9f00f69 100644 --- a/include/asm-x86_64/hw_irq.h +++ b/include/asm-x86_64/hw_irq.h @@ -40,22 +40,22 @@ /* * Vectors 0x30-0x3f ar...
Aug 30, 4:06 pm 2007
Rob Landley
[PATCH] Documentation/00-INDEX notice ecryptfs.txt moved.
Signed-off-by: Rob Landley <rob@landley.net> ecryptfs.txt moved into Documentation/filesystems, so move the 00-INDEX entry. --- linux-2.6.23-rc4/Documentation/00-INDEX 2007-08-27 20:32:35.000000000 -0500 +++ linux-new/Documentation/00-INDEX 2007-08-30 14:43:15.000000000 -0500 @@ -134,8 +134,6 @@ - info on Linux Digital Video Broadcast (DVB) subsystem. early-userspace/ - info about initramfs, klibc, and userspace early during boot. -ecryptfs.txt - - docs on eCryptfs: stacked cryptogra...
Aug 30, 3:46 pm 2007
Randy Dunlap
Re: [PATCH] Documentation/00-INDEX notice ecryptfs.txt moved.
Please use the expected (canonical) patch format. See Documentation/SubmittingPatches: 14) The canonical patch format Additional help: http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt http://linux.yyz.us/patch-format.html Thanks. --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** -
Aug 30, 3:04 pm 2007
Rob Landley
[PATCH] Documentation/arm/00-INDEX add missing entries.
Signed-off-by: Rob Landley <rob@landley.net> Index two unindexed documentation files. --- linux-2.6.23-rc4/Documentation/arm/00-INDEX 2007-08-27 20:32:35.000000000 -0500 +++ linux-new/Documentation/arm/00-INDEX 2007-08-30 14:27:15.000000000 -0500 @@ -20,3 +20,7 @@ - description of the virtual memory layout nwfpe - NWFPE floating point emulator documentation +Porting + - Symbol definitions for porting Linux to a new ARM machine. +Setup + - Kernel initialization parameters on ARM Lin...
Aug 30, 3:35 pm 2007
Balbir Singh
[-mm PATCH] Memory controller improve user interface (v2)
Change the interface to use kilobytes instead of pages. Page sizes can vary across platforms and configurations. A new strategy routine has been added to the resource counters infrastructure to format the data as desired. Suggested by David Rientjes, Andrew Morton and Herbert Poetzl Tested on a UML setup with the config for memory control enabled. Signed-off-by: Balbir Singh <balbir@linux.vnet.ibm.com> --- Documentation/controllers/memory.txt | 22 +++++++++++++- include/linux/r...
Aug 30, 2:52 pm 2007
Balbir Singh
Re: [-mm PATCH] Memory controller improve user interface (v2)
Typo, the description should be Changelog for version 2 1. Back end tracking is done in bytes, round up values of the limit if the specified value is not a multiple of page size. Display memory.usage and memory.limit in bytes (Dave Hansen, Paul Menage) Change the interface to use bytes instead of pages. Page sizes can vary across platforms and configurations. A new strategy routine has been added to the resource counters infrastructure to format the data as desired. Suggested by Davi...
Aug 30, 3:00 pm 2007
Eric Van Hensbergen
[PATCH] modify lguest console to support multiple hvc's
From: Eric Van Hensbergen <ericvh@ericvh-desktop.austin.ibm.com> This was a quick modification I did of lguest to be able to support multiple HVC channels for some experiements I was doing. I'm not sure if this is more generally useful, so I'm posting it to the list in case someone else has a need for it. Signed-off-by: Eric Van Hensbergen <ericvh@gmail.com> --- Documentation/lguest/lguest.c | 161 ++++++++++++++++++++++++----------------- drivers/char/hvc_lguest.c | 57 ++++...
Aug 30, 2:38 pm 2007
Jason Lunz
jffs2 deadlock introduced in linux 2.6.22.5
commit 1d8715b388c978b0f1b1bf4812fcee0e73b023d7 was added between 2.6.22.4 and 2.6.22.5 to cure a locking problem, but it seems to have introduced another (worse?) one. With a jffs2 filesystem (on block2mtd) on a 2.6.22.5 kernel, if I do anything that appends to a file with many small writes, I get what looks like a deadlock between the writer and the jffs2 gc thread. For example: # while true; do echo >> /some/file/on/jffs2; done will result in the bash hanging in D state, with these ...
Aug 30, 2:23 pm 2007
Randy Dunlap
[PATCH] docs: ramdisk/initrd/initramfs corrections
From: Randy Dunlap <randy.dunlap@oracle.com> initrd/initramfs/ramdisk docs: - fix typos/spellos/grammar - clarify RAM disk config location - correct cpio option Cc: Bryan O'Sullivan <bos@serpentine.com> Cc: Rob Landley <rob@landley.net> Cc: Werner Almesberger <werner@almesberger.net> Cc: H. Peter Anvin <hpa@zytor.com> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> --- Documentation/early-userspace/README | 6 +++--- Documentati...
Aug 30, 2:20 pm 2007
Robert P. J. Day
Re: [PATCH] docs: ramdisk/initrd/initramfs corrections
On Thu, 30 Aug 2007, Randy Dunlap wrote: ... i just the other day submitted a patch to remove that backward compatibility, and the m68k portion of it has already been acked by geert uytterhoeven. rday -- ======================================================================== Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA http://crashcourse.ca ======================================================================== -
Aug 30, 2:28 pm 2007
Rob Landley
Re: [PATCH] docs: ramdisk/initrd/initramfs corrections
Could you mention it in feature-removal-schedule.txt? (People check that for warning of upcoming changes that impact existing code. They may not notice something elsewhere after they've got it working...) (Also, sorting feature-removal-schedule.txt by date would be really nice. The sucker's gotten huge...) And while I'm looking at this, is there some other place that entries in this file go once they _have_ been removed, so people can see "oh yeah, that went away in 2.6.23) when they tr...
Aug 30, 7:36 pm 2007
H. Peter Anvin
Re: [PATCH] docs: ramdisk/initrd/initramfs corrections
The same objection applies to this as to the previous one. In that respect, an Ack from a maintainer of an almost unused architecture is meaningless (sorry, Geert.) -hpa -
Aug 30, 6:41 pm 2007
Randy Dunlap
Re: [PATCH] docs: ramdisk/initrd/initramfs corrections
Peter, what are you objecting to, Rob's comment, Robert's comment, Robert's patch, or my patch? Thanks. --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** -
Aug 30, 7:13 pm 2007
H. Peter Anvin Aug 30, 7:21 pm 2007
Bryan O'Sullivan
Re: [PATCH] docs: ramdisk/initrd/initramfs corrections
Acked-by: Bryan O'Sullivan <bos@serpentine.com> -
Aug 30, 3:13 pm 2007
Rob Landley
Re: [PATCH] docs: ramdisk/initrd/initramfs corrections
Acked-by: Rob Landley <rob@landley.net> Rob -- "One of my most productive days was throwing away 1000 lines of code." - Ken Thompson. -
Aug 30, 7:29 pm 2007
Daniel Drake Aug 30, 1:54 pm 2007
Jesper Juhl
Re: [PATCH 13/30] net: Don't do pointless kmalloc return val...
Ok, I must admit I didn't check with sparse since it seemed pointless - we usually never cast void pointers to other pointer types, specifically because the C language nicely guarantees that the right thing will happen without the cast. Sometimes we have to cast them to integer types, su sure we need the cast there. But what on earth makes a "zd_addr_t *" so special that we have to explicitly cast a "void *" to that type? I see it's defined as typedef u32 __nocast zd_addr_t; in drivers/net/w...
Aug 30, 4:20 pm 2007
Daniel Drake
Re: [PATCH 13/30] net: Don't do pointless kmalloc return val...
We use it as a safety measure when coding. For example the write register function takes an address and a value. We got one of these the wrong way round once, and had a non-obvious bug. nocast and sparse helps us prevent this. Daniel -
Aug 30, 7:47 pm 2007
Joe Perches Aug 30, 6:19 pm 2007
Jesper Juhl
[PATCH] Don't needlessly initialize variable to NULL in zd_c...
Thank you for that link Joe. I'm not sure I agree with the __nocast, but I respect that this is the maintainers choice. But, I still think the first chunk of the patch that removes the initial variable initialization makes sense. Initializing the variable to NULL is pointless since it'll never be used before the kmalloc() call. So here's a revised patch that just gets rid of that little detail. No need to initialize to NULL when variable is never used before it's assigned the return...
Aug 30, 6:30 pm 2007
Randy Dunlap
Re: [PATCH] Don't needlessly initialize variable to NULL in ...
--- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** -
Aug 30, 6:42 pm 2007
Jesper Juhl
Re: [PATCH] Don't needlessly initialize variable to NULL in ...
On 31/08/2007, Randy Dunlap <randy.dunlap@oracle.com> wrote: ... Heh, thanks Randy. All too often patches get missed since I don't happen to include the right magic person to Cc. So I generally take a "better to have one Cc too many than miss one" approach when sending patches - otherwise I just end up resending it several times and eventually have to bother Andrew to move it through -mm. I see the point of people not getting things twice, but too many patches slip through the cracks al...
Aug 30, 7:04 pm 2007
Matti Linnanvuori
[Bugme-new] [Bug 8957] New: Exported functions and variables
I thought I had seen that bug. Module init function execution does not seem serialized enough, so the init function of one module seems to be able to be called in parallel with several other modules in turn being loaded, executing their init functions and even becoming live first class citizens. Function sys_init_module in Linux 2.6.22.x and 2.6.23-rc4 kernel/module.c does not hold module_mutex when executing the init functions of the modules. __________________________________ Alles wa...
Aug 30, 1:44 pm 2007
Clemens Kolbitsch
Forbid deletion of memory mappings
Hi everyone! I have a strange problem where I don't even know if there is a solution to it at the moment: I'm working on a new way of doing memory-management and currently I allocate memory mappings (at non-fixed locations) in user-memory (i.e. < TASK_SIZE) in addition to the regular pages mapped for the apps (e.g. heap memory, etc.) It all works perfectly well (creating & deleting the additional mappings), however, when the kernel feels like it needs to allocate a mapping in user-sp...
Aug 30, 12:44 pm 2007
Jiri Kosina
Re: Forbid deletion of memory mappings
Hi Clemens, what do you mean by "overwrites it"? It just probably merges your vma with the newly created one, right? -- Jiri Kosina -
Aug 30, 1:07 pm 2007
Clemens Kolbitsch
Re: Forbid deletion of memory mappings
does really noone have an answer for me?? i'm having the hardest time to find a work-around for it. is there no way to tell the kernel, that a certain mapping must not be removed, no matter what (except of course an explicit call to sys_unmap, of course)? -
Aug 30, 5:32 pm 2007
Jiri Kosina
Re: Forbid deletion of memory mappings
I don't seem to get what is the issue here. Your mapping is not removed, only the VMAs are merged together into one larger VMA if they have neighbouring address ranges and compatible protection bits. See vma_merge(). -- Jiri Kosina -
Aug 30, 5:34 pm 2007
Clemens Kolbitsch
Re: Forbid deletion of memory mappings
the thing is that they are not. the kernel chooses to REPLACE my mapping. consider the user-space code: mmap(0xaaaa0000, 0x3000, MAP_FIXED, ...); mmap(0xaaaa1000, 0x4000, MAP_FIXED, ...); here, the second call to mmap will shorten the first mapping to 0x1000 bytes and create one big vma with size 0x5000 bytes. is there a way to tell it that the second mmap MUST fail? -
Aug 30, 5:41 pm 2007
Jiri Kosina
Re: Forbid deletion of memory mappings
Which is exactly in compliance with what POSIX says about MAP_FIXED mmaps - see http://opengroup.org/onlinepubs/007908799/xsh/mmap.html -- Jiri Kosina -
Aug 30, 5:55 pm 2007
Valdis.Kletnieks
Re: Forbid deletion of memory mappings
There's an LSM exit point for mmap, you could perhaps do something there. What are you trying to achieve by forcing the second one to fail?
Aug 30, 5:50 pm 2007
previous daytodaynext day
August 29, 2007August 30, 2007August 31, 2007