linux-kernel mailing list

FromSubjectsort iconDate
Jason Gaston
[PATCH 2.6.23-rc4] i2c-i801: Documentation patch for Int ...
This patch adds the Intel Tolapai SMBus Controller text to i2c-i801 documentation. Signed-off-by:  Jason Gaston <jason.d.gaston@intel.com> --- linux-2.6.23-rc4/Documentation/i2c/busses/i2c-i801.orig 2007-08-30 15:56:39.000000000 -0700 +++ linux-2.6.23-rc4/Documentation/i2c/busses/i2c-i801 2007-08-30 15:57:32.000000000 -0700 @@ -13,7 +13,8 @@ * Intel 631xESB/632xESB (ESB2) * Intel 82801H (ICH8) * Intel ICH9 - Datasheets: Publicly available at the Intel website + * Intel ...
Aug 30, 4:02 pm 2007
Jason Gaston
[PATCH 2.6.23-rc4] i2c-i801: SMBus patch for Intel Tolapai
This updated patch adds the Intel Tolapai LPC and SMBus Controller DID's.  This patch relies on the irq Tolapai patch to pci_ids.h. Signed-off-by:  Jason Gaston <jason.d.gaston@intel.com> --- linux-2.6.23-rc4/drivers/i2c/busses/Kconfig.orig 2007-08-27 18:32:35.000000000 -0700 +++ linux-2.6.23-rc4/drivers/i2c/busses/Kconfig 2007-08-28 16:58:26.000000000 -0700 @@ -156,6 +156,7 @@ ESB2 ICH8 ICH9 + Tolapai This driver can also be built as a module. If so, the ...
Aug 30, 3:48 pm 2007
Jason Gaston
[PATCH 2.6.23-rc4] irq: irq and pci_ids patch for Intel ...
This updated patch adds the Intel Tolapai LPC and SMBus Controller DID's. Signed-off-by:  Jason Gaston <jason.d.gaston@intel.com> --- linux-2.6.23-rc4/arch/i386/pci/irq.c.orig 2007-08-27 18:32:35.000000000 -0700 +++ linux-2.6.23-rc4/arch/i386/pci/irq.c 2007-08-28 16:58:31.000000000 -0700 @@ -550,6 +550,7 @@ case PCI_DEVICE_ID_INTEL_ICH9_3: case PCI_DEVICE_ID_INTEL_ICH9_4: case PCI_DEVICE_ID_INTEL_ICH9_5: + case PCI_DEVICE_ID_INTEL_Tolapai_0: r->name = "PIIX/ICH"; r->get ...
Aug 30, 3:46 pm 2007
Jason Gaston
[PATCH 2.6.23-rc4] ata_piix: IDE mode SATA patch for Int ...
This updated patch adds the Intel Tolapai IDE mode SATA controller DID. Signed-off-by:  Jason Gaston <jason.d.gaston@intel.com> --- linux-2.6.23-rc4/drivers/ata/ata_piix.c.orig 2007-08-27 18:32:35.000000000 -0700 +++ linux-2.6.23-rc4/drivers/ata/ata_piix.c 2007-08-29 17:13:13.000000000 -0700 @@ -130,6 +130,7 @@ ich6m_sata_ahci = 8, ich8_sata_ahci = 9, piix_pata_mwdma = 10, /* PIIX3 MWDMA only */ + tolapai_sata_ahci = 11, /* constants for mapping table */ P0 = 0, /* ...
Aug 30, 3:44 pm 2007
Jason Gaston
[PATCH 2.6.23-rc4] ahci: RAID mode SATA patch for Intel ...
This patch adds the Intel Tolapai RAID controller DID's for SATA support. Signed-off-by:  Jason Gaston <jason.d.gaston@intel.com> --- linux-2.6.23-rc4/drivers/ata/ahci.c.orig 2007-08-27 18:32:35.000000000 -0700 +++ linux-2.6.23-rc4/drivers/ata/ahci.c 2007-08-28 16:58:11.000000000 -0700 @@ -411,6 +411,8 @@ { PCI_VDEVICE(INTEL, 0x292f), board_ahci_pi }, /* ICH9M */ { PCI_VDEVICE(INTEL, 0x294d), board_ahci_pi }, /* ICH9 */ { PCI_VDEVICE(INTEL, 0x294e), board_ahci_pi }, /* ICH9M */ + { ...
Aug 30, 3:41 pm 2007
Clemens Kolbitsch
Copy large memory regions from & to userspace
Hi! Just a short question: What is the correct method of copying large areas of memory from userspace into userspace when running in kernel-mode? According to just about any type of documentation out there something like unsigned long *from = 0x08000000; unsigned long *to = 0x09000000; memcpy(to, from, 0x1000); should be avoided as copy_from_user, put_user, etc. should be used instead... Is there a third set of functions for direct from-userspace-to-userspace copying or is it ...
Aug 30, 3:29 pm 2007
Jesper Juhl
[PATCH] input: Silence 'unused variable' warning in ifor ...
In the iforce driver we currently get this warning drivers/input/joystick/iforce/iforce-packets.c: In function 'iforce_get_id_packet': drivers/input/joystick/iforce/iforce-packets.c:249: warning: unused variable 'status' if CONFIG_JOYSTICK_IFORCE_USB is not defined. The warning is easy to avoid by simply moving the variable inside the only case in the switch that actually use it. Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com> --- diff --git ...
Aug 30, 3:13 pm 2007
Jesper Juhl
Re: [PATCH] input: Silence 'unused variable' warning in ...
On 31/08/2007, Satyam Sharma <satyam@infradead.org> wrote: Here's an updated patch that actually works as intended. In the iforce driver we currently get this warning drivers/input/joystick/iforce/iforce-packets.c: In function 'iforce_get_id_packet': drivers/input/joystick/iforce/iforce-packets.c:249: warning: unused variable 'status' if CONFIG_JOYSTICK_IFORCE_USB is not defined. The warning is easy to avoid by simply moving the variable inside the only case in the switch ...
Aug 30, 3:50 pm 2007
Satyam Sharma
Re: [PATCH] input: Silence 'unused variable' warning in ...
Hi, Hmm, would this not still give a warning when JOYSTICK_IFORCE_USB=y? [ I didn't know mixing code and declarations (not at top of statement block) was accepted style in the kernel ... ] IMHO either you should at least wrap that case inside a {} of its own (so that the int status; is at top of a statement block), or else, preferably, just add "__maybe_unused" to the first declaration that you removed just now. Satyam -
Aug 30, 3:57 pm 2007
Al Boldi
Re: Who wants to maintain KR list for stable releases?
Exactly right. The important part in designing isn't the how-to but rather understanding the concepts involved. Once you have the concepts straight, implementation Agreed. But when I responded to this thread by changing the subject, because I felt it was somewhat OT to tracking, I meant to question the mentality of trying to nullify design suggestions for the mere reason of not submitting a prototype. Now, prototyping is a great way to refine your end-product, but it's a terrible ...
Aug 30, 3:11 pm 2007
Hua Zhong
RE: recent nfs change causes autofs regression
There are two disjoint directories. I am wondering why there would be cache coherency issues in this case? Is this Linus nfs implementation specific or "working" as in "I can mount the directory and do my work". And there has Fine. These are all very nice theories, but I just want to report this regression and hope it won't cause any big problems for any users out there. -
Aug 30, 4:30 pm 2007
Trond Myklebust
Re: recent nfs change causes autofs regression
Which is better than having it fail silently, or giving you a mount with the wrong mount options. If you need to mount the same filesystem with incompatible mount options on the same client, then there is a new mount option "nosharecache", which enables it. The new option is there in order to make it damned clear to sysadmins that this is a dangerous thing to do: mounts which don't share the same superblock also don't share the same data and attribute caches. Any file or directory which ...
Aug 30, 3:37 pm 2007
Hua Zhong
recent nfs change causes autofs regression
I am re-sending this after help from Ian and git-bisect. To me it's a show-stopper: I cannot find an acceptable workaround that I can implement. The problem: upgrading to 2.6.23-rc4 from 2.6.22 causes several autofs mounts to fail silently - they just not appear when they should. I believe it's caused by the NFS change that forces multiple mounts from different directories under the same server side filesystem to have the same mount options by default, otherwise it returns EBUSY. For ...
Aug 30, 2:07 pm 2007
Trond Myklebust
RE: recent nfs change causes autofs regression
How is the NFS client to know that these directories are disjoint, or that no-one will ever create a hard link from one directory to another? To my knowledge, the only way to ensure this is to put them on different disk partitions. I don't know if all Unix systems have this issue, but I have been told That is too narrow a definition: the minimum should be "everyone can mount their directories and do their work". Your particular setup may be safe, but that is why we have overrides: the ...
Aug 30, 4:37 pm 2007
Trond Myklebust
RE: recent nfs change causes autofs regression
"better" as in: "I now have a chance to notice, when my 'read-only Yes. The default values for acregmin, acregmax, acdirmin, acdirmax are not 600. If /a/tools and /a/share are on the same filesystem on the server, then the NFS client should warn you that you are about to do something that may result in cache coherency problems instead of silently allowing it, and then leaving you to debug the coherency issue. If you know what you are doing, then there is an option which allows you Your ...
Aug 30, 4:22 pm 2007
Hua Zhong
RE: recent nfs change causes autofs regression
Every engineer in our organization mounts it too. No problem until now. It's not very conservative to suddenly change default behavior and break autofs mounts. There is not even one kernel message that "_tells_ user why No. I have no other choice as I explained before. Hua -
Aug 30, 4:44 pm 2007
Hua Zhong
RE: recent nfs change causes autofs regression
Well, it depends on how you define "better". In this particular scenario, the maps read as follows: tools -fstype=nfs,udp,rw,intr,nosuid,nodev,rsize=8192,wsize=8192,mountvers=3,nfsve rs=3,actimeo=600 fs1.domain.com:/a/tools share -fstype=nfs,udp,rw,intr,nosuid,nodev,rsize=8192,wsize=8192,mountvers=3,nfsve rs=3 fs1.domain.com:/a/share The only difference is in the actimeo (I don't even know what it means). Is this enough to fail a mount? More importantly, it is a regression. My ...
Aug 30, 3:47 pm 2007
Stefan Foerster
IBM ThinkPad T23: Uhhuh. NMI received for unknown reason ...
Hi all, on my IBM ThinkPad T23 I often get the following messages (together with a beep from the speaker): ------------------- Message from syslogd@stefan2 at Thu Aug 30 22:02:17 2007 ... stefan2 kernel: Uhhuh. NMI received for unknown reason 30 on CPU 0. Message from syslogd@stefan2 at Thu Aug 30 22:02:17 2007 ... stefan2 kernel: Do you have a strange power saving mode enabled? Message from syslogd@stefan2 at Thu Aug 30 22:02:17 2007 ... stefan2 kernel: Dazed and confused, but trying ...
Aug 30, 1:52 pm 2007
Steve French Aug 30, 1:19 pm 2007
Steven Rostedt
[PATCH] Add parenthesis to IRQ vector macros
It is not good taste to have macros with additions that do not have parenthesis's around them. This patch parethesizes the IRQ vector macros for x86_64 arch. Note, this caused me a bit of heart-ache debugging lguest64. Signed-off-by: Steven Rostedt <rostedt@goodmis.org> diff --git a/include/asm-x86_64/hw_irq.h b/include/asm-x86_64/hw_irq.h index 09dfc18..9f00f69 100644 --- a/include/asm-x86_64/hw_irq.h +++ b/include/asm-x86_64/hw_irq.h @@ -40,22 +40,22 @@ /* * Vectors 0x30-0x3f are ...
Aug 30, 1:06 pm 2007
Randy Dunlap
Re: [PATCH] Documentation/00-INDEX notice ecryptfs.txt moved.
Please use the expected (canonical) patch format. See Documentation/SubmittingPatches: 14) The canonical patch format Additional help: http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt http://linux.yyz.us/patch-format.html Thanks. --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** -
Aug 30, 12:04 pm 2007
Rob Landley
[PATCH] Documentation/00-INDEX notice ecryptfs.txt moved.
Signed-off-by: Rob Landley <rob@landley.net> ecryptfs.txt moved into Documentation/filesystems, so move the 00-INDEX entry. --- linux-2.6.23-rc4/Documentation/00-INDEX 2007-08-27 20:32:35.000000000 -0500 +++ linux-new/Documentation/00-INDEX 2007-08-30 14:43:15.000000000 -0500 @@ -134,8 +134,6 @@ - info on Linux Digital Video Broadcast (DVB) subsystem. early-userspace/ - info about initramfs, klibc, and userspace early during boot. -ecryptfs.txt - - docs on eCryptfs: stacked ...
Aug 30, 12:46 pm 2007
Rob Landley
[PATCH] Documentation/arm/00-INDEX add missing entries.
Signed-off-by: Rob Landley <rob@landley.net> Index two unindexed documentation files. --- linux-2.6.23-rc4/Documentation/arm/00-INDEX 2007-08-27 20:32:35.000000000 -0500 +++ linux-new/Documentation/arm/00-INDEX 2007-08-30 14:27:15.000000000 -0500 @@ -20,3 +20,7 @@ - description of the virtual memory layout nwfpe - NWFPE floating point emulator documentation +Porting + - Symbol definitions for porting Linux to a new ARM machine. +Setup + - Kernel initialization parameters on ARM ...
Aug 30, 12:35 pm 2007
Balbir Singh
Re: [-mm PATCH] Memory controller improve user interface (v2)
Typo, the description should be Changelog for version 2 1. Back end tracking is done in bytes, round up values of the limit if the specified value is not a multiple of page size. Display memory.usage and memory.limit in bytes (Dave Hansen, Paul Menage) Change the interface to use bytes instead of pages. Page sizes can vary across platforms and configurations. A new strategy routine has been added to the resource counters infrastructure to format the data as desired. Suggested by ...
Aug 30, 12:00 pm 2007
Balbir Singh
[-mm PATCH] Memory controller improve user interface (v2)
Change the interface to use kilobytes instead of pages. Page sizes can vary across platforms and configurations. A new strategy routine has been added to the resource counters infrastructure to format the data as desired. Suggested by David Rientjes, Andrew Morton and Herbert Poetzl Tested on a UML setup with the config for memory control enabled. Signed-off-by: Balbir Singh <balbir@linux.vnet.ibm.com> --- Documentation/controllers/memory.txt | 22 +++++++++++++- ...
Aug 30, 11:52 am 2007
Eric Van Hensbergen
[PATCH] modify lguest console to support multiple hvc's
From: Eric Van Hensbergen <ericvh@ericvh-desktop.austin.ibm.com> This was a quick modification I did of lguest to be able to support multiple HVC channels for some experiements I was doing. I'm not sure if this is more generally useful, so I'm posting it to the list in case someone else has a need for it. Signed-off-by: Eric Van Hensbergen <ericvh@gmail.com> --- Documentation/lguest/lguest.c | 161 ++++++++++++++++++++++++----------------- drivers/char/hvc_lguest.c | 57 ...
Aug 30, 11:38 am 2007
Jason Lunz
jffs2 deadlock introduced in linux 2.6.22.5
commit 1d8715b388c978b0f1b1bf4812fcee0e73b023d7 was added between 2.6.22.4 and 2.6.22.5 to cure a locking problem, but it seems to have introduced another (worse?) one. With a jffs2 filesystem (on block2mtd) on a 2.6.22.5 kernel, if I do anything that appends to a file with many small writes, I get what looks like a deadlock between the writer and the jffs2 gc thread. For example: # while true; do echo >> /some/file/on/jffs2; done will result in the bash hanging in D state, with these ...
Aug 30, 11:23 am 2007
Bryan O'Sullivan
Re: [PATCH] docs: ramdisk/initrd/initramfs corrections
Acked-by: Bryan O'Sullivan <bos@serpentine.com> -
Aug 30, 12:13 pm 2007
Robert P. J. Day
Re: [PATCH] docs: ramdisk/initrd/initramfs corrections
On Thu, 30 Aug 2007, Randy Dunlap wrote: ... i just the other day submitted a patch to remove that backward compatibility, and the m68k portion of it has already been acked by geert uytterhoeven. rday -- ======================================================================== Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA http://crashcourse.ca ======================================================================== -
Aug 30, 11:28 am 2007
Randy Dunlap
[PATCH] docs: ramdisk/initrd/initramfs corrections
From: Randy Dunlap <randy.dunlap@oracle.com> initrd/initramfs/ramdisk docs: - fix typos/spellos/grammar - clarify RAM disk config location - correct cpio option Cc: Bryan O'Sullivan <bos@serpentine.com> Cc: Rob Landley <rob@landley.net> Cc: Werner Almesberger <werner@almesberger.net> Cc: H. Peter Anvin <hpa@zytor.com> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> --- Documentation/early-userspace/README | 6 +++--- ...
Aug 30, 11:20 am 2007
H. Peter Anvin Aug 30, 4:21 pm 2007
H. Peter Anvin
Re: [PATCH] docs: ramdisk/initrd/initramfs corrections
The same objection applies to this as to the previous one. In that respect, an Ack from a maintainer of an almost unused architecture is meaningless (sorry, Geert.) -hpa -
Aug 30, 3:41 pm 2007
Rob Landley
Re: [PATCH] docs: ramdisk/initrd/initramfs corrections
Could you mention it in feature-removal-schedule.txt? (People check that for warning of upcoming changes that impact existing code. They may not notice something elsewhere after they've got it working...) (Also, sorting feature-removal-schedule.txt by date would be really nice. The sucker's gotten huge...) And while I'm looking at this, is there some other place that entries in this file go once they _have_ been removed, so people can see "oh yeah, that went away in 2.6.23) when ...
Aug 30, 4:36 pm 2007
Randy Dunlap
Re: [PATCH] docs: ramdisk/initrd/initramfs corrections
Peter, what are you objecting to, Rob's comment, Robert's comment, Robert's patch, or my patch? Thanks. --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** -
Aug 30, 4:13 pm 2007
Rob Landley
Re: [PATCH] docs: ramdisk/initrd/initramfs corrections
Acked-by: Rob Landley <rob@landley.net> Rob -- "One of my most productive days was throwing away 1000 lines of code." - Ken Thompson. -
Aug 30, 4:29 pm 2007
Daniel Drake Aug 30, 10:54 am 2007
Jesper Juhl
Re: [PATCH 13/30] net: Don't do pointless kmalloc return ...
Ok, I must admit I didn't check with sparse since it seemed pointless - we usually never cast void pointers to other pointer types, specifically because the C language nicely guarantees that the right thing will happen without the cast. Sometimes we have to cast them to integer types, su sure we need the cast there. But what on earth makes a "zd_addr_t *" so special that we have to explicitly cast a "void *" to that type? I see it's defined as typedef u32 __nocast zd_addr_t; in ...
Aug 30, 1:20 pm 2007
Jesper Juhl
[PATCH] Don't needlessly initialize variable to NULL in ...
Thank you for that link Joe. I'm not sure I agree with the __nocast, but I respect that this is the maintainers choice. But, I still think the first chunk of the patch that removes the initial variable initialization makes sense. Initializing the variable to NULL is pointless since it'll never be used before the kmalloc() call. So here's a revised patch that just gets rid of that little detail. No need to initialize to NULL when variable is never used before it's assigned the ...
Aug 30, 3:30 pm 2007
Joe Perches Aug 30, 3:19 pm 2007
Jesper Juhl
Re: [PATCH] Don't needlessly initialize variable to NULL ...
On 31/08/2007, Randy Dunlap <randy.dunlap@oracle.com> wrote: ... Heh, thanks Randy. All too often patches get missed since I don't happen to include the right magic person to Cc. So I generally take a "better to have one Cc too many than miss one" approach when sending patches - otherwise I just end up resending it several times and eventually have to bother Andrew to move it through -mm. I see the point of people not getting things twice, but too many patches slip through the cracks ...
Aug 30, 4:04 pm 2007
Randy Dunlap
Re: [PATCH] Don't needlessly initialize variable to NULL ...
--- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** -
Aug 30, 3:42 pm 2007
Daniel Drake
Re: [PATCH 13/30] net: Don't do pointless kmalloc return ...
We use it as a safety measure when coding. For example the write register function takes an address and a value. We got one of these the wrong way round once, and had a non-obvious bug. nocast and sparse helps us prevent this. Daniel -
Aug 30, 4:47 pm 2007
Matti Linnanvuori
[Bugme-new] [Bug 8957] New: Exported functions and variables
I thought I had seen that bug. Module init function execution does not seem serialized enough, so the init function of one module seems to be able to be called in parallel with several other modules in turn being loaded, executing their init functions and even becoming live first class citizens. Function sys_init_module in Linux 2.6.22.x and 2.6.23-rc4 kernel/module.c does not hold module_mutex when executing the init functions of the modules. __________________________________ ...
Aug 30, 10:44 am 2007
Jiri Kosina
Re: Forbid deletion of memory mappings
Which is exactly in compliance with what POSIX says about MAP_FIXED mmaps - see http://opengroup.org/onlinepubs/007908799/xsh/mmap.html -- Jiri Kosina -
Aug 30, 2:55 pm 2007
Jiri Kosina
Re: Forbid deletion of memory mappings
Hi Clemens, what do you mean by "overwrites it"? It just probably merges your vma with the newly created one, right? -- Jiri Kosina -
Aug 30, 10:07 am 2007
Valdis.Kletnieks
Re: Forbid deletion of memory mappings
There's an LSM exit point for mmap, you could perhaps do something there. What are you trying to achieve by forcing the second one to fail?
Aug 30, 2:50 pm 2007
Jiri Kosina
Re: Forbid deletion of memory mappings
I don't seem to get what is the issue here. Your mapping is not removed, only the VMAs are merged together into one larger VMA if they have neighbouring address ranges and compatible protection bits. See vma_merge(). -- Jiri Kosina -
Aug 30, 2:34 pm 2007
Clemens Kolbitsch
Re: Forbid deletion of memory mappings
does really noone have an answer for me?? i'm having the hardest time to find a work-around for it. is there no way to tell the kernel, that a certain mapping must not be removed, no matter what (except of course an explicit call to sys_unmap, of course)? -
Aug 30, 2:32 pm 2007
Clemens Kolbitsch
Re: Forbid deletion of memory mappings
the thing is that they are not. the kernel chooses to REPLACE my mapping. consider the user-space code: mmap(0xaaaa0000, 0x3000, MAP_FIXED, ...); mmap(0xaaaa1000, 0x4000, MAP_FIXED, ...); here, the second call to mmap will shorten the first mapping to 0x1000 bytes and create one big vma with size 0x5000 bytes. is there a way to tell it that the second mmap MUST fail? -
Aug 30, 2:41 pm 2007
Clemens Kolbitsch
Re: Forbid deletion of memory mappings
that's exactly the problem... it replaces my mapping with the new one... i.e. it first deletes my mapping and then creates the new one at the same location. i *guess* this all happens in exec.c, lines 1033ff: munmap_back: vma = find_vma_prepare(mm, addr, &prev, &rb_link, &rb_parent); if (vma && vma->vm_start < addr + len) { if (do_munmap(mm, addr, len)) return -ENOMEM; goto munmap_back; } -
Aug 30, 10:09 am 2007
Clemens Kolbitsch
Forbid deletion of memory mappings
Hi everyone! I have a strange problem where I don't even know if there is a solution to it at the moment: I'm working on a new way of doing memory-management and currently I allocate memory mappings (at non-fixed locations) in user-memory (i.e. < TASK_SIZE) in addition to the regular pages mapped for the apps (e.g. heap memory, etc.) It all works perfectly well (creating & deleting the additional mappings), however, when the kernel feels like it needs to allocate a mapping in user-space ...
Aug 30, 9:44 am 2007
Clemens Kolbitsch
Re: Forbid deletion of memory mappings
puh... that is a good question :-) I'm writing my master's thesis on a new model of memory protection and need to have every memory mapping in userspace duplicated. I also have kind of a second PGD/PTD that allows finding this mirrored mapping. However, as the number of original mappings grows, I suddenly have the problem that the kernel tries to allocate a new mapping and picks the address of a mirrored memory page, which it shouldn't. Honestly, I don't understand why it does so, but ...
Aug 30, 3:05 pm 2007
Arjan van de Ven
Re: [Bugme-new] [Bug 8957] New: Exported functions and v ...
On Thu, 30 Aug 2007 09:41:41 -0700 (PDT) have you seen this? module loading is pretty much serialized, so that no 2 modules are being loaded in parallel... -
Aug 30, 9:56 am 2007
Matti Linnanvuori
[Bugme-new] [Bug 8957] New: Exported functions and variables
I thought that the bug might happen when two kernel modules are being loaded. If module A is loaded and its code includes references to functions exported by module B, I thought module A could call those functions before the module_init function of module B has finished. I was not thinking about buggy calls to registering interface functions. I just thought that the kernel should not allow symbols exported by EXPORT_SYMBOLto be visible to other modules before the module_init function is finished. One ...
Aug 30, 9:41 am 2007
Matthew Jacob
Re: FC - NPIV in 2.6.23-rc2
No, if the switch doesn't suport NP-IV, the 24XX f/w will come up in Public Loop mode (FL). -
Aug 30, 9:47 am 2007
Seokmann Ju
Re: FC - NPIV in 2.6.23-rc2
NPIV is a feature to provide multiple path available on one physical port and it has implemented based on the multiport ID (MID) capability on the switch. So, you have to have the switch with MID capable on the configuration to support NPIV, besides the controller. Thank you, Seokmann -
Aug 30, 9:27 am 2007
Duane Grigsby
RE: FC - NPIV in 2.6.23-rc2
-----Original Message----- From: Matthew Jacob [mailto:lydianconcepts@gmail.com] Sent: Thursday, August 30, 2007 9:47 AM To: Seokmann Ju Cc: Abhishek Kane; linux-kernel@vger.kernel.org; Linux Driver; linux-scsi@vger.kernel.org port and it has implemented based on the multiport ID (MID) capability Yes, NPIV is optional, if the switch is NPIV capable then you can create virtual ports, otherwise it works as it does today. NPIV is a standard technology that allows sharing a single physical ...
Aug 30, 4:46 pm 2007
Seokmann Ju
Re: FC - NPIV in 2.6.23-rc2
That is correct. As it should, the F/W with NPIV capability also works on the configuration with non-NPIV switches. Thank you, Seokmann -
Aug 30, 10:25 am 2007
David Howells
[PATCH] MTD: Initialise s_flags in get_sb_mtd_aux()
From: David Howells <dhowells@redhat.com> Initialise s_flags in get_sb_mtd_aux() from the flags parameter. Signed-off-by: David Howells <dhowells@redhat.com> --- drivers/mtd/mtdsuper.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/mtd/mtdsuper.c b/drivers/mtd/mtdsuper.c index aca3319..9b430f2 100644 --- a/drivers/mtd/mtdsuper.c +++ b/drivers/mtd/mtdsuper.c @@ -70,6 +70,8 @@ static int get_sb_mtd_aux(struct file_system_type *fs_type, int flags, ...
Aug 30, 9:21 am 2007
The AmigaLinux A2232 ...
[PATCH] ser_a2232.c bug removed: handles "IRQ request de ...
This patch handles the case in which the request for the vertical blank interrupt could not be granted. Thanks to Nazia Zaman for spotting it. Applies to latest 2.6.x kernels. --- linux/drivers/char/ser_a2232.c.org 2007-08-30 15:41:25.000000000 +0100 +++ linux/drivers/char/ser_a2232.c 2007-08-30 15:46:17.000000000 +0100 @@ -787,7 +787,7 @@ static int __init a2232board_init(void) } - printk("Total: %d A2232 boards initialized.\n", nr_a2232); /* Some status report if no card was ...
Aug 30, 8:13 am 2007
Jeff Layton
[PATCH 3/3] CIFS: ignore mode change if it's just for cl ...
If the ATTR_KILL_S*ID bits are set then any mode change is only for clearing the setuid/setgid bits. For CIFS, skip the mode change and let the server handle it. Signed-off-by: Jeff Layton <jlayton@redhat.com> --- fs/cifs/inode.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/fs/cifs/inode.c b/fs/cifs/inode.c index dd41677..279f3c5 100644 --- a/fs/cifs/inode.c +++ b/fs/cifs/inode.c @@ -1538,6 +1538,11 @@ int cifs_setattr(struct dentry *direntry, struct iattr ...
Aug 30, 8:06 am 2007
Jeff Layton
[PATCH 2/3] NFS: ignore mode change if it's just for cle ...
If the ATTR_KILL_S*ID bits are set then any mode change is only for clearing the setuid/setgid bits. For NFS skip the mode change and let the server handle it. Signed-off-by: Jeff Layton <jlayton@redhat.com> --- fs/nfs/inode.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/fs/nfs/inode.c b/fs/nfs/inode.c index 45633f9..441bd8b 100644 --- a/fs/nfs/inode.c +++ b/fs/nfs/inode.c @@ -327,6 +327,10 @@ nfs_setattr(struct dentry *dentry, struct iattr *attr) ...
Aug 30, 8:06 am 2007
Christoph Hellwig
Re: [PATCH 1/3] VFS: make notify_change pass ATTR_KILL_S ...
This one looks fine to, but you'll probably need an additional patch to ecryptfs so it clears ATTR_MODE before calling notify_change for the lower inode. -
Aug 30, 9:33 am 2007
Peter Staubach
Re: [NFS] [PATCH 1/3] VFS: make notify_change pass ATTR_ ...
If you would, please add some parentheses to show and make explicit what the bindings are. This is: if ((ia_valid & (ATTR_KILL_SUID | ATTR_KILL_SGID)) && (ia_valid & ATTR_MODE)) Thanx... -
Aug 30, 9:03 am 2007
Jeff Layton
[PATCH 1/3] VFS: make notify_change pass ATTR_KILL_S*ID ...
Make notify_change not clear the ATTR_KILL_S*ID bits in the ia_vaid that gets passed to the setattr inode operation. This allows the filesystems to reinterpret whether this mode change is simply intended to clear the setuid/setgid bits. This means that notify_change should never be called with both ATTR_MODE and either of the ATTR_KILL_S*ID bits set, since the filesystem would have no way to know what part of the mode change was intentional. If it is called this way, consider it a ...
Aug 30, 8:06 am 2007
Jeff Layton
[PATCH 0/3] fix setuid/setgid clearing in networked file ...
When an unprivileged process attempts to modify a file that has the setuid or setgid bits set, the VFS will attempt to clear these bits. The VFS will set the ATTR_KILL_SUID or ATTR_KILL_SGID bits in the ia_valid mask, and then call notify_change to clear these bits and set the mode accordingly. With a networked filesystem (NFS and CIFS in particular but likely others), the client machine or process may not have credentials that allow for setting the mode. In some situations, this can lead to ...
Aug 30, 8:06 am 2007
Arjan van de Ven
Re: probable kernel Bug
On Thu, 30 Aug 2007 11:46:50 -0300 any specific reason you're using ndiswrapper rather than the native linux driver for this device? Your oops is all over the ndiswrapper code..... -
Aug 30, 8:21 am 2007
Santiago L Hasenclever
probable kernel Bug
This is a multi-part message in MIME format. --------------070009000803050701050105 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Summary: network driver crashes when setting wireless interface as ahd-ho= c Description: (Excuse my english i'm from argentina and i don't know if there is a mail list in spanish) When i configure the wireless interface with the following command "iwconfig eth1 essid darkz mode ad-hoc key s:clave key on" as ...
Aug 30, 7:46 am 2007
Satyam Sharma Aug 30, 9:51 am 2007
n
Bug? Realtek RTL-8169 Gigabit Ethernet and High Resolut ...
I found a bug when using the Ethernet controller: Realtek Semiconductor Co., Ltd. RTL-8169 Gigabit Ethernet (rev 10) ethernet card and kernel High Resolution Timers (menuconfig -> Processor type and features -> High Resolution Timer Support ) after about 20 kernel compiles i finnaly figured out this option was making the ethernet card slow tested kernels 2.6.22,2.6.22.5, 2.6.23-rc4 (running now) the cpu is the pc is a p3 667 mhz so its cpu limited i guess and maxes at 400mbit~. (without ...
Aug 30, 7:44 am 2007
Jerome Haltom
ICH8 libata SATA periodic drive failure
I have two systems exhibiting a similar problem, even after swapping out hard drives. Both systems have Intel ICH8 controllers. One is a server class board with a Xeon, the other is a desktop class board with a Core Duo. Both are Intel brand boards. The server box is unable to use a drive in it's 4th, 5th or 6th SATA port. The drive appears fine, and works fine for a few minutes, but eventually starts spitting out errors: [6494068.025887] ata6: SATA link up 1.5 Gbps (SStatus 113 SControl ...
Aug 30, 7:29 am 2007
Robert Hancock
Re: [PATCH] Override 80-wire cable detection for Toshiba ...
This is normally only the case on a laptop, where the cable is essentially just a tiny stub between the motherboard and the drive. I suspect this is something that the system manufacturer has to validate works properly, more than any hard and fast limit. For a normal desktop PC, it would be far better to just use an 80-wire cable. -- Robert Hancock Saskatoon, SK, Canada To email, remove "nospam" from hancockr@nospamshaw.ca Home Page: http://www.roberthancock.com/ -
Aug 30, 7:29 am 2007
Christian Ehrhardt
New x886-Setup code breaks HVM-XEN boot
Hi, I am trying to boot a current 2.6 kernel as a guest under XEN in HVM mode. With linux-2.6.22.(5) as the guest this works fine but current git kernels fail very early in the boot process. The XEN host is a debian kernel with XEN enabled (2.6.18-4-xen-686). The XEN guest is a vanilla kernel from kernel org booting with LILO 22.6.1 in HVM mode. I bisected the problem and the bisection points at this commit: | # bad: [4fd06960f120e02e9abc802a09f9511c400042a5] Use the new x86 setup code ...
Aug 30, 7:15 am 2007
Jeremy Fitzhardinge
Re: New x886-Setup code breaks HVM-XEN boot
Are there any messages on the xen console ("xm dmesg")? Or logs ("xm log")? What version of Xen are you using? What does your domain config file look like? J -
Aug 30, 12:04 pm 2007
H. Peter Anvin
Re: New x886-Setup code breaks HVM-XEN boot
All of this point to a bug in the Xen emulation host. You're not saying if you're on an Intel or AMD host, but on Intel, hardware virtualization doesn't actually kick in until you're in protected mode with all segments configured properly. This means all of pmjump.S runs in an interpreter. A bug in that interpreter would cause what you observe. -hpa -
Aug 30, 7:49 am 2007
Nicolas Ferre
[PATCH] bug in AT91 MCI suspend routines
From: Anti Sullin <anti.sullin@artecdesign.ee> This patch fixes a bug in AT91 mmc host driver, that enables the wakeup from suspend on card detection pin even if the card detect pin is not available (==0). If not card detection pin is defined, IRQ0 == FIQ gets enabled and if some activity is present on that pin, the system gets a FIQ request, that causes a crash. Signed-off-by: Anti Sullin <anti.sullin@artecdesign.ee> Signed-off-by: Nicolas Ferre ...
Aug 30, 7:15 am 2007
J. Bruce Fields
Re: NFS4 authentification / fsuid
Well, rpcsec_gss isn't inherently password based, and you can authenticate in some way that doesn't actually give away your password And in theory a kernel could provide *some* guarantees against root, right? (Is there some reason a unix-like kernel must provide such things as /dev/kmem?) --b. -
Aug 30, 2:44 pm 2007
Trond Myklebust
Re: NFS4 authentification / fsuid
With CIFS or other password based protocols (including RPCSEC_GSS) all the root user needs in order to steal your identity is to grab a copy of your password or a credential. It is not quite as trivial to do as changing uid, but it is hardly rocket science if the compromised machine What I'm saying is that the superuser can pretty much do whatever it takes to grab either your kerberos password (e.g. install a keyboard listener), a stored credential (read the contents of your kerberos on-disk ...
Aug 30, 8:04 am 2007
Trond Myklebust
Re: NFS4 authentification / fsuid
BTW: even when this task is done, a creative root can still find ways to subvert the security (he can read /dev/mem, replace the kernel with a compromised one, ....). The bottom line is that if you can't trust root, don't even log in. Trond -
Aug 30, 7:32 am 2007
Jan Engelhardt
NFS4 authentification / fsuid
Hi, with NFS3, there is this 'root hole', i.e. any person who has a root account (perhaps by use of a laptop) can mount an export (let's say this export had the "root_squash" option), and still have a look at the user files, because he can locally setuid() into another user. So I was looking for alternatives. CIFS is my favorite candidate, but it has a few issues right now. So does sshfs and about everything I have come across. Since I remember NFS4 can use KRB5 authentification, my ...
Aug 30, 7:12 am 2007
Trond Myklebust
Re: NFS4 authentification / fsuid
NFSv3 should work fine with krb5 too, but that won't solve your problem with setuid: kerberos saves the TGT in a file on /tmp, so root can still suid and grab your cred (and the same goes for CIFS). We've got people working on fixing this problem using David Howells' keyrings, but it will probably be a while until we've solved all the upcall issues, and it will probably take even longer to push the kerberos changes back to the official MIT etc distros. Cheers Trond -
Aug 30, 7:29 am 2007
J. Bruce Fields
Re: NFS4 authentification / fsuid
The server will run with an fsuid equal to the user that authenticated, you're correct. So if you require krb5 access on an export, then nfs access to a file on the export should be permitted only on rpc's that are authenticated using credentials of a user with permission to access the file. Trond's pointing out that when you give the client your krb5 credentials you're trusting it to do only what you tell it to with them. You have to trust the client's kernel at the very least, and also ...
Aug 30, 8:12 am 2007
Jan Engelhardt
Re: NFS4 authentification / fsuid
Hm? I do not see this problem with CIFS. The user may have local root, but on the server, he only has his non-root account on the server, and as such, can only operate on the server using this non-root fsuid. Did I miss something? (Especially the /dev/mem thing Jan -- -
Aug 30, 7:42 am 2007
Xu Yang
parse_tag_ramdisk
Hi guys, I found that in the function parse_tag_ramdisk , the setup_ramdisk is called. is it true that in the setup_ramdisk the location ot the initrd is specified? it seems that in my case the parse_tag_ramdisk is never accessed. what might cause this? in the parse_tag_ramdisk the tag should be specified, where to specify the "tag" and how? thanks your answer is appreciated. regards, yang -
Aug 30, 7:07 am 2007
Uli Luckas
Re: parse_tag_ramdisk
If you don't know where the list is created, how do you now that it contains a ramdisk tag? There is a chance, that the kernel does not even get a ram disk tag at all. This would also explain, why it is not parsed ;-) The tag list is supplied by your bootloader. How the bootloader creates the list and how to change the order depends on your bootloader. You probably have to read (and patch) it's source code. regards, Uli -- ------- ROAD ...the handyPC Company - - - ) ) ) Uli ...
Aug 30, 9:46 am 2007
Uli Luckas
Re: parse_tag_ramdisk
Hi Xu, I didn't get down to completely debugging this problem. But for no obvious reason, parsing seems to ends after it hits a command line tag. Try putting the command line tag last in the tag list and see if that helps. Regards Uli -- ------- ROAD ...the handyPC Company - - - ) ) ) Uli Luckas Software Development ROAD GmbH Bennigsenstr. 14 | 12159 Berlin | Germany fon: +49 (30) 230069 - 64 | fax: +49 (30) 230069 - 69 url: www.road.de Amtsgericht Charlottenburg: HRB ...
Aug 30, 9:06 am 2007
Xu Yang
Re: parse_tag_ramdisk
Hi Uli, thanks for your reply. just have a question, where is the tag list, how can i modify this? regards, yang -
Aug 30, 9:10 am 2007
Jean Delvare
Re: i2c transfers during interrupt context
Bonjour Francis ;) Non. Tu n'as pas le droit de dormir dans un gestionnaire d'interruption, et la majorité des pilotes I2C dorment pendant les transferts. Si tu as besoin de faire ce genre de chose il faut typiquement passer par une workqueue. -- Jean Delvare -
Aug 30, 8:32 am 2007
Francis Moreau
i2c transfers during interrupt context
Hello, I have a very simple question about i2c transfers. I'm wondering if I'm allowed to initiate some very short i2c transfers in an interrupt handler. Thanks for your answers. -- Francis -- Francis -
Aug 30, 6:55 am 2007
Jean Delvare
Re: i2c transfers during interrupt context
Oops, sorry for replying in French, I completely missed the fact that the original post was on LKML and not private. -- Jean Delvare -
Aug 30, 1:47 pm 2007
Jiri Kosina
Re: [PATCH] i386 and x86_64: randomize brk()
Andrew, do you still strongly oppose to having ARCH_HAS_RANDOMIZE_BRK macro instead please? Thanks, -- Jiri Kosina SUSE Labs -
Aug 30, 8:10 am 2007
Mike Frysinger
Re: [PATCH] i386 and x86_64: randomize brk()
Blackfin too please :) i think v850 also falls into this category, but i'm not terribly familiar with it ... -mike -
Aug 30, 7:26 am 2007
Franck Bui-Huu
Re: [PATCH] i386 and x86_64: randomize brk()
you might want to use a weak function instead ? void __weak arch_randomize_brk(void) { /* nada by default */ } and overload it only for x86 architectures by now. BTW, how about minimize the arch specific code by slighly changing its prototype ? unsigned long arch_randomize_brk(struct mm_struct *mm) { unsigned long range_end = mm->brk + 0x02000000; return randomize_range(mm->brk, range_end, 0) ? : mm->brk; } Franck -
Aug 30, 8:33 am 2007
Jiri Kosina
[PATCH] i386 and x86_64: randomize brk()
[resending, as discussed last week, thanks] From: Jiri Kosina <jkosina@suse.cz> i386 and x86_64: randomize brk() This patch randomizes the location of the heap (brk) for i386 and x86_64. The range is randomized in the range starting at current brk location up to 0x02000000 offset for both architectures. This, together with pie-executable-randomization.patch and pie-executable-randomization-fix.patch, should make the address space randomization on i386 and x86_64 ...
Aug 30, 6:47 am 2007
Mike Frysinger
Re: [PATCH] i386 and x86_64: randomize brk()
does it really make sense to stick stubs into no-mmu ports which cannot utilize the ELF binfmt ? -mike -
Aug 30, 7:01 am 2007
Jiri Kosina
Re: [PATCH] i386 and x86_64: randomize brk()
Good point, thanks. I have removed the stubs for h8300 and m68knommu. From: Jiri Kosina <jkosina@suse.cz> i386 and x86_64: randomize brk() This patch randomizes the location of the heap (brk) for i386 and x86_64. The range is randomized in the range starting at current brk location up to 0x02000000 offset for both architectures. This, together with pie-executable-randomization.patch and pie-executable-randomization-fix.patch, should make the address space randomization on i386 and ...
Aug 30, 7:21 am 2007
Freddy Spierenburg
Re: Average number of instructions per line of kernel code
Hi all, I may completely miss out on this one, but what's the point in knowing? --=20 $ cat ~/.signature Freddy Spierenburg <freddy@dusktilldawn.nl> http://freddy.snarl.nl/ GnuPG: 0x7941D1E1=3DC948 5851 26D2 FA5C 39F1 E588 6F17 FD5D 7941 D1E1 $ # Please read http://www.ietf.org/rfc/rfc2015.txt before complain!
Aug 30, 12:56 pm 2007
Mohamed Bamakhrama
Re: Average number of instructions per line of kernel code
Hi, I agree with you but is there any way to include ALL the drivers in the kernel tree in building the image? Otherwise, I will be counting un-used lines. -- Mohamed -
Aug 30, 6:48 am 2007
J. Scott Kasten
Re: Average number of instructions per line of kernel code
Here's a quick answer, not the best, but quick. I took a user space flash memory driver I'm doing at work and compiled it on my R5000 at home using gcc 4.1 and the MIPS3 abi, stopping with a .o file. I also ran the source through cpp and a couple of grep passes to strip out junk that wasn't really code. This driver may be somewhat typical of what you would run into as it has quite a few inline functions and such. The driver.o was about 23000 bytes. Forgetting about the ...
Aug 30, 9:29 am 2007
Jan Engelhardt
Re: Average number of instructions per line of kernel code
objcopy -j .text input.o output.o objcopy -O binary output.o output2.o Then you can objdump -S output.o and count. output2.o has the ELF header stripped, so provides the raw size, but at the cost of not being able to run objdump. If you know that every instruction is fixed size, then of course output2.o is easy. Jan -- -
Aug 30, 12:49 pm 2007
Jesper Juhl
Re: Average number of instructions per line of kernel code
make allyesconfig make -- Jesper Juhl <jesper.juhl@gmail.com> Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html -
Aug 30, 6:54 am 2007
Mohamed Bamakhrama
Average number of instructions per line of kernel code
Hi all, I have a question regarding the average number of assembly instructions per line of kernel code. I know that this is a difficult question since it depends on many factors such as the instruction set architecture, compiler used, optimizations used, type of code, coding style, etc... I would like to know a rough estimate for such a quantity for the kernel 2.4/2.6 code running on MIPS32 architecture. My estimate is between 5-10 instructions. I googled for such a thing but couldn't find any ...
Aug 30, 6:00 am 2007
Jesper Juhl
Re: Average number of instructions per line of kernel code
Why don't you simply count the number of non-blank non-comment lines in the source files that you are building, build the kernel and then count the number of instructions in the resulting binary ? -- Jesper Juhl <jesper.juhl@gmail.com> Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html -
Aug 30, 6:31 am 2007
Alan Cox
Re: hda: set_drive_speed_status: status=0x51 { DriveRead ...
Nothing there about DMA support. The data sheet says the media can only do 4.1MB/second which is consistent with only needing PIO2 (actually its far slower than PIO2) -
Aug 30, 4:31 pm 2007
John Sigler
Re: hda: set_drive_speed_status: status=0x51 { DriveRead ...
According to my supplier, herre is the data sheet for the DOMs: http://www.pqimemory.com/documents/domdata.pdf PIO mode 2 is mentioned. Even DMA seems to be supported. Or am I mistaken? Could there be a bug in my south bridge? Regards. -
Aug 30, 8:10 am 2007
John Sigler
Re: hda: set_drive_speed_status: status=0x51 { DriveRead ...
I took drivers/ide/pci/via82cxxx.c and sprinkled ENTER/EXIT printk's. http://lxr.linux.no/source/drivers/ide/pci/via82cxxx.c via82cxxx_tune_drive() and via82cxxx_ide_dma_check() both call via_set_drive() which calls ide_config_drive_speed(). http://lxr.linux.no/source/drivers/ide/ide-iops.c#L769 if (error) { (void) ide_dump_status(drive, "set_drive_speed_status", stat); printk(KERN_INFO "EXIT %s error\n", __func__); return error; } Does someone know why ...
Aug 30, 5:30 am 2007
Sami Farin
kernel 2.6.22: what IS the VM doing?
Using SMP kernel 2.6.22.6pre-CFS-v20.5 on Pentium D (IA-32). I think this bug (or whatever you want to call it) got triggered when you first allocate several megabytes of memory in a kernel module and then free them, and then run e.g. X and when memory gets tight, you end up with this situation... Top 2 /proc/vmstat Biggest Winners: pgrefill_normal:49900/second pgrefill_high:20810/second $ vmstat 1 procs -----------memory---------- ---swap-- -----io---- --system-- -----cpu------ r b ...
Aug 30, 4:54 am 2007
Harsha
ethernet driver: hard_start_xmit
Hi, I have written a network device driver (Linux kernel: 2.6.20.1) on ARM based target board. I have implemented ether_tx, which is called whenever hard_start_xmit is called. -------------------------------------- [ PINGing from BOARD TO OTHER HOST ] The network driver is working. I am able to ping to other hosts and i am able to get the reply without any problem Q1. For large packet size say (2048, 4096) after sometime ping exits saying "sendto: buffer space ...
Aug 30, 4:24 am 2007
n
limiting to UDMA/33 instead of UDMA/100 - pata_pdc202xx_ ...
hello, with kernel 2.6.22.5 using the new pata_pdc202xx_old driver it doesn detect the cable right on this seagate drive (i tried switching ports / cables ...etc) it detects the maxtor drive fine no matter what port its on, the seagate doesnt detect correctly on either port ata1.00: ATA-6: ST3120026A, 3.06, max UDMA/100 ata1.00: 234441648 sectors, multi 16: LBA48 ata1.00: limited to UDMA/33 due to 40-wire cable ata1.00: configured for UDMA/33 ata2.00: ATA-7: Maxtor 6B200R0, max ...
Aug 30, 4:11 am 2007
andre
[KJ][patch 3/3] VIDC20: use abs() from kernel.h instead ...
From: Andre Haupt <andre@finow14.de> Signed-off-by: Andre Haupt <andre@finow14.de> --- Index: linus/sound/oss/vidc.c =================================================================== --- linus.orig/sound/oss/vidc.c 2007-08-30 11:57:13.000000000 +0200 +++ linus/sound/oss/vidc.c 2007-08-30 11:57:53.000000000 +0200 @@ -185,8 +185,6 @@ static unsigned int vidc_audio_set_forma return vidc_audio_format; } -#define my_abs(i) ((i)<0 ? -(i) : (i)) - static int vidc_audio_set_speed(int dev, ...
Aug 30, 3:40 am 2007
Andre Haupt
Re: [KJ][patch 3/3] VIDC20: use abs() from kernel.h inst ...
hmmh, not sure about this ... Russell? regards, Andre -
Aug 30, 4:50 am 2007
Matthew Wilcox
Re: [KJ][patch 3/3] VIDC20: use abs() from kernel.h inst ...
Nothing to do with the patch, but is this really correct? Surely it should be diff_ext = abs(rate_ext-rate) ? -- Intel are signing my paycheques ... these opinions are still mine "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." -
Aug 30, 4:17 am 2007
Russell King
Re: [KJ][patch 3/3] VIDC20: use abs() from kernel.h inst ...
No idea. The support for external clocking came from someone else (I was never able to work it out myself). I can only assume that the code as it stands does work. So let's remain bug-compatible until there's a proven problem. -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: -
Aug 30, 5:22 am 2007
andre
[KJ][patch 2/3] CIFS SMB: use abs() from kernel.h where ...
From: Andre Haupt <andre@finow14.de> Signed-off-by: Andre Haupt <andre@finow14.de> --- Index: linus/fs/cifs/cifssmb.c =================================================================== --- linus.orig/fs/cifs/cifssmb.c 2007-08-30 11:43:20.000000000 +0200 +++ linus/fs/cifs/cifssmb.c 2007-08-30 11:44:58.000000000 +0200 @@ -513,7 +513,7 @@ CIFSSMBNegotiate(unsigned int xid, struc (int)ts.tv_sec, (int)utc.tv_sec, (int)(utc.tv_sec - ts.tv_sec))); val = (int)(utc.tv_sec - ...
Aug 30, 3:37 am 2007
andre
[KJ][patch 1/3] IDT77252: use abs() from kernel.h where ...
From: Andre Haupt <andre@finow14.de> Signed-off-by: Andre Haupt <andre@finow14.de> --- Index: linus/drivers/atm/idt77252.c =================================================================== --- linus.orig/drivers/atm/idt77252.c 2007-08-30 11:33:22.000000000 +0200 +++ linus/drivers/atm/idt77252.c 2007-08-30 11:37:00.000000000 +0200 @@ -2092,7 +2092,7 @@ idt77252_rate_logindex(struct idt77252_d { u16 afp; - afp = idt77252_int_to_atmfp(pcr < 0 ? -pcr : pcr); + afp = ...
Aug 30, 3:36 am 2007
andre
[KJ][patch 0/3] use abs() from kernel.h where appropriate
This small series of quite trivial patches converts a own definition of the abs macro to the one from kernel.h and replaces some inline calculations of abs with the macro. -- -
Aug 30, 3:35 am 2007
Martin Knoblauch
RE: regression of autofs for current git?
Likely. That is the one that will break the user-space automounter as well (and keeps me from .23). I don't care very much about what the default is, but it would be great if the new behaviour could be globally changed at run- (or boot-) time. It will be some time until the new mount option makes it into the distros. Cheers Martin PS: Sorry, but I likely killed the CC list ------------------------------------------------------ Martin Knoblauch email: k n o b i AT knobisoft DOT ...
Aug 30, 2:49 am 2007
Takashi Iwai
Re: [PATCH] fix ALSA compilation on Sparc32
At Thu, 30 Aug 2007 11:26:04 +0200, Actually, the fix has been in ALSA tree (found in git-alsa.patch in mm tree) since long time ago, but it was never pushed. Jaroslav, could you push the fixes please...? thanks, Takashi -
Aug 30, 4:50 am 2007
Alan Cox
Re: [PATCH] fix ALSA compilation on Sparc32
On Thu, 30 Aug 2007 11:26:04 +0200 It would probably look a lot cleaner if you either provided dummy dma_alloc_coherent/free coherent inlines for SPARC32, fixed it (if sparc32 can do coherent DMA) or if you must ifdef it provide dummy functions in the memalloc code so its a single ifdef -
Aug 30, 3:09 am 2007
Markus Dahms
[PATCH] fix ALSA compilation on Sparc32
The dma_alloc_coherent and dma_free_coherent function seem to be not available on sparc(32) architecture. It is not used by SBus sound drivers, so it's disabled via #ifndef for CONFIG_SPARC32. Signed-off-by: Markus Dahms <mad@automagically.de> --- It is tested on a SparcStation 5 with the cs4231 driver. The ALSA list should have been CCed, but as it is subscriber-only I skipped it. --- linux-2.6/sound/core/memalloc.c 2007-08-30 10:59:50.000000000 +0200 +++ ...
Aug 30, 2:26 am 2007
Takashi Iwai
Re: [PATCH] fix ALSA compilation on Sparc32
At Thu, 30 Aug 2007 11:09:39 +0100, It's been indeed inline on 2.6.22 or ealier in include/asm-generic/dma-mapping.h, but it's changed to extern without defining functions. I don't think it's a good idea to have function declarations even though we surely know that there are no real function definitions... Takashi -
Aug 30, 3:52 am 2007
Maarten Maathuis
[2.6.22.1-rt4] very strange oops in the kernel, which ma ...
Can anyone make sense of this? I have not encountered something like this, nor do i know what this trace means. Please CC me if you reply. Sincerely, Maarten Maathuis. log snippet: Aug 29 21:15:15 localhost Unable to handle kernel paging request at ffff81003a2c6518 RIP: Aug 29 21:15:15 localhost [<ffff81003a2c6518>] Aug 29 21:15:15 localhost PGD 8063 PUD 9063 PMD 800000003a2001e3 PTE cb7794f74fd27497 Aug 29 21:15:15 localhost Oops: 0011 [1] PREEMPT Aug 29 21:15:15 localhost CPU ...
Aug 30, 1:40 am 2007
Michal Schmidt
Re: [PATCH 2.6.21] Return available first timeslice to t ...
I don't see the point of sending patches for old Linux versions such as 2.6.21, unless it's something applicable to the -stable tree. There's no kabi. Michal -
Aug 30, 1:37 am 2007
Peter Zijlstra
Re: [PATCH 2.6.21] Return available first timeslice to t ...
The older trees might want to have this, perhaps the .16 by Adrian, True. -
Aug 30, 2:14 am 2007
Oleg Nesterov
Re: [PATCH 2.6.21] Return available first timeslice to t ...
Ah, good, sorry for noise then. In that case I don't think it makes sense to move sched_exit() to do_exit(), of course. This doesn't look suitable for the -stable tree. Oleg. -
Aug 30, 3:09 am 2007
Pavel Emelyanov
Re: [PATCH 2.6.21] Return available first timeslice to t ...
Store the struct pid reference itself. In any case you make the find_get_pid() later to obtain the struct pid itself. This -
Aug 30, 2:48 am 2007
Peter Zijlstra
Re: [PATCH 2.6.21] Return available first timeslice to t ...
might as well make that pid_t, or maybe even a struct pid* and keep a Other than that it looks good, pretty much what I suggested :-) -
Aug 30, 2:10 am 2007
Peter Zijlstra
Re: [PATCH 2.6.21] Return available first timeslice to t ...
This is not intended as re-introduction of the feature, this stems from fixing this issue in older (read distro) kernels. -
Aug 30, 2:56 am 2007
Vitaly Mayatskikh
[PATCH 2.6.21] Return available first timeslice to the c ...
Short-living process returns its timeslice to the parent, this affects process that creates a lot of such short-living threads, because its not a parent for new threads. Patch fixes this issue and doesn't break kabi as does the patch from reporter: http://lkml.org/lkml/2007/4/7/21 An example and script for systemtap were modified a bit. Patch was tested on 2.6.21 with results: Pass 1: parsed user script and 54 library script(s) in 330usr/10sys/340real ms. Pass 2: analyzed script: 3 probe(s), 10 ...
Aug 30, 12:50 am 2007
Oleg Nesterov
Re: [PATCH 2.6.21] Return available first timeslice to t ...
I agree, "struct pid*" is better, because 1. we don't need a costly find_pid() in sched_exit() sched_exit() was removed in 2.6.23-rc. If you are going to re-introduce this logic, please don't do sched_exit() from release_task(). It was done this way just because we can't access ->parent after release_task(). But release_task() is called either too early, or too late for timeslice accounting, depending on ->exit_signal == -1. I'd suggest to do this in do_exit(), before the last ...
Aug 30, 2:49 am 2007
Andrew Morton
Re: Add ACCUSYS RAID driver for Linux i386/x86-64
I personally am unlikely to make the time to test a specific HBA driver. But perhaps James or one of the other scsi developers (or any developer at all) might like to volunteer to help out with testing, in which case yes, please do send out a card or two. First up, please become familar with the way in which we handle code patches. I'd suggest that you subscribe to the linux-kernel or linux-scsi mailing lists for a while, watch how other people prepare and present their ...
Aug 29, 11:58 pm 2007
NeilBrown
[PATCH] md: Fix some bugs with growing raid5/raid6 arrays.
The recent changed to raid5 to allow offload of parity calculation etc introduced some bugs in the code for growing (i.e. adding a disk to) raid5 and raid6. This fixes them Acked-by: Dan Williams <dan.j.williams@intel.com> Signed-off-by: Neil Brown <neilb@suse.de> --- This is against 2.6.23-rc4. It applies to current -mm with quite a bit of fuzz... Thanks, NeilBrown ### Diffstat output ./drivers/md/raid5.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 ...
Aug 29, 11:05 pm 2007
Dmitry Torokhov
[git pull] Input updates for 2.6.23-rc4
Hi Linus, Please consider pulling from: git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus or master.kernel.org:/pub/scm/linux/kernel/git/dtor/input.git for-linus to receive updates to the input subsystem. Changelog: --------- Adrian Bunk (1): Input: psmouse - make dummy touchkit_ps2_detect() static Andrew Morton (1): Input: iforce - fix 'unused variable' warning Fernando Luis Vázquez Cao (1): Input: i8042 - fix retrun value of ...
Aug 29, 10:06 pm 2007
Valdis.Kletnieks
Re: Designers and Builders (was: Who wants to maintain K ...
The problem is not builders, or designers - this list has plenty of both. What Adrian is talking about are the people who go to designers and say "Build me something blue, with a design that doesn't work with the VFS".
Aug 30, 7:31 am 2007
Al Boldi
Designers and Builders (was: Who wants to maintain KR li ...
There are designers, and there are builders. Can you tell me who is more important? Thanks! -- Al -
Aug 29, 9:31 pm 2007
Alan Cox
Re: Designers and Builders (was: Who wants to maintain K ...
And the real test of whether someone is a good engineer or a dodgy consultant then follows. The engineer says "no" the consultant says "it'll cost ya" ;) Humour aside don;t knock the people who have the ideas - in amongst all the people wanting something that is insane are aluable pieces of information if you can ever work them out - What they actually *want* to be able to do, and sometimes ideas that are ones people used to the technology wouldn't have - most are silly but just occasionally ...
Aug 30, 4:25 pm 2007
Al Boldi
Re: Designers and Builders (was: Who wants to maintain K ...
I might agree with you on this wrt hacking around the kernel, but when it comes to introducing new subsystems, then we have a two fold situation: 1. Designing the internals of the new subsystem 2. Interfacing it with the rest of the kernel Part 1 is completely independent of the implementation, it's part 2 that needs intricate implementation knowledge. We recently had an example of this: kexec based hibernation So, what's wrong with tapping into people's design suggestions, and ...
Aug 30, 6:54 am 2007
Adrian Bunk
Re: Designers and Builders (was: Who wants to maintain K ...
That's a perfect approach that works NOT. Your subsystem needs to interact with the VFS or the block layer or whatever else parts of the kernel. If you had ever written kernel code you would have known that your People soon realize that you are making a fool of yourself when your suggestions show that you don't have a clue what you are talking about. cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need ...
Aug 30, 7:17 am 2007
Al Boldi
Re: Designers and Builders (was: Who wants to maintain K ...
I really didn't expect this kind of a response, but I guess when somebody runs out of arguments, then that's probably one of the responses to expect. Really sad. Thanks anyway! -- Al -
Aug 30, 7:50 am 2007
Adrian Bunk
Re: Designers and Builders (was: Who wants to maintain K ...
That's a distinction that doesn't exist in practice: Designing kernel features requires good knowledge of the area of the kernel that should be changed. IOW: If you don't have the skills to implement it yourself you don't cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed -
Aug 30, 12:32 am 2007
Alan Cox
Re: [PATCH] Override 80-wire cable detection for Toshiba ...
For most users the goal should be to automate behaviour. It should just work. -
Aug 30, 3:01 am 2007
Lennart Sorensen
Re: [PATCH] Override 80-wire cable detection for Toshiba ...
Makes you wonder why the mainboard doesn't just pretend to be an 80 wire cable if that is what it is compatible with. Seems like a design flaw in the laptop to not do so. -- Len Sorensen -
Aug 30, 12:47 pm 2007
Jan Engelhardt
Re: [PATCH] Override 80-wire cable detection for Toshiba ...
Or lazyness on behalf the vendor. You know, some even don't fix their DSDT... Jan -- -
Aug 30, 12:52 pm 2007
Al Boldi
Re: [PATCH] Override 80-wire cable detection for Toshiba ...
What's the max length of a 40wire cable to sustain 80wire cable characteristics? Thanks! -- Al -
Aug 30, 6:54 am 2007
Alan Cox
Re: [PATCH] Override 80-wire cable detection for Toshiba ...
Depends on the materials and connector. The required electrical characteristics for any cable are in the spec, and if you want to know more you'll need to know a lot more than I do about transmission line theory! -
Aug 30, 4:22 pm 2007
Al Boldi
Re: [PATCH] Override 80-wire cable detection for Toshiba ...
Wow! I have been running 80wire cable detection override on 40wire cables for quite some time without any problem, but I never thought it to be legal if the 40wire cable length is short enough. How short does it have to be, and can't we have a kernel bootparm to override the cable detection? Thanks! -- Al -
Aug 29, 9:31 pm 2007
Jan Engelhardt
Re: [PATCH] Override 80-wire cable detection for Toshiba ...
Hard to tell, since some (most?) laptops have sort of a backplane and there might be no real cable you could see because it's all mainboard wire paths already. Jan -- -
Aug 30, 12:38 pm 2007
Jordan Crouse
Re: ALSA: cs5535audio: drop unused bus master stuff
-- Jordan Crouse Systems Software Development Engineer Advanced Micro Devices, Inc. -
Aug 30, 7:45 am 2007
Andres Salomon
[PATCH 5/5] ALSA: cs5535audio: drop unused bus master stuff
We really only care about the first two bus masters (playback and capture). There's no need to have unused BM code lying around, so let's get rid of it. If for some reason we trigger an IRQ for some BM that we're not using.. well, that warrants spitting out an error message (imo). Signed-off-by: Andres Salomon <dilinger@debian.org> --- sound/pci/cs5535audio/cs5535audio.c | 24 +++--------------------- sound/pci/cs5535audio/cs5535audio.h | 31 +------------------------------ 2 files ...
Aug 29, 8:31 pm 2007
Jordan Crouse
Re: ALSA: cs5535audio: fix ACC_BM[x]_CMD register handling
-- Jordan Crouse Systems Software Development Engineer Advanced Micro Devices, Inc. -
Aug 30, 7:45 am 2007
Andres Salomon
[PATCH 4/5] ALSA: cs5535audio: fix ACC_BM[x]_CMD registe ...
ACcording to 6.3.2.7 of the cs5535/cs5536 data sheets, the ACC_BM[x]_CMD registers are only 8 bits wide. This driver treats them as 32 bits wide, and also has bits in the wrong place. Simple fix to the definitions. Signed-off-by: Andres Salomon <dilinger@debian.org> --- sound/pci/cs5535audio/cs5535audio.h | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/sound/pci/cs5535audio/cs5535audio.h b/sound/pci/cs5535audio/cs5535audio.h index c7a2044..516219a ...
Aug 29, 8:30 pm 2007
Andres Salomon
[PATCH 3/5] ALSA: cs5535audio: update PCI device handlin ...
Save the PCI state before disabling the device, and add some error checking. Signed-off-by: Andres Salomon <dilinger@debian.org> --- sound/pci/cs5535audio/cs5535audio_pm.c | 12 ++++++++++-- 1 files changed, 10 insertions(+), 2 deletions(-) diff --git a/sound/pci/cs5535audio/cs5535audio_pm.c b/sound/pci/cs5535audio/cs5535audio_pm.c index 9a4e84a..838708f 100644 --- a/sound/pci/cs5535audio/cs5535audio_pm.c +++ b/sound/pci/cs5535audio/cs5535audio_pm.c @@ -74,8 +74,11 @@ int ...
Aug 29, 8:30 pm 2007
Jordan Crouse
Re: ALSA: cs5535audio: update PCI device handling in sus ...
-- Jordan Crouse Systems Software Development Engineer Advanced Micro Devices, Inc. -
Aug 30, 7:44 am 2007
Andres Salomon
[PATCH 2/5] ALSA: cs5535audio: fix PRD register save/res ...
In the suspend path, we currently save the PRD registers and then disable DMA. This is racy; the sound hardware might update the PRD register as it finishes processing some DMA pages between when we've saved the PRD registers and when DMA actually gets disabled. Furthermore, we actively check whether or not DMA is enabled before saving PRD registers; there's no reason to do that, as the PRD registers should not update when we twiddle the ACC_BM[x]_CMD register(s). Worst case, we save the PRD ...
Aug 29, 8:29 pm 2007
Jordan Crouse
Re: ALSA: cs5535audio: fix PRD register save/restore pow ...
-- Jordan Crouse Systems Software Development Engineer Advanced Micro Devices, Inc. -
Aug 30, 7:44 am 2007
Andres Salomon
[PATCH 1/5] ALSA: cs5535audio: correctly set dma->substream
We're never actually setting dma->substream to the current substream; that means the dma->substream checks that we do in the suspend/resume path are never satisfied, and the PRD registers are never correctly managed. This changes it so that we set the substream when constructing the specific bus master DMA, and unsetting it when we tear down the BM's DMA. Signed-off-by: Andres Salomon <dilinger@debian.org> --- sound/pci/cs5535audio/cs5535audio_pcm.c | 2 ++ 1 files changed, 2 ...
Aug 29, 8:28 pm 2007
Jordan Crouse
Re: ALSA: cs5535audio: correctly set dma->substream
-- Jordan Crouse Systems Software Development Engineer Advanced Micro Devices, Inc. -
Aug 30, 7:44 am 2007
Andres Salomon
[PATCH 0/5] ALSA: cs5535audio fixes
Hi, Here are a bunch of fixes for the cs5535audio driver. None of these are OLPC specific; generic chip and power management fixes, and one cleanup patch. All have been tested on an OLPC (5536), so even though the 5535 data sheet claims to be the same, it would be nice to hear success/failure reports from someone with a 5535. -- Andres Salomon <dilinger@queued.net> -
Aug 29, 8:27 pm 2007
Jordan Crouse
Re: ALSA: cs5535audio fixes
These look good - and they should work fine on the 5535 - none of the patches really change how we touch the hardware, just when we touch the hardware. 5536 is by far the more popular chip now, so I recommend we put these in, and if by some unlucky coincidence a 5535 bug pops up, we'll deal with it when it happens. Jordan -- Jordan Crouse Systems Software Development Engineer Advanced Micro Devices, Inc. -
Aug 30, 7:48 am 2007
Takashi Iwai
Re: [PATCH 0/5] ALSA: cs5535audio fixes
At Wed, 29 Aug 2007 23:52:08 -0400, OK, let me know if it works for you. Then I'll apply them to ALSA tree. Thanks, Takashi -
Aug 30, 3:53 am 2007
Jaya Kumar
Re: [PATCH 0/5] ALSA: cs5535audio fixes
The patches look good. I'm traveling till Sep 2nd so can't test on 5535 yet. Thanks very much for your efforts Andres. Thanks, jaya Acked-by: Jaya Kumar <jayakumar.alsa@gmail.com> -
Aug 29, 8:52 pm 2007
Divy Le Ray
[PATCH 2.6.23 2/2] - cxgb3 engine microcode load
From: Divy Le Ray <divy@chelsio.com> Load the engine microcode when an interface is brought up, instead of of doing it when the module is loaded. Loosen up tight binding between the driver and the engine microcode version. There is no need for microcode update with T3A boards. Fix the file naming. Do a better job at logging the loading activity. Signed-off-by: Divy Le Ray <divy@chelsio.com> --- drivers/net/cxgb3/common.h | 3 + drivers/net/cxgb3/cxgb3_main.c | 126 ...
Aug 29, 7:15 pm 2007
Divy Le Ray
[PATCH 2.6.23 1/2] cxgb3 - Fix dev->priv usage
From: Divy Le Ray <divy@chelsio.com> cxgb3 used netdev_priv() and dev->priv for different purposes. In 2.6.23, netdev_priv() == dev->priv, cxgb3 needs a fix. This patch is a partial backport of Dave Miller's changes in the net-2.6.24 git branch. Without this fix, cxgb3 crashes on 2.6.23. Signed-off-by: Divy Le Ray <divy@chelsio.com> --- drivers/infiniband/hw/cxgb3/cxio_hal.c | 2 - drivers/net/cxgb3/adapter.h | 2 + drivers/net/cxgb3/cxgb3_main.c | 126 ...
Aug 29, 7:15 pm 2007
Divy Le Ray
[PATCH 2.6.23 0/2] cxgb3 driver fixes
Jeff, I'm resubmitting the cxgb3 dev->priv issue. I'm also submitting a patch fixing the engine microcode loading. The first patch changes in both cxgb3 and iw_cxgb3 related to the dev->priv issue. The second patch allows the driver to load the engine microcode at the right time - when a port is brought up as opposed to the module getting loaded. It does a better job at logging the loading activity, and loosen the strict version requirement currently in place. Cheers, Divy -
Aug 29, 7:14 pm 2007
Salah Coronya
Re: Forced unmounting for removable devices
There are patches in -mm for revokeat()/frevoke(), which can be used to implement exactly that. If a device "vanishes" (CD is removed in the middle of loading, USB pend rive yanked out the middle of I/O, NFS server thats gone MIA), A user-space program (maybe HAL) could iterate over the open files and revoke() them, at which point the system can be cleanly unmounted. -
Aug 29, 8:14 pm 2007
Eduard-Gabriel Munteanu
Forced unmounting for removable devices
*This message was transferred with a trial version of CommuniGate(r) Pro* This might have been discussed a few years ago, but things have changed. I'm talking about patches like this one (I'm not the author): http://developer.osdl.org/dev/fumount/#kernel1 The current situation requires a way to forcibly unmount removable media. Consider the following (real) scenario. Someone has a box with hald + dbus + ivman to support "supermounting" the CDROM drive. He has to install a 2 CD application ...
Aug 29, 6:51 pm 2007
Xavier Bestel
Re: speeding up swapoff
Yeah, sure. But these days disk space is cheap and I tend to put too big swap partitions, and I always regret it later ... Xav -
Aug 30, 7:14 am 2007
Xavier Bestel
Re: speeding up swapoff
If the swap file is full, you probably have a machine dead into a swap storm. -
Aug 30, 7:06 am 2007
Robert Hancock
Re: speeding up swapoff
Normally mlockall is what is used in this sort of situation, that way it doesn't force all swapped data in for every app. It's possible that calling this with lots of swapped pages in the app at the time may have the same problem though. -- Robert Hancock Saskatoon, SK, Canada To email, remove "nospam" from hancockr@nospamshaw.ca Home Page: http://www.roberthancock.com/ -
Aug 29, 6:37 pm 2007
Helge Hafting
Re: speeding up swapoff
Only if you have enough swap. :-) Helge Hafting -
Aug 30, 7:06 am 2007
Helge Hafting
Re: speeding up swapoff
If the swap device is full, then there is no need for random seeks as the swap pages can be read in disk order. A not so full swap will skip over the unused areas, the time needed should still be limited to the time needed for reading the whole swap device. If this optimization is worth it is another problem though. Helge Hafting -
Aug 30, 6:55 am 2007
Robert Hancock
Re: [Bugme-new] [Bug 8957] New: Exported functions and v ...
Under what circumstances is this actually happening? What are these functions that are being called? Normally things are set up such that this isn't a problem, i.e. if module A depends on module B, module A can't load until module B is finished loading. -- Robert Hancock Saskatoon, SK, Canada To email, remove "nospam" from hancockr@nospamshaw.ca Home Page: http://www.roberthancock.com/ -
Aug 29, 6:33 pm 2007
Andrew Morton
Re: [Bugme-new] [Bug 8957] New: Exported functions and v ...
Good point. This thus-far-undescribed module could make its internals externally visible via one of the kernel's many register_foo() interfaces, but it would be a buggy module if it was doing register_foo(my_foo) before my_foo() was ready to be called. -
Aug 29, 7:10 pm 2007
Satyam Sharma
Re: [Bugme-new] [Bug 8957] New: Exported functions and v ...
Hmm, can you post some sample code / sample module to reproduce this? I don't think exported symbols can be resolved till our module finishes loading + initializing. There's a whole lot of dancing in the libusual See drivers/usb/storage/libusual.c -- pretty unusual goings on there :-) It needs to request_module() another module (that will reference our exported symbols). To cope with the fact that our exported modules _cannot_ be resolved till we finish loading, it uses ...
Aug 30, 10:35 am 2007
Dave Young
Re: 2.6.23-rc3-mm1: inlining failures in sound/pci/hda/h ...
How about this one: diff -uprN linux/sound/pci/hda/hda_codec.c linux.new/sound/pci/hda/hda_codec.c --- linux/sound/pci/hda/hda_codec.c 2007-08-30 09:27:42.000000000 +0800 +++ linux.new/sound/pci/hda/hda_codec.c 2007-08-30 09:27:50.000000000 +0800 @@ -514,7 +514,11 @@ static int read_widget_caps(struct hda_c static void init_hda_cache(struct hda_cache_rec *cache, unsigned int record_size); -static inline void free_hda_cache(struct hda_cache_rec *cache); + +static inline void ...
Aug 29, 6:33 pm 2007
Daniel Walker
2.6.23-rc4-dw1
I've updated to 2.6.23-rc4 .. This is an "Ingo appears to be busy.." release .. I've been waiting for a -rt update , but there hasn't been one for a while. So my tree is the best everyone will get for now. ftp://source.mvista.com/pub/dwalker/rt/patch-2.6.23-rc4-dw1 ftp://source.mvista.com/pub/dwalker/rt/patch-2.6.23-rc4-dw1.tar.bz2 The patches follow the release style of Ingo's tree, and his release notes also apply to my patch as well. I included a fresh git-acpi pull. I also included ...
Aug 29, 5:17 pm 2007
Peter Zijlstra
Re: Possible kernel lock in semaphore's __down()
I think the reported meant interrupt driven involuntary preemption. So ret_from_intr() is not the right place to look. But afaict you're still right, see how preempt_schedule*() adds PREEMPT_ACTIVE to the preempt_count, and how that makes the scheduler ignore the task state. -
Aug 30, 12:16 am 2007
Oleg Nesterov
Re: Possible kernel lock in semaphore's __down()
(just in case Peter's explanation was too concise) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ No, ret_from_intr() still can schedule(). Actually it does preempt_schedule_irq() which sets PREEMPT_ACTIVE. this is OK, because in this case schedule() doesn't remove the task from run queue even if its state is TASK_UNINTERRUPTIBLE, if (prev->state && !(preempt_count() & PREEMPT_ACTIVE)) { ... deactivate_task(); } note the "!(preempt_count() & ...
Aug 30, 2:12 am 2007
Ian Kent
RE: regression of autofs for current git?
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=75180df2ed... This (and it's related patches) may be the problem. I can probably tell if you post your map or if you strace the automount process managing the a problem mount point and look for mount returning -
Aug 29, 8:25 pm 2007
Hua Zhong
RE: regression of autofs for current git?
I am in the process of bisecting now. It takes a while but the bad commit is between 2.6.22 and 13f9966b3ba5b45f47f2ea0eb0a90afceedfbb1f (June 28). I'll continue tomorrow. My system is FC4. autofs-4.1.4-26 nfs-utils-1.0.7-13.FC4 By the way, the particular autofs commit Andrian sent is innocent. It's something else. It will still take me about 10 reboots to bisect. If anyone has a patch for -
Aug 29, 8:09 pm 2007
Ian Kent
Re: regression of autofs for current git?
Maybe but there is an NFS change that appears to be in the current 2.6.23-rc kernel and doesn't seem to be in 2.6.22 that is known to break some autofs maps and also breaks amd. I can't seem to locate the commit just now. In the meantime what version of user space autofs and nfs-utils are you running? And can you post your autofs maps please? Ian -
Aug 29, 8:00 pm 2007
Xu Yang
Re: from which address does the kernel load initrd?
hi peter, thanks for your reply. my platform is realview_eb_mpcore. the cpu is arm. not i386. and I check the booting file in the documentation /arm , it is not specified. do you have any idea about that? anyone knows? thanks, regards, -
Aug 30, 4:44 am 2007
Linus Torvalds
Re: [RFC] TASK_KILLED
Hey, I obviously approve. And the patch looks simple. Feel free to re-submit after 2.6.23 is out the door, I don't think anybody will really complain. Any NFS user will know why something like this can be really nice. Linus -
Aug 29, 9:38 pm 2007
Matthew Wilcox
Re: [RFC] TASK_KILLED
Indeed. I didn't intend to include this hunk because I hadn't tested it -- I've not seen a task get stuck there. In trying to fix it, I noticed that the sync_page_killable() is inadequate -- it'll return -EIO for any signal, not just a fatal one. Sure, other signals won't wake it, but if they're pending, it'll do the wrong thing. Fixed patch coming up ... just as soon as I find out what other bug I've introduced. -- Intel are signing my paycheques ... these opinions are still ...
Aug 30, 7:51 am 2007
Trond Myklebust
Re: [RFC] TASK_KILLED
Won't this change just cause functions like do_sync_read() and -
Aug 30, 6:11 am 2007
Arkadiusz Miskiewicz
Re: 2.6.22 oops kernel BUG at block/elevator.c:366!
Looks like this bug is known for months :-( Ed Lin pointed to http://lkml.org/lkml/2007/1/23/268 with possible patch (that unfortunately serialises access to storage devices, well...) There is also: http://bugzilla.kernel.org/show_bug.cgi?id=7842 I'm running 2.6.22 with that patch now, did huge (few hours) rsync that previously caused oopses and now everything works properly. Can we get some form of this patch into Linus tree? -- Arkadiusz Miśkiewicz PLD/Linux Team arekm / ...
Aug 30, 4:29 am 2007
Felipe Balbi
Re: linux-2.6.23-rc4 ppc build failure
Hi, Well, I don't have ppc cross-compiler... so I can't try this for you. What I can tell you is that it doesn't seem like there was any change regarding those functions. But even though, you're selecting the needed Kconfig Macros. -- Best Regards, Felipe Balbi felipebalbi@users.sourceforge.net -
Aug 30, 3:41 am 2007
Bret Towe
Re: linux-2.6.23-rc4 ppc build failure
turns out the issue was I didn't have 'Enhanced IDE/MFM/RLL disk/cdrom/tape/floppy support' selected (symbol BLK_DEV_IDE) it was set as module current code requires it to be built in guess drivers/ide/Kconfig needs a touch up? -
Aug 30, 2:56 pm 2007
John Sigler
Re: hda: set_drive_speed_status: status=0x51 { DriveRead ...
The tragic bit is that we were sold similar DOMs in 2007... Double word is 32 bits, right? Isn't "Cannot perform double-word IO" in contradiction with the following statements? IO_support = 1 (32-bit) Buffer size: 1.0kB bytes avail on r/w long: 4 When you say "the current libata IDE" do you mean PATA_VIA (in my case)? I've avoided this driver because it is marked EXPERIMENTAL. Would there What do the warnings mean? :-) Regards. -
Aug 30, 1:17 am 2007
Alan Cox
Re: hda: set_drive_speed_status: status=0x51 { DriveRead ...
Old IDE wrongly tries to issue a set features command for PIO2 to the device. It rejects it and old IDE carries on happy -
Aug 30, 7:05 am 2007
Joel Schopp
Re: [PATCH 2.6.23] ibmebus: Prevent bus_id collisions
OK, didn't realize it had to be beneath the root node, and that the truncation truncated the front and not the back. I would have done it differently, but this should work. Acked-by: Joel Schopp <jschopp@austin.ibm.com> -
Aug 30, 1:36 pm 2007
Arnd Bergmann
Re: [PATCH 2.6.23] ibmebus: Prevent bus_id collisions
Actually, I think it would be much better to convert the code to be more like of_platform_device, or to even replace all of ibmebus with that. The whole logic of dynamically adding and removing device is rather bogus, and it prevents autoloading of device drivers. of_platform_make_bus_id is the function that is responsible for creating unique names over there. Arnd <>< -
Aug 30, 11:22 am 2007
Linas Vepstas
Re: [PATCH 2.6.23] ibmebus: Prevent bus_id collisions
Yes, well, but no. The location code is useful as a geographical location: slots and devices are physically labelled with stickers so you can tell which is which. Handy when you have to unplug stuff. By contrast, the device-tree full_name is mostly just gobldy-gook, with some crazy phb numbering in there that, after four years of staring at them, I still can't reliably do anything useful with. Location codes are nice. --linas -
Aug 30, 2:28 pm 2007
Nathan Lynch
Re: [PATCH 2.6.23] ibmebus: Prevent bus_id collisions
Hi Joachim- struct device's bus_id field is but 20 bytes in size. Too close for Okay, but your layman isn't supposed to be relying on any user-friendly properties of the name :) Hope he doesn't work on a distro installer. Anyway, if you're still confident in this approach, I relent. :) -
Aug 30, 10:56 am 2007
Joachim Fenkes
Re: [PATCH 2.6.23] ibmebus: Prevent bus_id collisions
Nope. Userspace programs should not depend on ibmebus' way of naming the devices; especially since some overly long loc_codes tended to be truncated and thus rendered useless. I have tested IBM's DLPAR tools While there's no such guarantee (as in "officially signed document"), yes, I expect future GX devices to also appear beneath the OFDT root node. For the existing devices, the unit addresses are already part of the device name, so I save the need to use sprintf() again. Plus, I ...
Aug 30, 7:00 am 2007
Björn
Re: [PATCH] avoid negative (and full-width) shifts in ra ...
Or in this context: RADIX_TREE_INDEX_BITS, which happens to be the old check, which just needed to be extended to cover negative shifts. Björn -
Aug 29, 5:46 pm 2007
Takashi Iwai
Re: [PATCH] snd_hda_intel for F/S T4210
At Wed, 29 Aug 2007 17:34:19 +0200, The problem is that nid = 0 is used. So, your patch just hides another bug. Please check whether the bug still exists with git.kernel.org perex/alsa.git mm branch. If still there, build with CONFIG_SND_DEBUG and show the autoconfig output. thanks, -
Aug 30, 8:04 am 2007
Soeren Sonnenburg
Re: [4/4] 2.6.23-rc4: known regressions
I am not sure whether the problem I am having is not the very same as the one Arkadiusz is seeing. At least I've found resume from s2ram to be working a couple of times. Only sometimes it took long to resume, that is >30 seconds (around 5 - which I already consider long - is normal). anyway this this is with the closed source fglrx kernel module, as without the machine freezes when X is running on resume... well and fglrx seems to cause this ... BUG: scheduling while atomic: ...
Aug 30, 3:42 am 2007
Danny ter Haar
Re: [2/4] 2.6.23-rc4: known regressions
I just compiled 2.6.23-rc4 on this setup to check if we made any progress. After reboot i see: [SNIP] NET: Registered protocol family 17 Using IPI Shortcut mode Freeing unused kernel memory: 148 freed init[1]: segfault at 85890000 eip 85890000 esp bfcfcb8c error 4 init[1]: segfault at 85890000 eip 85890000 esp bfcfcb8c error 4 init[1]: segfault at 85890000 eip 85890000 esp bfcfcb8c error 4 init[1]: segfault at 85890000 eip 85890000 esp bfcfcb8c error 4 init[1]: segfault at 85890000 eip ...
Aug 30, 1:21 am 2007
Christoph Lameter
Re: [1/4] 2.6.23-rc4: known regressions
Looks like this is just alpha and a certain particular compiler version? You may get away with adding void __kmalloc_size_too_large(void) { BUG(); } somewhere if you use the particular compiler version causing trouble. The compiler will then generate some useless code wasting processor cycles due to not folding constants but it should(tm) work. -
Aug 29, 5:39 pm 2007
Jan Dittmer
Re: [1/4] 2.6.23-rc4: known regressions
binutils 2.15.95, gcc 3.3.6 and I could update to 4.0.4 or something more recent I guess. And yes, it's only alpha. Of which file do you want the objdump? Jan -
Aug 30, 12:10 am 2007
Jan Dittmer
Re: [1/4] 2.6.23-rc4: known regressions
Here is one of them: 19380: 10 00 1f 20 lda v0,16 19384: e6 ff ff c3 br 19320 <srmcons_get_private_struct+0x90> * Generate a link failure. Would be great if we could * do something to stop the compile here. */ extern void __kmalloc_size_too_large(void); __kmalloc_size_too_large(); 19388: 00 00 7d a7 ldq t12,0(gp) 1938c: 00 40 5b 6b jsr ...
Aug 30, 11:46 am 2007
Christoph Lameter
Re: [1/4] 2.6.23-rc4: known regressions
Could you give me an asm dump via objdump of one of these functions? I wonder what is going on there? Seeing the code generated may give us a hint what is going on. Likely an old compiler that has troubles performing constant folding <sigh>. One solution would be to use a newer compiler? And yes, the page allocator pass through patch in mm would fix this. Or define CONFIG_BROKEN_CONSTANT_FOLDING for alpha and then use this patch: --- include/linux/slub_def.h | 4 ++++ 1 file ...
Aug 29, 5:11 pm 2007
Christoph Lameter
Re: [1/4] 2.6.23-rc4: known regressions
The one where the link fails. Dump the code around the unresolved symbol. -
Aug 30, 11:12 am 2007
Martin Knoblauch
Re: Understanding I/O behaviour - next try
Robert, just checked it out. At least with the "6i", you do not want to disable the WBC :-) Performance really goes down the toilet for all cases. Do you still have a pointer to that bulletin? Cheers Martin ------------------------------------------------------ Martin Knoblauch email: k n o b i AT knobisoft DOT de www: http://www.knobisoft.de -
Aug 30, 3:26 am 2007
Eric W. Biederman
Re: speeding up swapoff
There is one other possibility. Typically the swap code is using compatibility disk I/O functions instead of the best the kernel can offer. I haven't looked recently but it might be worth just making certain that there isn't some low-level optimization or cleanup possible on that path. Although I may just be thinking of swapfiles. I know there were tremendous gains ago when I removed the functions that wrote pages synchronously to swapfiles. Eric -
Aug 30, 1:27 am 2007
Daniel Drake
Re: speeding up swapoff
There are some issues with us using mlockall. Admittedly, most/all of them are not the kernels problem (but a fast swapoff would be a good workaround): We're using python 2.4, so mlock() itself isn't really an option (we don't realistically have access to the address regions hidden behind the language). mlockall() is a possibility, but the fact that all allocations above a particular limit will fail would potentially cause us problems given that it's hard to control python's memory usage for ...
Aug 30, 8:05 am 2007
Bill Davidsen
Re: speeding up swapoff
So the real issue isn't that your process doesn't run fast enough How much is "a lot?" You said 400MB, you can add a few GB of RAM and eliminate the problem at that size. Run the application in a virtual machine which has enough dedicated memory? I think xen will do that. Run "swap" on a ramdisk? I don't think swapoff was designed as a fast operation, although your performance is pretty leisurely. ;-) I assume you looked at mlock() and it doesn't fit your usage, or you don't control ...
Aug 30, 8:57 am 2007
Hugh Dickins
Re: speeding up swapoff
Andrew rewrote swapfile support in 2.5, making it use FIBMAP at swapon time: so that in 2.6 swapfiles are as deadlock-free and as efficient (unless the swapfile happens to be badly fragmented) as raw disk partitions. There's certainly scope for a study of I/O patterns in swapping, it's hard to imagine that improvements couldn't be made (but also easy to imagine endless disputes over different kinds of workload). But most people would appreciate an improvement in active swapping, and not care ...
Aug 30, 3:36 am 2007
Grant Grundler
Re: [PATCH] local_t Documentation update 2
Signed-off-by: Grant Grundler <grundler@parisc-linux.org> thanks! -
Aug 29, 6:08 pm 2007
KAMEZAWA Hiroyuki
Re: [-mm PATCH] Memory controller improve user interface
On Thu, 30 Aug 2007 04:07:11 +0530 I have no strong opinion. But how about Mega bytes ? (too big ?) There will be no rounding up/down problem. -Kame. -
Aug 29, 10:38 pm 2007
Balbir Singh
Re: [-mm PATCH] Memory controller improve user interface
Here is what I am thinking, allow the user to input bytes/kilobytes/ megabytes or gigabytes. Store the data internally in kilobytes or PFN. I prefer kilobytes (no rounding issues), but while implementing limits we round up to the closest PFN. -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL -
Aug 30, 2:13 am 2007
HighPoint Linux Team
[PATCH/RESENT] hptiop: adding new firmware interface and ...
updated patch based on Jeff Garzik's comments. - check adapter firmware version and use appropriate interface accordingly - add new PCI device IDs and use PCI_VDEVICE macro - update driver version string - remove unused data structures - remove unnecessary typecasts Signed-off-by: HighPoint Linux Team <linux@highpoint-tech.com> --- drivers/scsi/hptiop.c | 63 +++++++++++++---- drivers/scsi/hptiop.h | 229 ++------------------------------------------------------------- 2 files changed, ...
Aug 30, 3:06 am 2007
Jeff Garzik Aug 30, 3:53 am 2007
Luca
Re: Linux 2.6.23-rc4: BAD regression
Tested here, works fine. Luca -
Aug 30, 12:17 pm 2007
Linus Torvalds
Re: Linux 2.6.23-rc4: BAD regression
Alexey, Len, can we get this fix integrated asap? Linus -
Aug 30, 10:21 am 2007
Daniel Ritz Aug 30, 10:07 am 2007
Rob Landley
Re: [PATCH] sysctl: Deprecate sys_sysctl in a user space ...
A lot of embedded people like to configure /proc out of the kernel for space reasons. This would make that noticeably more painful. (If sysctlfs wasn't part of proc, that would be less of an issue, but we need union mounts for that...) Rob -- "One of my most productive days was throwing away 1000 lines of code." - Ken Thompson. -
Aug 30, 12:32 pm 2007
Christoph Hellwig
Re: [PATCH] sysctl: Deprecate sys_sysctl in a user space ...
Not at all. all sysctls are under /proc/sys/ -
Aug 30, 11:34 am 2007
Eric W. Biederman
Re: [PATCH] sysctl: Deprecate sys_sysctl in a user space ...
Only in a strict mathematical sense. I seem to recall patches to those programs or seeing that it doesn't matter. Things are sufficient that I expect that in 2 years time when we revisit this. We won't be able to find anything that cares. Eric -
Aug 30, 10:40 am 2007
Rob Landley
Re: [PATCH] sysctl: Deprecate sys_sysctl in a user space ...
Ah, right. Good point. (I was thinking of the problem of splitting /proc/$PID directories from the rest of the stuff in /proc.) Rob -- "One of my most productive days was throwing away 1000 lines of code." - Ken Thompson. -
Aug 30, 4:22 pm 2007
Jan Engelhardt
Re: [PATCH] sysctl: Deprecate sys_sysctl in a user space ...
Great, why do not we remove all the things marked obsolete and start Linux 2.*newversionbeep*. Just rm, no add, and then tag. If we never start moving to get rid of the old stuff, we will be ending up where Microsoft is; though we won't get there as fast since Linux was designed carefully in the first place and did/does not collect as much compat dust. Jan -- -
Aug 30, 11:56 am 2007
Theodore Tso
Re: [PATCH] sysctl: Deprecate sys_sysctl in a user space ...
It's not hard to do read-side, right? Take the list of sysctl's, and create a program which reads it via the binary interface and the /proc interface, and verify they are the same. Testing write-side, where we have to worry about permission tests, making sure the correctr value is set, locking issues, etc., is admittedly more difficult. My guess though many programs/libraries are reading from the sysctl interface than writing to it. - Ted -
Aug 30, 5:13 am 2007
David Newall
Re: [PATCH] sysctl: Deprecate sys_sysctl in a user space ...
If may be unmaintainable but, apparently, it's not really unused. -
Aug 30, 6:20 am 2007
Eric W. Biederman
Re: [PATCH] sysctl: Deprecate sys_sysctl in a user space ...
Yes. So all we really need to do is split them apart and do the nfs multiple mount thing to maintain backwards compatibility when mounting proc. The code is close enough to split apart now that it probably would not be to difficult to finish the job. Eric -
Aug 30, 11:57 am 2007
Christoph Lameter
Re: [RFC 1/4] Large Blocksize support for Ext2/3/4
Ahh. Good. I could add the path to the large blocksize patchset? -
Aug 29, 5:59 pm 2007
Christoph Lameter Aug 29, 5:12 pm 2007
Mingming Cao
Re: [31/36] Large Blocksize: Core piece
There are patches original worked by Takashi Sato to support large block size (up to 64k) in ext2/3/4, which addressed the directory issue as well. I just forward ported. Will posted it in a separate thread. Haven't get a chance to integrated with your patch yet (next step). thanks, -
Aug 29, 5:11 pm 2007
Mingming Cao
[RFC 2/4]ext2: fix rec_len overflow with 64KB block size
[2/4] ext2: fix rec_len overflow - prevent rec_len from overflow with 64KB blocksize Signed-off-by: Takashi Sato <sho@tnes.nec.co.jp> Signed-off-by: Mingming Cao <cmm@us.ibm.com> --- fs/ext2/dir.c | 46 ++++++++++++++++++++++++++++++++++++---------- include/linux/ext2_fs.h | 13 +++++++++++++ 2 files changed, 49 insertions(+), 10 deletions(-) Index: linux-2.6.23-rc3/fs/ext2/dir.c =================================================================== --- ...
Aug 29, 5:47 pm 2007
Mingming Cao
[RFC 4/4]ext4: fix rec_len overflow with 64KB block size
[4/4] ext4: fix rec_len overflow - prevent rec_len from overflow with 64KB blocksize Signed-off-by: Takashi Sato <sho@tnes.nec.co.jp> Signed-off-by: Mingming Cao <cmm@us.ibm.com> --- fs/ext4/dir.c | 11 ++++-- fs/ext4/namei.c | 88 +++++++++++++++++++++++++++++++++++++++--------- include/linux/ext4_fs.h | 9 ++++ 3 files changed, 90 insertions(+), 18 deletions(-) Index: ...
Aug 29, 5:48 pm 2007
Mingming Cao
[RFC 1/4] Large Blocksize support for Ext2/3/4
The next 4 patches support large block size (up to PAGESIZE, max 64KB) for ext2/3/4, originally from Takashi Sato. http://marc.info/?l=linux-ext4&m=115768873518400&w=2 It's quite simple to support large block size in ext2/3/4, mostly just enlarge the block size limit. But it is NOT possible to have 64kB blocksize on ext2/3/4 without some changes to the directory handling code. The reason is that an empty 64kB directory block would have a rec_len == (__u16)2^16 == 0, and this would cause an ...
Aug 29, 5:47 pm 2007
Mingming Cao
[RFC 3/4] ext3: fix rec_len overflow with 64KB block size
[3/4] ext3: fix rec_len overflow - prevent rec_len from overflow with 64KB blocksize Signed-off-by: Takashi Sato <sho@tnes.nec.co.jp> Signed-off-by: Mingming Cao <cmm@us.ibm.com> --- fs/ext3/dir.c | 13 ++++--- fs/ext3/namei.c | 88 +++++++++++++++++++++++++++++++++++++++--------- include/linux/ext3_fs.h | 9 ++++ 3 files changed, 91 insertions(+), 19 deletions(-) Index: ...
Aug 29, 5:48 pm 2007
Christoph Lameter
Re: [11/36] Use page_cache_xxx in fs/buffer.c
Hmmm... So we need to check the page size and generate multiple requests in submit_bh? -
Aug 30, 11:14 am 2007
Dmitry Monakhov
Re: [11/36] Use page_cache_xxx in fs/buffer.c
submit_bh wasn't changed this means what bio pages may have huge size without respect to queue reqsrictions (q->max_hw_segments, and etc) -
Aug 30, 2:20 am 2007
Dor Laor
RE: [Lguest] [V9fs-developer] [kvm-devel] [RFC] 9p: add ...
My current view of the IO stack is the following: -------------- -------------- ------------ ---------- ---------- --------- |NET_PCI_BACK| |BLK_PCI_BACK| |9P_PCI_BACK| |NET_FRONT| |BLK_FRONT| |9P_FRONT| -------------- -------------- ------------ ---------- ---------- --------- ------------- --------------- ------------------- |KVM_PCI_BUS| |hypercall_ops| |shared_mem_virtio| ------------- ...
Aug 29, 9:40 pm 2007
John W. Linville
Re: [PATCH 5/5] Net: ath5k, kconfig changes
FWIW, I'd bet dollars to donuts that distros will enable them all together. Is saving code space the only reason to turn these off? How much space do you save? Is there some way you can isolate and/or limit the number of ifdef blocks further? If so, we might consider a version of this patch that depends on EMBEDDED or somesuch...? John -- John W. Linville linville@tuxdriver.com -
Aug 30, 5:36 am 2007
Nick Kossifidis
Re: [PATCH 5/5] Net: ath5k, kconfig changes
O.K. as a first step i'll limit 5210 code only then, just an option like "support older 5210 chipsets" which is going to be off by default instead of 3 options. It's not just saving space, it's also saving some runtime checks. It's not really a gain in performance though, most checks are done during initialization and dfs setup, i just thought it would be usefull to save as much cpu as possible. -- GPG ID: 0xD21DB2DB As you read this post global entropy rises. Have Fun ;-) Nick -
Aug 30, 3:18 pm 2007
Nick Kossifidis
Re: [PATCH 5/5] Net: ath5k, kconfig changes
It saves big chunks of code (not only initial register settings arrays) and we'll extend it's use more inside ath5k_hw.c Trust me this is a very useful step, eg. check out descriptor processing / setup or PHY functions (calibrate/channel set etc). For example AR5210 mac chip only comes with RF5110 phy chip so we can get rid of RF5111/RF5112 code, AR5211 comes with RF5111 so we can get rid of RF5110 and RF5112 code and AR5212 comes with RF5111 or RF5112 so we get rid of RF5110. This thing also ...
Aug 29, 6:38 pm 2007
Christoph Hellwig
Re: [PATCH 5/5] Net: ath5k, kconfig changes
If you're doing these checks in a hotpath something is badly wrong with your architecture. -
Aug 30, 5:35 am 2007
Jarek Poplawski
Re: [PATCH 4/5] Net: ath5k, license is GPLv2
I didn't track this thread from the beginning, so maybe I repeat somebody's ideas (probably like above), but IMHO: do we have to be so selfish/pedantic? Can't we sometimes 'donate' a little bit to our 'older' bsd cousins or half-brothers? I think, it could be like this: - if our changes are minor and authors of these changes don't mind the file could stay BSD licensed only; plus we ask BSD to let it be dual licensed (but no big hassle); - otherwise, we should always distinctly mark all GPL ...
Aug 30, 1:26 am 2007
Jarek Poplawski
Re: [PATCH 4/5] Net: ath5k, license is GPLv2
On Thu, Aug 30, 2007 at 10:26:52AM +0200, Jarek Poplawski wrote: ...or maybe it's OK... Sorry. Jarek P. -
Aug 30, 1:32 am 2007
David Newall
Re: [PATCH 4/5] Net: ath5k, license is GPLv2
Is it actually necessary to change the license? With the dual-license, you can keep a single code-base for both BSD and Linux platforms, which seems terribly important to me. It'd be awful to lose that. It would be a maintenance nightmare for BSD. Is it even possible--in real life, I mean--to accept GPLed patches into a BSD project? Nightmare, I tell you! -
Aug 30, 6:02 am 2007
Johannes Berg
Re: [PATCH 4/5] Net: ath5k, license is GPLv2
In theory, that could work, but in practice relying on functions that the Linux kernel offers in GPLv2-only headers etc. will make the result GPLv2 anyway, and disentangling it would be a nightmare. johannes
Aug 30, 4:59 am 2007
Jarek Poplawski
Re: [PATCH 4/5] Net: ath5k, license is GPLv2
Why? Very good point, but, in my opinion, it should be still resonable for both sides: it simply means such changes are mostly unusable for the other side, but nobody is going to waste time for marking all these places, or care about suing if accidentally the changes, after some adaptation, are usable for the other side. Unless you think or know that "#include xyz" or "print_linux_way()" should add more than these (maybe unusable) words or lines only? Jarek P. -
Aug 30, 6:45 am 2007
John W. Linville
Re: [PATCH 3/5] Net: ath5k, use int as retval
Since I didn't apply 1/5, this one didn't apply either. It seems fine overall, so if you rediff I'll be happy to apply. John -- John W. Linville linville@tuxdriver.com -
Aug 30, 5:40 am 2007
Martin Knoblauch
Re: Understanding I/O behaviour - next try
Hi Jens, how exactely is the queue depth related to the max # of commands? I ask, because with the 2.6.22 kernel the "maximum queue depth since init" seems to be never higher than 16, even with much higher outstanding commands. On a 2.6.19 kernel, maximum queue depth is much higher, just a bit below "max # of commands since init". [2.6.22]# cat /proc/driver/cciss/cciss0 cciss0: HP Smart Array 6i Controller Board ID: 0x40910e11 Firmware Version: 2.76 IRQ: 51 Logical drives: 1 Max ...
Aug 30, 3:50 am 2007
Serge E. Hallyn
Re: [PATCH] Send quota messages via netlink
Sorry, I've lost the original patch from two separate mailboxes... The proper behavior depends on how we end up tying filesystems to user namespaces, which isn't actually decided yet. The way I was recommending doing that was: A filesystem is tied to a user namespace. If a uid in another naemspace is to be allowed to access the filesystem, it will actually - through a key in it's keyring (which acts like a capability) - be mapped to a uid in the filesystem's uid namespace. So in Eric's ...
Aug 30, 11:54 am 2007
Serge E. Hallyn
Re: [PATCH] Send quota messages via netlink
(Please skip to the message end first, as I think you may not care about the next bit of my blathering) Right now they are only good for providing some separate accounting for uid 1000 in one user namespace versus uid 1000 in another namespace. All security enforcement must be done by actually providing separate filesystems and separate pid namespaces and, hopefully, with a selinux policy. Eventually the idea will be that uid 1000 in one user namespace and uid 1000 in another namespace ...
Aug 30, 3:14 pm 2007
Jan Kara
Re: [PATCH] Send quota messages via netlink
Maybe before proceeding further with the discussion I'd like to understand following: What are these user namespaces supposed to be good for? I imagine it so that you have a machine and on it several virtual machines which are sharing a filesystem (or it could be a cluster). Now you want UIDs to be independent between these virtual machines. That's it, right? Now to continue the example: Alice has UID 100 on machineA, Bob has UID 100 on machineB. These translate to UIDs 1000 and 1001 on ...
Aug 30, 3:18 pm 2007
Eric W. Biederman
Re: [PATCH] Send quota messages via netlink
So internal to the kernel we have such a universal identifier. struct user. There are to practical questions. 1) How do we present that information to user space? 2) How does user space want to process this information? If we only want user space to be able to look up a user and send him a message. It probably makes sense to do the struct user to uid conversion in the proper context in the kernel because we have that information. If this is a general feature that happens to allows us ...
Aug 30, 10:33 am 2007
Serge E. Hallyn
Re: [PATCH] Send quota messages via netlink
Just fyi Eric, Note that given the amount of churn going on due to pid and network namespaces, I was seeing completion of user namespaces as something to be done sometime next year. In the meantime I was only going to do something with capabilities to restrict root in user namespaces (which I think will take the form of per-process non-expandable cap_bsets, which I plan to start basically right now). But I'll gladly do the userns enhancements earlier if it's actually wanted. They promise ...
Aug 30, 12:18 pm 2007
Serge E. Hallyn
Re: [PATCH] Send quota messages via netlink
Currently that is true, but i think isolating netlink sockets is going to have to be done pretty soon. On the one hand cloning a new netlink socket ns when you unshare CLONE_NEWNET may seem 'obvious', but I think doing so when you unshare CLONE_NEWUSER make much more sense considering netlink's use for audit Even with isolating netlink we still may want to send out an identifier. However, just as with mounts extensions we're printing out the memory address of vfsmounts, we might just want ...
Aug 30, 12:10 pm 2007
Jan Kara
Re: [PATCH] Send quota messages via netlink
There can be arbitrary number of listeners (potentially from different namespaces if I understand it correctly) listening to broadcasts. So I think we should pass some universal identifier rather than try to find out who is listening etc. I think such identifiers would be useful for other things too, won't they? BTW: Do you have some idea, when would be the infrastructure clearer? Whether it makes sence to currently proceed with UIDs and later change it to something generic or whether I ...
Aug 30, 2:25 am 2007
Jochen Friedrich
Re: [PATCH] ppc32/8xx: Fix r3 trashing due to 8MB TLB pa ...
No. At least not until these patches are applied to powerpc, as well: 8f069b1a90bd97bf6d59a02ecabf0173d9175609 [PATCH] powerpc/8xx: Use 8MB D-TLB's for kernel static mapping faults 3ea4807de7b2c5c903380ba2c2e7150bee942f42 [PATCH] powerpc/8xx: last two 8MB D-TLB entries are incorrectly set c51e078f82096a7d35ac8ec2416272e843a0e1c4 [PATCH] ppc32/8xx: Fix r3 trashing due to 8MB TLB page instantiation Thanks, Jochen -
Aug 30, 1:48 am 2007
Jean Delvare
Re: [PATCH] hwmon: Add power meters to Documentation/hwm ...
Hi Darrick, OK, that's a bit different then, but I'm still not sure that there is much value in exporting these values in sysfs, in particular if there is no way to reset them. I am also not happy with the names you proposed: power1_max_input and power1_min_input are somewhat confusing IMHO, I'd suggest power1_input_highest and power1_input_lowest to make them clearly different from the min and max limits we have for other sensor types. If we have them at all, of course. -- Jean ...
Aug 30, 2:57 am 2007
Kristian
Re: [PATCH 00/23] drm: introduce drm_zalloc
Do we ever use that, though? Having to pass in the pointer, the size drm_calloc calls kcalloc which performs an integer overflow check on the 'n' and 'size' arguments, which isn't needed for drm_zalloc. Small detail, of course, but I don't see the problem with aliasing to kzalloc. Kristian -
Aug 30, 9:20 am 2007
Dave Airlie
Re: [PATCH 00/23] drm: introduce drm_zalloc
Christoph that code was written over 6-7 years ago, feel free to provide a patch for it to use the slab allocator, we only turn this code on though when developing new drivers, I don't think it ever gets used outside of that.. we don't need the overhead of the memory tracking in normal use.. Please stop implying that all the code in the drm is magically new and that we should be reusing kernel infrastructure that wasn't even written when the code first appeared.. or provide ...
Aug 30, 4:20 pm 2007
Christoph Hellwig
Re: [PATCH 00/23] drm: introduce drm_zalloc
Note the slab has a memory tracking feature that accounts memory to callers of the allocator. IF that's not enough for you please help improving the common code instead of inventing your own. -
Aug 30, 9:24 am 2007
Jan Engelhardt
Re: [PATCH] trivial - constify sched.h
So that you can actually pass in a const struct task_struct * without having to cast it back to [non-const]. Why one would have a const struct task_struct * in the first place is a different matter. But see http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=77adbfbf4c... Jan -- -
Aug 30, 12:24 pm 2007
Satyam Sharma
Re: [PATCH] trivial - constify sched.h
You've completely missed the point -- it is _plausible_ that callers (even if just _one_) have const timespec/timeval structs, which is why that commit made sense as I mentioned above (to shut up the warning that would otherwise occur). This does not hold true for the sched.h / struct Going about const-ifying such function arguments as in here (for the sake of type safety, where the function does not modify that argument), could easily lead to *zillions* of patches such as this which would ...
Aug 30, 2:21 pm 2007
Jan Engelhardt
Re: [PATCH] trivial - constify sched.h
"those callers". There was _exactly one_ caller, and that was an out-of-tree module. There were not any in-kernel callers before, and it did not generate any warning. That is perhaps why no one had constified it before me. This does I think it is equally 'necessary'. Jan -- -
Aug 30, 1:55 pm 2007
Satyam Sharma
Re: [PATCH] trivial - constify sched.h
That commit const-ified struct timespec * or struct timeval * arguments, which made sense because: (1) those functions really did not modify the passed structs, and, (2) callers that pass in const struct timeval * or const struct timespec * are indeed plausible (because one can plausibly have const timeval/timespec structs). As the changelog suggested, those callers were having to cast away the const qualifier before passing to these functions to avoid seeing "passing argument discards ...
Aug 30, 1:41 pm 2007
Mathieu Desnoyers
Re: [patch 4/4] Port of blktrace to the Linux Kernel Markers.
Or we can use a vprintk-like function to parse the format string and serialize the information into trace buffers. I prefer this latter option because, overall, it will localize the probes in a few bytes of functions instead of duplicating the memory and instruction cache required by multiple serializing functions. I have the code ready, but I do not want to flood LKML with patches neither.... Mathieu -- Mathieu Desnoyers Computer Engineering Ph.D. Student, Ecole Polytechnique de ...
Aug 30, 11:37 am 2007
Christoph Hellwig
Re: [patch 4/4] Port of blktrace to the Linux Kernel Markers.
I like this as it moves the whole tracing code out of line. It would be nice if we could make blktrace a module with this, but we'd need to change the interface away from an ioctl on the block device for that. Btw, something that really shows here and what I noticed in my sputrace aswell is that there is a lot of boilerplate code due to the varargs trace handlers. We really need some way to auto-generate the boilerplate for the trace function to avoid coding this up everywhere. -
Aug 30, 10:21 am 2007
Christoph Hellwig
Re: [patch 0/4] Linux Kernel Markers
Andrew, any chance to get this into -mm ASAP so we can have it in 2.6.24? Just in case anyone wonders what this is usefulfor I've ported my hacking spu tracing code to it, and if markers get in I'd push a cleaned up version of this in the tree of the benefit of everyone trying to follow what's going on in the spufs code. Similarly I'd like to port the xfs tracing code over to it which is very helpful in trying to debug filesystem issues. Note that in this patch the actual logging code is ...
Aug 30, 10:12 am 2007
Roman Zippel
Re: CONFIG_HOTPLUG_CPU: kconfig bug?
Hi, It's somewhat a side effect of using select and defaults, the order of the config symbols becomes significant for oldconfig, if you look at the output you'll find: Support for suspend on SMP and hot-pluggable CPUs (EXPERIMENTAL) (HOTPLUG_CPU) [Y/?] y this sets it to 'y'. In this case one isn't asked about it, because there is only one choice. The patch below avoids the setting of the value here. bye, Roman Avoid setting the value if the symbol doesn't need to be changed or ...
Aug 29, 8:06 pm 2007
Hugh Dickins
Re: CONFIG_HOTPLUG_CPU: kconfig bug?
In fact no: although CONFIG_SUSPEND and CONFIG_HIBERNATION were certainly involved in the logic which arrived at missetting CONFIG_HOTPLUG_CPU, they were correctly prompted for themselves. Hugh -
Aug 30, 2:06 pm 2007
Rafael J. Wysocki
Re: CONFIG_HOTPLUG_CPU: kconfig bug?
Probably CONFIG_SUSPEND, which was a new option, defaulted to 'y' and selected CONFIG_HOTPLUG_CPU indirectly, because CONFIG_SMP was set. Greetings, Rafael -
Aug 30, 11:48 am 2007
Hugh Dickins
Re: CONFIG_HOTPLUG_CPU: kconfig bug?
Thanks for working that out: your patch certainly works for me, and would be good to see in 2.6.23, to prevent lots of users getting an unnecessary CONFIG_HOTPLUG_CPU forever after. I wonder what config But please add a sentence to your patch description, something like: make oldconfig from a 2.6.22 .config with CONFIG_HOTPLUG_CPU not set was in some configurations setting CONFIG_HOTPLUG_CPU=y without asking, even when there was no actual requirement for ...
Aug 30, 5:40 am 2007
Franck Bui-Huu
Re: arch_align_stack() seems useless
Arjan, Do you think that the diff below would be correct ? I tested it on mips and it seems to work fine but I can't really say if it's valid enough to submit it as a patch... thanks Franck ---8<--- diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c index 4482a06..024006e 100644 --- a/fs/binfmt_elf.c +++ b/fs/binfmt_elf.c @@ -151,6 +151,13 @@ create_elf_tables(struct linux_binprm *bprm, struct elfhdr *exec, struct vm_area_struct *vma; /* + * In some cases (e.g. ...
Aug 30, 1:22 am 2007
Jan Engelhardt
Re: Pausing kernel boot messages
Yes, but a common error is "could not mount root", which is way after the keyboard has been initialized. *In fact*, you can start initramfs, have your PgUp/PgDown keys available, and when you exit out of initramfs without a valid root filesystem, you lose the keys again. Jan -- -
Aug 30, 12:15 pm 2007
Matthew Garrett
Re: resume failing on ATA controller
On Mon, Aug 27, 2007 at 06:29:48PM +1000, Dave Airlie wrote: (I've already mentioned this to Dave, but for the benefit of anyone libata doesn't enable ACPI support by default. It needs the libata_acpi option enabled at boottime (libata.libata_acpi?) in order to execute the ACPI methods that HPs seem to need to resume properly. With that change, mine works fine. -- Matthew Garrett | mjg59@srcf.ucam.org -
Aug 30, 4:55 pm 2007
Jan Engelhardt
Re: [PATCH] Use helpers to obtain task pid in printks (a ...
Except that __buf goes out of scope before printk() is called... Jan -- -
Aug 30, 12:11 pm 2007
Casey Schaufler
Re: [PATCH] Version2 Smack: Simplified Mandatory Access ...
simple_fill_super() is unhappy with a const. Casey Schaufler casey@schaufler-ca.com -
Aug 30, 2:51 pm 2007
Jan Engelhardt
Re: [PATCH] Version2 Smack: Simplified Mandatory Access ...
Or even pr_debug. Hey, can we make this const, if it does not change at runtime? Jan -- -
Aug 30, 12:00 pm 2007
Tim Teulings
Re: Sleep problems with kernels >= 2.6.21 on powerpc
Sorry for the delay, but my desktop PC had an urgent hard disk problem I had to fix ASASP. So here is the output from dmesg that suggested to me that firewire The problem wa sinitiated by closing the lid. The iBook then seems to permanetly try to go to sleep (I can hear the cd-rom drive get periodically initialized). So above contains more than one iteration. I'm running a mixture of debian testing/unstable. The firewire and the USB connector were unused, the network connector ...
Aug 30, 1:42 pm 2007
Matthew Wilcox
Re: [PATCH] debloat aic7xxx and aic79xx drivers by deinlining
The problem is that we don't really have a maintainer for the aic7xyz drivers any more. Volunteers welcome. NOT IT! -- Intel are signing my paycheques ... these opinions are still mine "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." -
Aug 30, 12:02 pm 2007
Jan Engelhardt
Re: [PATCH] debloat aic7xxx and aic79xx drivers by deinlining
Well, you can send it to Linus/Andrew, that will usually upset people and they start commenting on it. Or they don't, and everything is fine. (The "default y" approach so to speak ;-) Jan -- -
Aug 30, 11:43 am 2007
Jan Engelhardt Aug 30, 12:51 pm 2007
Jan Engelhardt
Re: file system for solid state disks
The question is, how can you find out whether it does automatic wear-leveling? (Perhaps when a CF is advertised as "holds 10 years!"?) Jan -- -
Aug 30, 11:25 am 2007
Just Marc
Re: file system for solid state disks
One must consult the documentation of that device. This wear leveling is low level and most devices do not export any information about it. Recent SSDs start to export some values through SMART that let you monitor the state. Some companies think that hiding is better than exposing... -
Aug 30, 11:26 am 2007
Davide Libenzi
Re: [PATCH] Revised timerfd() interface
IMO the complexity of the resulting API (and resulting patch), and the ABI change, is not justified by the added value. - Davide -
Aug 30, 5:01 am 2007
Serge E. Hallyn
Re: [2.6 patch] remove securebits
Well it's just 'breaking' old behavior in certain error cases. I.e. if audit fails, or no handler is found for the binary, we never reach compute_creds (which is called from within the binary loader), so in the past keep_capabilities would have remained 1 until something was actually executed. Now in all likelyhood the process would try to exec something else, but if it should happen to decide to setuid() instead, with your patch keep_capabilities will have been unexpectedly set to 0 during ...
Aug 30, 6:26 am 2007
Andrew Morgan
Re: [2.6 patch] remove securebits
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 I agree. I'll try to code it up in a way that its clear how to delete this functionality when folk realize they no longer need it... - -static inline int get_file_caps(struct linux_binprm *bprm) +int cap_bprm_set_security(struct linux_binprm *bprm) { bprm_clear_caps(bprm); + bprm_force_uid0_caps(bprm); I'll look at it again, but I had thought I had preserved the previous behavior with this condensed version of the code. Are you ...
Aug 29, 5:51 pm 2007
Espen M. Rutger
Re: ide.c and compactFlash
Thank you very much for your response Lennart, but unfortunately this did not solve my problem - the system (got four machines in my test setup) still generate the error and make the kernel wait forever. regards Espen M. Rutger -
Aug 30, 3:47 am 2007
Randy Dunlap
Re: [Kgdb-bugreport] 2.6.23-rc3-mm1: kgdb build failure ...
See the URLs at the top of http://git.kernel.org/?p=linux/kernel/git/jwessel/linux-2.6-kgdb.git;a=summary --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** -
Aug 29, 6:38 pm 2007
Rusty Russell
[PATCH] Fix out-by-one error in traps.c
We don't care if ebp is on the stack, we care about ebp + 4. Without this, lguest (with CONFIG_DEBUG_LOCKDEP) can touch a page unmapped by CONFIG_DEBUG_PAGEALLOC. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> diff -r b0b1ab8ecf48 arch/i386/kernel/traps.c --- a/arch/i386/kernel/traps.c Fri Aug 31 03:25:06 2007 +1000 +++ b/arch/i386/kernel/traps.c Fri Aug 31 07:57:35 2007 +1000 @@ -100,7 +100,7 @@ print_context_stack(struct thread_info *tinfo, unsigned long addr; ...
Aug 30, 3:14 pm 2007
Rusty Russell
Re: [PATCH] Fix lguest page-pinning logic ("lguest: bad ...
Yes, I got this too, then had to jump on a plane (and away from my test box). Turns out this actually isn't my bug (yay!). See next patch... Rusty. -
Aug 30, 3:12 pm 2007
Ulrich Drepper
Re: 2.6.23-rc3-mm1 - vdso and gettimeofday issues with glibc
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 glibc does nothing but call the code in the vdso. We have a function pointer variable which either has the old vsyscall value or the address of the function in the vdso. Everything else is identical. Unless the interface of the vdso function is different (which it shouldn't) I don't think you can blame glibc. - -- ➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA ❖ -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 ...
Aug 29, 7:46 pm 2007
Valdis.Kletnieks
Re: 2.6.23-rc3-mm1 - vdso and gettimeofday issues with glibc
Don't bother, I tested this last night against a vanilla 2.6.23-rc3 kernel and it had the same issue as well. So Andi's vdso patches in his tree and/or the -mm kernel aren't to blame - it's in mainline as well. And it's been in for a while - I also hit it with a 2.6.22-rc6-mm1 kernel.
Aug 30, 7:08 am 2007
Chuck Ebbert
Re: 2.6.23-rc3-mm1 - vdso and gettimeofday issues with glibc
Just found this duplicated code in 2.6.23-rc4, maybe it was supposed to be something else? The second one was added in the x86_64 vdso patch. arch/x86_64/kernel/vsyscall.c: void update_vsyscall(struct timespec *wall_time, struct clocksource *clock) { unsigned long flags; write_seqlock_irqsave(&vsyscall_gtod_data.lock, flags); /* copy vsyscall data */ vsyscall_gtod_data.clock.vread = clock->vread; vsyscall_gtod_data.clock.cycle_last = ...
Aug 30, 9:30 am 2007
Frederik Deweerdt
Re: [PATCH] Fix lguest page-pinning logic ("lguest: bad ...
Hello Rusty, I just could try the patch, sorry for the delay. Albeit it allows to progress a little further in the boot process, lguest seems to like that "section that was just freed" :) Please note that: - It could progress to "Freeing SMP alternatives: 13k freed", which is new. Indeed, your patch made the Host to pin 0xc04d3000, which is the good page. - 0xc04d4000 is the __smp_locks section: $ objdump -h vmlinux [...] 20 .data.init_task 00001000 c04d3000 004d3000 003d4000 ...
Aug 30, 9:38 am 2007
Jason Wessel
Re: [Kgdb-bugreport] 2.6.23-rc3-mm1: kgdb build failure ...
I have only ever used: git clone git://git.kernel.org/pub/scm/linux/kernel/git/jwessel/linux-2.6-kgdb.git Jason. -
Aug 29, 7:07 pm 2007
Jason Wessel
Re: [Kgdb-bugreport] 2.6.23-rc3-mm1: kgdb build failure ...
If you are going to make all the kernel text RO, then you are going to have to add some code to the kgdb write memory so as to unprotect a given page or all the breakpoint writes are going to fail. Alternatively you can use HW breakpoints. But, I have no idea if your VM Ware simulated HW emulate HW breakpoint registers or not. Jason. -
Aug 29, 7:13 pm 2007
Pete/Piet Delaney
Re: [Kgdb-bugreport] 2.6.23-rc3-mm1: kgdb build failure ...
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Trying: git clone http://master.kernel.org/pub/scm/linux/kernel/git/jwessel/linux-2.6-kgdb.git - - -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFG1gnFJICwm/rv3hoRApOoAJ9BHXLsIuxDiOCaAFRfAZGwrDXATQCeLL3O bxtr3qz0soPRghPmtSZgOqc= =kQd1 -----END PGP SIGNATURE----- -
Aug 29, 5:05 pm 2007
Chuck Ebbert
Re: 2.6.23-rc3-mm1 - vdso and gettimeofday issues with glibc
Problem is present in stock 2.6.23-rc too. Still don't know whether it is the new glibc code or the vdso that's causing it, though. -
Aug 30, 9:27 am 2007
Pete/Piet Delaney
Re: [Kgdb-bugreport] 2.6.23-rc3-mm1: kgdb build failure ...
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Why am I getting this when I do: git clone http://master.kernel.org/pub/scm/linux/kernel/git/jwessel/linux-2.6-kgdb.git - ---------------------------------------------------------------------------- error: Couldn't get http://master.kernel.org/pub/scm/linux/kernel/git/jwessel/linux-2.6-kgdb.git/refs/tags... for tags/v2.6.11 The requested URL returned error: 404 error: Could not interpret tags/v2.6.11 as something to pull rm: cannot ...
Aug 29, 6:19 pm 2007
Lennart Sorensen
Re: Problems with IDE on linux 2.6.22.X
But isn't SATA related to SAS? And isn't SAS using SCSI commands? And if ATAPI is essentially SCSI commands, and everything other then disks use ATAPI on ATA, then that makes ATA disks the odd ball, and mangling it into line with everything else isn't that bad (since all other ATA devices are close to SCSI already). -- Len Sorensen -
Aug 30, 2:32 pm 2007
Jan Engelhardt
Re: Problems with IDE on linux 2.6.22.X
Welcome to the wonderful world of SCSIfying ATA. (Don't talk about ATAPI, USB/Firewire, it's a different matter.) Jan -- -
Aug 30, 12:31 pm 2007
Rene Herman
Re: Problems with IDE on linux 2.6.22.X
As said, if you make a bit of an effort to view the former SCSI stack as a unified storage midlayer the abberation becomes less abberational (if that's a word). Real SCSI, the other SCSI transports and ATAPI would just use more of the common mid-layer than P/SATA would. I'd expect the way forward would be to just refactor things until someone notices that drivers/scsi is the wrong place for sd.c and sr.c and moves them to drivers/block or whereever. Practically, the PATA driver gives ...
Aug 30, 2:34 pm 2007
Greg Freemyer
Re: Problems with IDE on linux 2.6.22.X
USB / Firewire / FC / iSCSI are all SCSI transports and fit within the SCSI subsystem by design. ie. Just like ethernet, DSL, T-1, etc can all carry IP traffic with no conceptual conflict, many media by design carry SCSI traffic. The PATA and SATA physical layer typically carry ATA commands and having them tied into the SCSI stack is an aberration that I hope will be eliminated some day. ATAPI is an exception. Not sure where that would end up in a perfect world. Greg -- Greg ...
Aug 30, 2:16 pm 2007
Rene Herman
Re: Problems with IDE on linux 2.6.22.X
Well -- the world where ATA, SCSI, USB, Firewire and what have you are low-level drivers to a unifying storage layer is under non too obscure definitions sort of not non-wonderful... Admittedly, the unifying layer is a little SCSI inspired but so is a lot of the hardware. As long as the users (the humans) resist SCSI inspiration, it should be safe. Rene -
Aug 30, 1:05 pm 2007
Lennart Sorensen
Re: Problems with IDE on linux 2.6.22.X
I guess eventually all disks will appear the same, just like on BSD and many other systems (probably most other systems). :) -- Len Sorensen -
Aug 30, 12:46 pm 2007
Nick Piggin
Re: [patch] fix the max path calculation in radix-tree.c
Hi Jeff, That looks really nice, thanks. No complaints from me. -
Aug 29, 6:25 pm 2007
Eric W. Biederman
Re: [PATCH] kexec: reenable HPET before kexec
Is suspend the right thing? The fact that time keeping seems to be reinventing the standard infrastructure for shutting down instead of just reusing it has me a bit confused. Regardless hooking into the shutdown is the right thing However that works. I just know that in the device tree we have shutdown methods that are called on reboot and kexec and the hpet needs one, and that is where the code belongs. I was assuming that CLOCK_EVT_MODE_SHUTDOWN just mapped to the shutdown method of ...
Aug 30, 11:04 am 2007
Konstantin Baydarov
Re: [PATCH] kexec: reenable HPET before kexec
On Thu, 30 Aug 2007 01:32:30 -0600 Eric, actually calling hpet_disable_int() under CLOCK_EVT_MODE_SHUTDOWN is not enough, because HPET might not be shutdown at all (we might want to use HPET and don't want to use LAPIC timer or in some cases HPET is used as broadcast device with LAPIC timers enabled). So, somehow, we should call hpet_set_mode with CLOCK_EVT_MODE_SHUTDOWN as an argument before machine_kexec. To solve this I've added timekeeping_shutdown() to timekeeping.c that calls ...
Aug 30, 9:07 am 2007
Eric W. Biederman
Re: [PATCH] kexec: reenable HPET before kexec
Ok. It looks like you understand this issue. Can you please try calling hpet_disable_int from hpet_set_mode under CLOCK_EVT_MODE_SHUTDOWN. I haven't traced the clock event methods all of the way through but as a first approximation I think that will get things called at the appropriate time with out needing to patch machine_kexec. Which is very much the wrong place to add call any hpet code from. We may also need to make the hpet initialization more robust so we can do something sane ...
Aug 30, 12:32 am 2007
Nick Piggin
Re: uncached page allocator
I'd just suggest Dave just registers a shrinker to start with. You really want to be able to batch TLB flushes as well, which ->releasepage may not be so good at (you could add more machinery behind the releasepage to build batches and so on, but anyway, a shrinker might be the quickest way to get something working). -- SUSE Labs, Novell Inc. -
Aug 30, 12:23 am 2007
James Pearson
Re: 4096 byte limit to /proc/PID/environ ?
There isn't that much that is duplicated - and there are also bits of the /proc/PID/mem code that are not needed in this case, so I'm not really sure if it is worth doing. I did submit a patch a few months ago - see: <http://marc.info/?l=linux-kernel&m=117862109623007&w=2> James Pearson -
Aug 30, 6:53 am 2007
Florin Iucha
Re: NFS woes again
Yup. Same here. Many startups, shuthdowns and minutes of uptime, with no observations. Check it in! Thanks, florin --=20 Bruce Schneier expects the Spanish Inquisition. http://geekz.co.uk/schneierfacts/fact/163
Aug 30, 4:14 pm 2007
Bret Towe
Re: NFS woes again
got 45min on mini before I had to go elsewhere the amd64 shutdown fine and has been up for more than 3 hours -
Aug 30, 3:18 pm 2007
Dmitry Torokhov
Re: [2.6 patch] make the dummy touchkit_ps2_detect() static
Hi Adrian, Applied, thank you. Btw, sorry for the long silence - I had a hard drive crash and the day after I restored everything the disk controller decided to die as well and write garbage all over the new disk ;( -- Dmitry -
Aug 29, 10:11 pm 2007
Kay Sievers
Re: [Hdaps-devel] [PATCH 2.6.23-rc2] hwmon: HP Mobile Da ...
Sysfs files support poll, if they are implemented that way. A driver can wake up listeners that wait in poll() for changes. http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=4508a7... Kay -
Aug 30, 12:39 pm 2007
Henrique de Moraes H ...
Re: [Hdaps-devel] [PATCH 2.6.23-rc2] hwmon: HP Mobile Da ...
I am fine with a char device that acts like /dev/rtc, but if we are doing something as heavyweight as a char device, I'd rather we go full generic netlink and send the various events over it. We'd have a netlink device that sends everything over various "channels" and just one input device that does joystick emulation, then. Can we use a simple sysfs attribute that blocks the caller on write and returns immediately on read? If it has to be more complicated than that, I'd rather we go the ...
Aug 30, 9:41 am 2007
Henrique de Moraes H ...
Re: [Hdaps-devel] [PATCH 2.6.23-rc2] hwmon: HP Mobile Da ...
We have the events that can be sent over all devices, actually (we can use button events for this). But blocking on read might indeed require a separate input device... or a file, or something like that. And we *definately* should implement something like proper select() and poll() support for the position sysfs attribute. HDAPS has also some other crap that needs to go over the input device (mouse activity, keyboard activity flags). ams and hpmdp have the "possible shock imminent" events, ...
Aug 30, 5:42 am 2007
Shem Multinymous
Re: [Hdaps-devel] [PATCH 2.6.23-rc2] hwmon: HP Mobile Da ...
In case they'll be of help for such porting, the relevant hdaps Is any of the accelerometer drivers currently capable of computing the physical acceleration? Also, is there an issue of linear vs. angular Before or after axis inversion/swapping? The tp_smapi hdaps driver (losslessly) inverts the raw data too, to avoid duplication of The term "free-fall" is dangerously misleading, for the reasons explained in the IBM APS whitepaper. Shem
Aug 29, 5:31 pm 2007
Yan Burman
Re: [Hdaps-devel] [PATCH 2.6.23-rc2] hwmon: HP Mobile Da ...
What's wrong with the stuff I did in mdps? a misc character device that I also looked at what you did in the patches as well as the modified hdapsd. I'm doing the raw input device right now in the mdps, but I have a suggestion. It seems to me that right now there are at least 3 drivers that provide the same functionality - hdaps, ams and mdps. Why not create the input device that exports raw accelerometer data with a name that is generic - something like accel/input or something along ...
Aug 30, 8:44 am 2007
Rene Herman
Re: CFS review
I didn't compare -- it no doubt will. I know the title of this thread is "CFS review" but it turned into Keith Packard noticing glxgears being broken on recent-ish X.org. The start of the thread was about things being broken using _software_ rendering though, so I thought it might be useful to remark/report glxgears also being quite broken using hardware rendering on If you're asking in a "I'll go debug the DRM" way I'll go dig a bit later (please say) but if you are only interested in ...
Aug 30, 9:48 am 2007
Ingo Molnar
Re: CFS review
and note that the schedule() call in there is not part of the crash it just happened to be on the kernel stack. Nor is the do_IRQ() entry real. Both are frequent functions (and were executed recently) that's why they were still in the stackframe. Ingo -
Aug 30, 12:20 am 2007
Chuck Ebbert
Re: CFS review
And this doesn't happen at all with the stock scheduler? (Just confirming, dev->dev_private->mmio is NULL when trying to access mmio.handle -
Aug 30, 9:06 am 2007
Rene Herman
Re: CFS review
On 08/29/2007 09:56 PM, Rene Herman wrote: Rene. -
Aug 30, 12:05 am 2007
David Howells
Re: [FIX] mntput called before dput in afs
Fine by me. Acked-By: David Howells <dhowells@redhat.com> -
Aug 30, 8:15 am 2007
David Howells
Re: [FIX] mntput called before dput in afs
From: Andreas Gruenbacher <agruen@suse.de> dput must be called before mntput here. Please consider for 2.6.24 and stable. Signed-off-by: Andreas Gruenbacher <agruen@suse.de> Acked-By: David Howells <dhowells@redhat.com> --- fs/afs/mntpt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/afs/mntpt.c +++ b/fs/afs/mntpt.c @@ -235,8 +235,8 @@ static void *afs_mntpt_follow_link(struc err = do_add_mount(newmnt, nd, MNT_SHRINKABLE, &afs_vfsmounts); switch (err) { ...
Aug 30, 8:56 am 2007
Andreas Gruenbacher
[FIX] mntput called before dput in afs
David, dput must be called before mntput here. Please consider for 2.6.24 and stable. Signed-off-by: Andreas Gruenbacher <agruen@suse.de> --- fs/afs/mntpt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/afs/mntpt.c +++ b/fs/afs/mntpt.c @@ -235,8 +235,8 @@ static void *afs_mntpt_follow_link(struc err = do_add_mount(newmnt, nd, MNT_SHRINKABLE, &afs_vfsmounts); switch (err) { case 0: - mntput(nd->mnt); dput(nd->dentry); + mntput(nd->mnt); nd->mnt = ...
Aug 30, 8:01 am 2007
Daniel Walker
Re: [PATCH 1/2] Adds full stack to critical-section tracing
These changes need some fixing .. The "struct stack_trace" infrastructure is based on CONFIG_STACKTRACE , so at least you would want to ifdef your changes on that config options .. I modified you patch to include the ifdefs, ftp://source.mvista.com/pub/dwalker/misc/debug-preempt-5-levels-of-stack-frames.patch The other problem I noticed is that the save_stack_trace(trace); seems kind of heavy weight to be calling from inside add_preempt_count. If your only going to a depth of 5 you could ...
Aug 29, 5:48 pm 2007
Stephane Eranian
Re: nmi_watchdog=2 regression in 2.6.21
Daniel, Yes, I realized I missed a small detail in the switch statement. Could you try the new version? Thanks. -- -Stephane
Aug 30, 2:05 pm 2007
Stefan Richter
Re: Who wants to maintain KR list for stable releases?
Natalie Protasevich wrote: I agree. ...to track very concrete feature-related TODO items. One Issues & Resolutions Database which I occasionally work with indeed distinguishes between "bug", "new feature", "improvement", "task", whatever that means. The type of issue is the first question one is asked when one enters a new issue. 'My' Linux kernel subsystem has a long virtual TODO list, with bugs, missing features, and other kinds of items in it. Since there is almost no personnel, ...
Aug 30, 8:24 am 2007
Daniel Walker
Re: nmi_watchdog=2 regression in 2.6.21
I tested your patch .. The system doesn't hang, but the NMI seems to disappear .. The check_nmi_watchdog() is not called, and the NMI never actually starts firing .. Is that what you had intended? Daniel -
Aug 29, 6:21 pm 2007
Adrian Bunk
Re: Who wants to maintain KR list for stable releases? ( ...
Fine with me, my point was simply that they don't belong into a Is there any reasonable query that would be possible through SQL but You need some kind of first level support that does some initial debugging and assigns the bug into the right category, and that will cu Adrian [1] there are special cases where the kernel might deliberately not some specification -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been ...
Aug 30, 1:51 am 2007
Bill Davidsen
Re: Who wants to maintain KR list for stable releases? ( ...
That's an interesting viewpoint, only programmers have useful thoughts... ignoring users, people who have CS degrees but don't code, etc. I would think there's value in any rational suggestions which include technical justification for the suggestion. -- Bill Davidsen <davidsen@tmr.com> "We have more to fear from the bungling of the incompetent than from the machinations of the wicked." - from Slashdot -
Aug 30, 8:54 am 2007
Daniel Phillips
Re: [1/1] Block device throttling [Re: Distributed storage.]
What still bothers me about your response is that, while you know the race exists and do not disagree with my example, you don't seem to see that that race can eventually lock up the block device by repeatedly It is a weakness all right. Well, - if (q && q->metric) { + if (q && q->metric && !bio->queue) { which fixes that problem. Maybe there is a better fix possible. Thanks for the catch! The original conception was that this block throttling would apply only to the highest ...
Aug 30, 4:20 pm 2007
saeed bishara
Re: [md-accel PATCH 16/19] dmaengine: driver for the iop ...
you are right, I've another question regarding the function dma_wait_for_async_tx from async_tx.c, here is the body of the code: /* poll through the dependency chain, return when tx is complete */ 1. do { 2. iter = tx; 3. while (iter->cookie == -EBUSY) 4. iter = iter->parent; 5. 6. status = dma_sync_wait(iter->chan, iter->cookie); 7. } while (status == DMA_IN_PROGRESS || (iter != tx)); assume ...
Aug 30, 11:43 am 2007
Dan Williams
Re: [md-accel PATCH 16/19] dmaengine: driver for the iop ...
You are right. There are no drivers in the tree that can hit this, but it needs to be fixed up. I'll submit the following change: diff --git a/crypto/async_tx/async_tx.c b/crypto/async_tx/async_tx.c index 0350071..bc18cbb 100644 --- a/crypto/async_tx/async_tx.c +++ b/crypto/async_tx/async_tx.c @@ -80,6 +80,7 @@ dma_wait_for_async_tx(struct dma_async_tx_descriptor *tx) { enum dma_status status; struct dma_async_tx_descriptor *iter; + struct dma_async_tx_descriptor ...
Aug 30, 1:41 pm 2007
Nigel Kukard
Re: SATA problems
Appears even with the patch provided a few months ago I'm getting freezes. Replaced the HDD & all cables, same errors ... especially whilst doing heavy IO. Can anyone shed some light? ata2.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x2 frozen ata2.00: cmd c8/00:00:9f:c9:cb/00:00:00:00:00/e1 tag 0 cdb 0x0 data 131072 in res 40/00:00:00:00:00/00:00:00:00:00/00 Emask 0x4 (timeout) ata2: soft resetting port ATA: abnormal status 0x7F on port 0x0001c807 ATA: abnormal status ...
Aug 30, 2:24 am 2007
previous daytodaynext day
August 29, 2007August 30, 2007August 31, 2007