Re: [PATCH] trivial - constify sched.h

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Jan Engelhardt <jengelh@...>
Cc: Alexey Dobriyan <adobriyan@...>, Joe Perches <joe@...>, Ingo Molnar <mingo@...>, <linux-kernel@...>, <kernel-janitors@...>
Date: Thursday, August 30, 2007 - 5:21 pm

On Thu, 30 Aug 2007, Jan Engelhardt wrote:

You've completely missed the point -- it is _plausible_ that callers
(even if just _one_) have const timespec/timeval structs, which is why
that commit made sense as I mentioned above (to shut up the warning that
would otherwise occur). This does not hold true for the sched.h / struct
task_struct case here -- I cannot imagine a const task_struct.


Going about const-ifying such function arguments as in here (for the sake
of type safety, where the function does not modify that argument), could
easily lead to *zillions* of patches such as this which would have
absolutely _zero_ impact on the actual kernel that gets built.

As I said, if someone really wants to do this, please go about constifying
_data_ instead -- that would make a (positive) difference.
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] trivial - constify sched.h, Joe Perches, (Mon Aug 27, 4:40 pm)
Re: [PATCH] trivial - constify sched.h, Alexey Dobriyan, (Mon Aug 27, 5:33 pm)
Re: [PATCH] trivial - constify sched.h, Jan Engelhardt, (Thu Aug 30, 3:24 pm)
Re: [PATCH] trivial - constify sched.h, Satyam Sharma, (Thu Aug 30, 4:41 pm)
Re: [PATCH] trivial - constify sched.h, Jan Engelhardt, (Thu Aug 30, 4:55 pm)
Re: [PATCH] trivial - constify sched.h, Christoph Hellwig, (Fri Aug 31, 9:53 am)
Re: [PATCH] trivial - constify sched.h, Matthew Wilcox, (Fri Aug 31, 10:03 am)
Re: [PATCH] trivial - constify sched.h, Satyam Sharma, (Thu Aug 30, 5:21 pm)
Re: [PATCH] trivial - constify sched.h, Jiri Slaby, (Mon Aug 27, 4:59 pm)