On Thu, Aug 30, 2007 at 11:06:38AM -0400, Jeff Layton wrote:
quoted text > Make notify_change not clear the ATTR_KILL_S*ID bits in the ia_vaid that
> gets passed to the setattr inode operation. This allows the filesystems
> to reinterpret whether this mode change is simply intended to clear the
> setuid/setgid bits.
>
> This means that notify_change should never be called with both ATTR_MODE
> and either of the ATTR_KILL_S*ID bits set, since the filesystem would
> have no way to know what part of the mode change was intentional. If
> it is called this way, consider it a BUG().
This one looks fine to, but you'll probably need an additional patch
to ecryptfs so it clears ATTR_MODE before calling notify_change for
the lower inode.
-
unsubscribe notice To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/ Messages in current thread:
Re: [PATCH 1/3] VFS: make notify_change pass ATTR_KILL_S*I ... , Christoph Hellwig , (Thu Aug 30, 9:33 am)
