On 2007.08.29 10:49:12 -0700, Christoph Lameter wrote:
quoted text
> On Wed, 29 Aug 2007, Peter Lund wrote:
> 
> >  
> > -	if (tmp >= RADIX_TREE_INDEX_BITS)
> > -		index = ~0UL;
> > -	return index;
> > +	if (shift < 0)
> > +		return ~0UL;
> > +	if (shift >= 8 * sizeof(unsigned long))
> 
> 8* sizeof(unsigned long) is the constant BITS_PER_LONG.

Or in this context: RADIX_TREE_INDEX_BITS, which happens to be the old
check, which just needed to be extended to cover negative shifts.

Björn
-
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/