Andrew Morton wrote: I'll take a look at this right away. Thanks, Mike -

Hi, I can't find anything guaranteeing that 'ubi_num' cannot be <0 in drivers/mtd/ubi/kapi.c::ubi_open_volume(), and in fact the code even tests for that and errors out if so. Unfortunately the test for "ubi_num < 0" happens after we've already used 'ubi_num' as an array index - bad thing to do if it is negative. This patch moves the test earlier in the function and then moves the indexing using that variable after the check. A bit safer :-) Signed-off-by: Jesper Juhl <jesper.ju...

This makes powerpc64's compat code use the new linux/elfcore-compat.h, reducing some hand-copied duplication. Signed-off-by: Roland McGrath <roland@redhat.com> --- arch/powerpc/kernel/binfmt_elf32.c | 67 ++++++++++++++++------------------- include/asm-powerpc/elf.h | 38 +++++++++++---------- 2 files changed, 51 insertions(+), 54 deletions(-) diff --git a/arch/powerpc/kernel/binfmt_elf32.c b/arch/powerpc/kernel/binfmt_elf32.c index 5cb5875..1d45d77 100644 --- a/arch/power...

That driver will have to be updated to reinitialize the card properly after resume.. Have you reported this to the ALSA people? -- Robert Hancock Saskatoon, SK, Canada To email, remove "nospam" from hancockr@nospamshaw.ca Home Page: http://www.roberthancock.com/ -

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=250859 at line 74: muli@62829: muli@62829: sd = bus->sysdata; muli@62829: sd->node = node; <===== bus->sysdata is NULL. Last changed by this hunk of "x86-64: introduce struct pci_sysdata to facilitate sharing of ->sysdata": @@ -67,7 +69,9 @@ fill_mp_bus_to_cpumask(void) continue; if (!node_online(node)) node = 0; - bus->sysdata = (void *)node; + + sd = bus->sysdata; + ...

From: Rafael J. Wysocki <rjw@sisk.pl> Dependencies of CONFIG_SUSPEND and CONFIG_HIBERNATION introduced by commit 296699de6bdc717189a331ab6bbe90e05c94db06 "Introduce CONFIG_SUSPEND for suspend-to-Ram and standby" are incorrect, as they don't cover the facts that (1) not all architectures support suspend and (2) SMP hibernation is only possible on X86 and PPC64 (if PPC64_SWSUSP is set). Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl> --- kernel/power/Kconfig | 9 ++++++--- 1 file c...

I did it symmetrically for suspend and hibernation and renamed SUSPEND_SMP to PM_SLEEP_SMP. Patch follows. Greetings, Rafael --- From: Rafael J. Wysocki <rjw@sisk.pl> Dependencies of CONFIG_SUSPEND and CONFIG_HIBERNATION introduced by commit 296699de6bdc717189a331ab6bbe90e05c94db06 "Introduce CONFIG_SUSPEND for suspend-to-Ram and standby" are incorrect, as they don't cover the facts that (1) not all architectures support suspend and (2) SMP hibernation is only possible on X86 an...

There is a couple of subtle checks which were needed to handle ptracing from the same thread group. This was deprecated a long ago, imho this code just complicates the understanding. And, the "->parent->signal->flags & SIGNAL_GROUP_EXIT" check in exit_notify() is not right. SIGNAL_GROUP_EXIT can mean exec(), not exit_group(). This means ptracer can lose a ptraced zombie on exec(). Minor problem, but still the bug. Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru> --- t/kernel/ex...

This means that changelog is wrong and should be changed. However, I disagree. exit_notify() doesn't check the ptrace-same-group case. So, unless I missed something, we set EXIT_DEAD in any case, even if ptracer doesn't belong to our thread group. No? Oleg. -

From: George G. Davis <gdavis@mvista.com> Fix local_irq_* macro definition errors for the !TRACE_IRQFLAGS_SUPPORT case in which the macros are errantly "redefined" rather than defined. Signed-off-by: George G. Davis <gdavis@mvista.com> diff --git a/include/linux/irqflags.h b/include/linux/irqflags.h index 412e025..49a3df8 100644 --- a/include/linux/irqflags.h +++ b/include/linux/irqflags.h @@ -67,10 +67,10 @@ * The local_irq_*() APIs are equal to the raw_local_irq*() * if !TR...

Good day, recently I've been trying to get working PCMCIA interface on H5000 ipaq series, using dual PCMCIA sleeve. So far things work correctly, but I had to do one modification to drivers/pcmcia/pxa2xx_base.c to get the interface working with orinoco gold PCMCIA card (wired pcnet_cs ethernet card worked even without this modification). Patch attached. The issue has something to do with assert time on PCMCIA bus, but I'm not really sure what -- I found the working value just by trial&e...

From: Miklos Szeredi <mszeredi@suse.cz> The VFS checks sticky bits on the parent directory even if the filesystem defines it's own ->permission(). In some situations (sshfs, mountlo, etc) the user does have permission to delete a file even if the attribute based checking would not allow it. So work around this by storing the permission bits separately and returning them in stat(), but cutting the permission bits off from inode->i_mode. This is slightly hackish, but it's probably n...

The combination of CPU hotplug and PREEMPT_RCU has resulted in deadlocks due to the migration-based implementation of synchronize_sched() in -rt. This experimental patch maps synchronize_sched() back onto Classic RCU, eliminating the migration, thus hopefully also eliminating the deadlocks. It is not clear that this is a good long-term approach, but it will at least permit people doing CPU hotplug in -rt kernels additional wiggle room in their design and implementation. The basic approach is to cau...

Hi, I have prepared a patch that makes request_firmware skip the usual grace period that it gives firmware images to show up, if it determines that userspace was not notified at all. When request_firmware is called, it sends an event to userspace to ask for the firmware image that is needed, and then it installs a timeout so that it will not wait forever for the image. However, if userspace did not receive the event at all (no /sbin/hotplug, for instance), then having the kernel wait is pointles...

Acked-by: Josh Triplett <josh@kernel.org> -

I have pending patches to key the NF5 case on the PCI-ID, but that obviously cannot be done for NF4. I cannot think of anything good but putting DMI BIOS version We don't really know which pins are connected where. This means they likely have some bits they tweaked to get the different behaviour, but they're unknown. There are also some northbridge bits that can be tweaked (e.g. some of the ATI BIOS workarounds used to use that) but it's still unknown what the Nvidia chipset actually does a...

My guess is that they changed some bits outside the DSDT. But ok There is some flexibility in how the interrupt gets delivered, since it gets converted to a HT message and the Northbridge has a few tweaks for processing those. -Andi -

Hi, The main point is still that these are two _different_ APIs for different usages, so I still prefer to add a hrsleep() instead. bye, Roman -

Hi, Actually the hrsleep() function would allow for submillisecond sleeps, which might be what some of the 450 users really want and they only use msleep(1) because it's the next best thing. A hrsleep() function is really what makes most sense from an API perspective. bye, Roman -

still looks good to me. Acked-by: Ingo Molnar <mingo@elte.hu> Ingo -

This is really nice. Maybe make it configurable, though? -

Hi! SysV code returns EIDRM for collision of IDs. I sure it should return EINVAL. Steps to reproduce: (this for shared memory code, for msg/sem it is the same) 1. Create then drop 2 shmem segments, then create a third. 2. Try to shmctl(IPC_STAT) the two now-invalid shm IDs. 3. Note error codes returned. One call gives EINVAL, one gives EIDRM due to collision with the third shmem segment. Should both give EINVAL, this is what I've got on every other Unix I've tried it on. ...

From: Miklos Szeredi <mszeredi@suse.cz> Don't set 'aborted' flag on a request if it's interrupted. We have to wait for the answer anyway, and this would only a very little time while copying the reply. This means, that write() on the fuse device will not return -ENOENT during normal operation, only if the filesystem is aborted by a forced umount or through the fusectl interface. This could simplify userspace code somewhat when backward compatibility with earlier kernel versions is not r...

From: Miklos Szeredi <mszeredi@suse.cz> The VFS checks sticky bits on the parent directory even if the filesystem defines it's own ->permission(). In some situations (sshfs, mountlo, etc) the user does have permission to delete a file even if the attribute based checking would not allow it. So work around this by storing the permission bits separately and returning them in stat(), but cutting the permission bits off from inode->i_mode. This is slightly hackish, but it's probably n...

From: Miklos Szeredi <mszeredi@suse.cz> fuse_permission() didn't refresh inode attributes before using them, even if the validity has already expired. Thanks to Junjiro Okajima for spotting this. Also remove some old code to unconditionally refresh the attributes on the root inode. Signed-off-by: Miklos Szeredi <mszeredi@suse.cz> --- Index: linux/fs/fuse/dir.c =================================================================== --- linux.orig/fs/fuse/dir.c 2007-08-03 18:36:01....