login
Login
/
Register
Search
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2007
»
August
»
3
Re: [patch 08/11] fuse: fix permission checking on sticky directories
view
thread
!MAILaRCHIVE_VOTE_RePLACE
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
[view in full thread]
From:
Jan Engelhardt <jengelh@...>
To: Miklos Szeredi <miklos@...>
Cc: <akpm@...>, <linux-kernel@...>
Subject:
Re: [patch 08/11] fuse: fix permission checking on sticky directories
Date: Friday, August 3, 2007 - 2:20 pm
On Aug 3 2007 19:44, Miklos Szeredi wrote:
quoted text
>--- linux.orig/fs/fuse/fuse_i.h 2007-08-03 18:36:15.000000000 +0200 >+++ linux/fs/fuse/fuse_i.h 2007-08-03 18:36:17.000000000 +0200 >@@ -63,6 +63,10 @@ struct fuse_inode { > > /** Time in jiffies until the file attributes are valid */ > u64 i_time; >+ >+ /** The sticky bit in inode->i_mode may have been remved, so
^ may have been removed.
quoted text
>+ preserve the original mode */ >+ mode_t orig_i_mode; > }; > > /** FUSE specific file data */ >Index: linux/fs/fuse/inode.c >=================================================================== >--- linux.orig/fs/fuse/inode.c 2007-08-03 18:36:14.000000000 +0200 >+++ linux/fs/fuse/inode.c 2007-08-03 18:36:37.000000000 +0200 >@@ -120,10 +120,18 @@ static void fuse_truncate(struct address > void fuse_change_attributes(struct inode *inode, struct fuse_attr *attr) > { > struct fuse_conn *fc = get_fuse_conn(inode); >+ struct fuse_inode *fi = get_fuse_inode(inode); > loff_t oldsize; > > inode->i_ino = attr->ino; >- inode->i_mode = (inode->i_mode & S_IFMT) + (attr->mode & 07777); >+ fi->orig_i_mode = (inode->i_mode & S_IFMT) + (attr->mode & 07777);
Although it does not matter in this case, | is safer (and perhaps faster?). Jan -- -
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
Messages in current thread:
[patch 08/11] fuse: fix permission checking on sticky direct...
, Miklos Szeredi
, (Fri Aug 3, 1:44 pm)
Re: [patch 08/11] fuse: fix permission checking on sticky di...
, Jan Engelhardt
, (Fri Aug 3, 2:20 pm)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Andrew Morton
-mm merge plans for 2.6.23
Greg KH
[GIT PATCH] driver core patches against 2.6.24
Bart Van Assche
Integration of SCST in the mainstream Linux kernel
david
Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
openbsd-misc
:
linux-netdev
:
Jarek Poplawski
[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Gerrit Renker
[PATCH 03/37] dccp: List management for new feature negotiation
Arjan van de Ven
Re: [GIT]: Networking
Auke Kok
[PATCH] e1000e: test MSI interrupts
git
:
Colocation donated by:
Who's online
There are currently
3 users
and
973 guests
online.
Online users
zeekec
ceramicchristma
ceramicchristma
Syndicate