Home » Mailing list archives » linux-kernel » 2007 » August » 29

[PATCH] Remove write-only variable from pktgen_thread

Previous thread: [PATCH] Use same_thread_group() in signalfd.c by Pavel Emelyanov on Wednesday, August 29, 2007 - 9:19 am. (2 messages)

Next thread: speeding up swapoff by Daniel Drake on Wednesday, August 29, 2007 - 9:29 am. (15 messages)
[view original message]
From: Pavel Emelyanov <xemul@...>
To: Andrew Morton <akpm@...>
Cc: Oleg Nesterov <oleg@...>, Sukadev Bhattiprolu <sukadev@...>, Linux Containers <containers@...>, Linux Kernel Mailing List <linux-kernel@...>, Linux Netdev List <netdev@...>
Subject: [PATCH] Remove write-only variable from pktgen_thread
Date: Wednesday, August 29, 2007 - 9:22 am

The pktgen_thread.pid is set to current->pid and is never used

after this. So remove this at all.


Found during isolating the explicit pid/tgid usage.


Signed-off-by: Pavel Emelyanov <xemul@openvz.org>


---


diff --git a/net/core/pktgen.c b/net/core/pktgen.c

index 3a3154e..93695c2 100644

--- a/net/core/pktgen.c

+++ b/net/core/pktgen.c

@@ -380,7 +380,6 @@ struct pktgen_thread {

 	/* Field for thread to receive "posted" events terminate, stop ifs etc. */


 	u32 control;

-	int pid;

 	int cpu;


 	wait_queue_head_t queue;

@@ -3462,8 +3461,6 @@ static int pktgen_thread_worker(void *ar


 	init_waitqueue_head(&t->queue);


-	t->pid = current->pid;

-

 	pr_debug("pktgen: starting pktgen/%d:  pid=%d\n", cpu, task_pid_nr(current));


 	max_before_softirq = t->max_before_softirq;

-
[view original message]
From: <sukadev@...>
To: Pavel Emelyanov <xemul@...>
Cc: Andrew Morton <akpm@...>, Oleg Nesterov <oleg@...>, Linux Containers <containers@...>, Linux Kernel Mailing List <linux-kernel@...>, Linux Netdev List <netdev@...>
Subject: Re: [PATCH] Remove write-only variable from pktgen_thread
Date: Wednesday, August 29, 2007 - 5:33 pm

Pavel Emelianov [xemul@openvz.org] wrote:

| The pktgen_thread.pid is set to current->pid and is never used

| after this. So remove this at all.

|

| Found during isolating the explicit pid/tgid usage.

|

| Signed-off-by: Pavel Emelyanov <xemul@openvz.org>


Good observation that its not being used :-)


Acked-by: Sukadev Bhattiprolu <sukadev@us.ibm.com>

|

| ---

|

| diff --git a/net/core/pktgen.c b/net/core/pktgen.c

| index 3a3154e..93695c2 100644

| --- a/net/core/pktgen.c

| +++ b/net/core/pktgen.c

| @@ -380,7 +380,6 @@ struct pktgen_thread {

| 	/* Field for thread to receive "posted" events terminate, stop ifs

| 	etc. */

|

| 	u32 control;

| -	int pid;

| 	int cpu;

|

| 	wait_queue_head_t queue;

| @@ -3462,8 +3461,6 @@ static int pktgen_thread_worker(void *ar

|

| 	init_waitqueue_head(&t->queue);

|

| -	t->pid = current->pid;

| -

| 	pr_debug("pktgen: starting pktgen/%d:  pid=%d\n", cpu,

| 	task_pid_nr(current));

|

| 	max_before_softirq = t->max_before_softirq;

-
[view original message]
From: David Miller <davem@...>
To: <sukadev@...>
Cc: <xemul@...>, <akpm@...>, <oleg@...>, <containers@...>, <linux-kernel@...>, <netdev@...>
Subject: Re: [PATCH] Remove write-only variable from pktgen_thread
Date: Friday, August 31, 2007 - 1:46 am

From: sukadev@us.ibm.com


Patch applied, thanks.

-
Previous thread: [PATCH] Use same_thread_group() in signalfd.c by Pavel Emelyanov on Wednesday, August 29, 2007 - 9:19 am. (2 messages)

Next thread: speeding up swapoff by Daniel Drake on Wednesday, August 29, 2007 - 9:29 am. (15 messages)