Home » Mailing list archives » linux-kernel » 2007 » August » 29

[PATCH] Remove write-only variable from pktgen_thread

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Pavel Emelyanov <xemul@...>
To: Andrew Morton <akpm@...>
Cc: Oleg Nesterov <oleg@...>, Sukadev Bhattiprolu <sukadev@...>, Linux Containers <containers@...>, Linux Kernel Mailing List <linux-kernel@...>, Linux Netdev List <netdev@...>
Subject: [PATCH] Remove write-only variable from pktgen_thread
Date: Wednesday, August 29, 2007 - 9:22 am

The pktgen_thread.pid is set to current->pid and is never used
after this. So remove this at all.

Found during isolating the explicit pid/tgid usage.

Signed-off-by: Pavel Emelyanov <xemul@openvz.org>

---

diff --git a/net/core/pktgen.c b/net/core/pktgen.c
index 3a3154e..93695c2 100644
--- a/net/core/pktgen.c
+++ b/net/core/pktgen.c
@@ -380,7 +380,6 @@ struct pktgen_thread {
 	/* Field for thread to receive "posted" events terminate, stop ifs etc. */
 
 	u32 control;
-	int pid;
 	int cpu;
 
 	wait_queue_head_t queue;
@@ -3462,8 +3461,6 @@ static int pktgen_thread_worker(void *ar
 
 	init_waitqueue_head(&t->queue);
 
-	t->pid = current->pid;
-
 	pr_debug("pktgen: starting pktgen/%d:  pid=%d\n", cpu, task_pid_nr(current));
 
 	max_before_softirq = t->max_before_softirq;
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] Remove write-only variable from pktgen_thread, Pavel Emelyanov, (Wed Aug 29, 9:22 am)
Re: [PATCH] Remove write-only variable from pktgen_thread, , (Wed Aug 29, 5:33 pm)
Re: [PATCH] Remove write-only variable from pktgen_thread, David Miller, (Fri Aug 31, 1:46 am)