tried that one on my old toshiba tecra 8000 laptop, almost killing it.
the fan doesn't work any more...type 'make' and see the box dying.
luckily my CPU doesn't commit suicide...bisected it to that one:

cd8c93a4e04dce8f00d1ef3a476aac8bd65ae40b is first bad commit
commit cd8c93a4e04dce8f00d1ef3a476aac8bd65ae40b
Author: Alexey Starikovskiy <astarikovskiy@suse.de>
Date:   Fri Aug 3 17:52:48 2007 -0400

    ACPI: EC: If ECDT is not found, look up EC in DSDT.

    Some ASUS laptops access EC space from device _INI methods, but do not
    provide ECDT for early EC setup. In order to make them function properly,
    there is a need to find EC is DSDT before any _INI is called.

    Similar functionality was turned on by acpi_fake_ecdt=1 command line
    before. Now it is on all the time.

    http://bugzilla.kernel.org/show_bug.cgi?id=8598

    Signed-off-by: Alexey Starikovskiy <astarikovskiy@suse.de>
    Signed-off-by: Len Brown <len.brown@intel.com>
-

[ message continues ]

Len? Should we just revert it?

That commit has been very painful. First it lost all registration of the 
query methods, and now this.

Daniel - can we please have a before/after dmesg on your machine, 
preferably with ACPI debugging enabled? And for ACPI stuff, it usually 
does help to fill in a bugzilla entry, since the ACPI people actually do 
track things there...

		Linus

-

[ message continues ]

Daniel,
Does this patch help you, or do we need to revert the whole thing?

Sorry for the trouble,
Alex.

[ message continues ]

yes, this does the trick. the fan goes on again. thanks.
if you still need additional debug output or if you want me to test
a different patch just let me know.

rgds


-

[ message continues ]

If you could open a bugreport at bugzilla.kernel.org in ACPI category
and attach
dmesg and acpidump output, that would help a lot. (I hope :( )

Thanks,
Alex.


-

[ message continues ]

-

[ message continues ]

I've just bisected down to the same commit. In my case the fan is locked
at maximum speed and the system is *extremly* slow (some kind of
throttling?).

Alexey, I've seen the patch, I'll test it tomorrow and report back.

Luca
-- 
Tentare e` il primo passo verso il fallimento.
Homer J. Simpson
-

[ message continues ]

i've just tested the minimal fix here:
	http://bugzilla.kernel.org/show_bug.cgi?id=8958#c7

rgds
-daniel


-

[ message continues ]

Alexey, Len, can we get this fix integrated asap?

		Linus
-

[ message continues ]

Tested here, works fine.

Luca
-

[ message continues ]

From: Alexey Starikovskiy <astarikovskiy@suse.de>

acpi_get_devices() returns success if it did not find any device.
We have to check for this case.

Signed-off-by: Alexey Starikovskiy <astarikovskiy@suse.de>
---

 drivers/acpi/ec.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
index 43749c8..3f7935a 100644
--- a/drivers/acpi/ec.c
+++ b/drivers/acpi/ec.c
@@ -886,7 +886,8 @@ int __init acpi_ec_ecdt_probe(void)
         printk(KERN_DEBUG PREFIX "Look up EC in DSDT\n");
         status = acpi_get_devices(ec_device_ids[0].id, ec_parse_device,
                         boot_ec, NULL);
-        if (ACPI_FAILURE(status))
+        /* Check that acpi_get_devices actually find something */
+        if (ACPI_FAILURE(status) || !boot_ec->handle)
             goto error;
     }
 

-

[ message continues ]

This was totally whitespace-damaged. You have some broken email client 
that turns <tab>s into four spaces.

May I suggest rethinking the use of Thunderbird (aka "mangles things 
ridiculously")?

Anyway, I fixed it up and applied it.

		Linus
-

[ message continues ]

Thanks, what client do you use/recommend?

Alex.
-

[ message continues ]

I use sylpheed.  thunderbird can be used, but one needs to follow
the steps in http://mbligh.org/linuxdocs/Email/Clients/Thunderbird
to get it out of i-know-better mode.
-

[ message continues ]

Thanks. I seem to have missed that Thunderbird has compose preference
different for each mail account. 

-

[ message continues ]

Can we get something like this into the kernel tree, please?

Documentation/email-clients.txt would go a long way towards making our 
collective lives more simple.

	Jeff


-

[ message continues ]