On Sun, Aug 26, 2007 at 06:55:42AM -0600, Matthew Wilcox wrote:
quoted text
> On Sat, Aug 25, 2007 at 10:24:57PM -0600, Robert Hancock wrote:
> > We've already got a patch for this in Greg's PCI tree, hopefully it 
> > should go in for 2.6.24.
> 
> I haven't seen it.  I guess it wasn't sent to the PCI mailing list.
> 
> Your patch had two or three problems with it; assuming we're talking
> about the same patch.

I found
http://git.kernel.org/?p=linux/kernel/git/gregkh/patches.git;a=blob;f=pci/pci-disable-...

which has two problems:

 - With a 64-bit BAR, it checks to see if the upper 32 bits represent IO
   or memory.  You can't do that to the upper 32 bits.
 - It does a lot of additional writes to the cmd register; my patch does two
   writes per device; yours does two per BAR

It's also a lot more complex than my patch, IMO.

Greg, please drop Robert's patch and put mine in instead.

-- 
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."
-
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/