Re: CFS review

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Ingo Molnar
Date: Friday, August 24, 2007 - 6:45 am

* Al Boldi <a1426z@gawab.com> wrote:


ok. I think i might finally have found the bug causing this. Could you 
try the fix below, does your webserver thread-startup test work any 
better?

	Ingo

--------------------------->
Subject: sched: fix startup penalty calculation
From: Ingo Molnar <mingo@elte.hu>

fix task startup penalty miscalculation: sysctl_sched_granularity is
unsigned int and wait_runtime is long so we first have to convert it
to long before turning it negative ...

Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 kernel/sched_fair.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux/kernel/sched_fair.c
===================================================================
--- linux.orig/kernel/sched_fair.c
+++ linux/kernel/sched_fair.c
@@ -1048,7 +1048,7 @@ static void task_new_fair(struct rq *rq,
 	 * -granularity/2, so initialize the task with that:
 	 */
 	if (sysctl_sched_features & SCHED_FEAT_START_DEBIT)
-		p->se.wait_runtime = -(sysctl_sched_granularity / 2);
+		p->se.wait_runtime = -((long)sysctl_sched_granularity / 2);
 
 	__enqueue_entity(cfs_rq, se);
 }
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: CFS review, Al Boldi, (Sat Aug 11, 3:44 am)
Re: CFS review, Ingo Molnar, (Sat Aug 11, 9:17 pm)
Re: CFS review, Al Boldi, (Sun Aug 12, 8:27 am)
Re: CFS review, Ingo Molnar, (Sun Aug 12, 8:52 am)
Re: CFS review, Al Boldi, (Sun Aug 12, 12:43 pm)
Re: CFS review, Ingo Molnar, (Tue Aug 21, 3:58 am)
Re: CFS review, Al Boldi, (Tue Aug 21, 3:27 pm)
Re: CFS review, Ingo Molnar, (Fri Aug 24, 6:45 am)
Re: CFS review, Al Boldi, (Sat Aug 25, 3:27 pm)
Re: CFS review, Ingo Molnar, (Sat Aug 25, 4:15 pm)
Re: CFS review, Al Boldi, (Sun Aug 26, 9:27 am)
Re: CFS review, Ingo Molnar, (Sun Aug 26, 9:39 am)
Re: CFS review, Al Boldi, (Sun Aug 26, 9:06 pm)
Re: CFS review, Ingo Molnar, (Mon Aug 27, 3:53 am)
Re: CFS review, Al Boldi, (Mon Aug 27, 7:46 am)
Re: CFS review, Ingo Molnar, (Mon Aug 27, 1:41 pm)
Re: CFS review, Al Boldi, (Mon Aug 27, 9:37 pm)
Re: CFS review, Linus Torvalds, (Mon Aug 27, 10:05 pm)
Re: CFS review, Al Boldi, (Mon Aug 27, 10:23 pm)
Re: CFS review, Mike Galbraith, (Tue Aug 28, 12:28 am)
Re: CFS review, Ingo Molnar, (Tue Aug 28, 12:36 am)
Re: CFS review, Xavier Bestel, (Tue Aug 28, 12:43 am)
Re: CFS review, Ingo Molnar, (Tue Aug 28, 1:02 am)
Re: CFS review, Linus Torvalds, (Tue Aug 28, 9:34 am)
Re: CFS review, Arjan van de Ven, (Tue Aug 28, 9:44 am)
Re: CFS review, Ingo Molnar, (Tue Aug 28, 9:45 am)
Re: CFS review, Willy Tarreau, (Tue Aug 28, 12:19 pm)
Re: CFS review, Ingo Molnar, (Tue Aug 28, 12:55 pm)
Re: CFS review, Valdis.Kletnieks, (Tue Aug 28, 1:46 pm)
Re: CFS review, Bill Davidsen, (Tue Aug 28, 8:37 pm)
Re: CFS review, Bill Davidsen, (Tue Aug 28, 8:42 pm)
Re: CFS review, Ingo Molnar, (Tue Aug 28, 8:45 pm)
Re: CFS review, Ingo Molnar, (Tue Aug 28, 9:18 pm)
Re: CFS review, Al Boldi, (Tue Aug 28, 9:19 pm)
Re: CFS review, Keith Packard, (Tue Aug 28, 9:29 pm)
Re: CFS review, Mike Galbraith, (Tue Aug 28, 9:40 pm)
Re: CFS review, Ingo Molnar, (Tue Aug 28, 9:46 pm)
Re: CFS review, Ingo Molnar, (Tue Aug 28, 9:53 pm)
Re: CFS review, Al Boldi, (Tue Aug 28, 10:58 pm)
Re: CFS review, Ingo Molnar, (Tue Aug 28, 11:43 pm)
Re: CFS review, Keith Packard, (Wed Aug 29, 12:57 am)
Re: CFS review, Ingo Molnar, (Wed Aug 29, 1:04 am)
Re: CFS review, Al Boldi, (Wed Aug 29, 1:53 am)
Re: CFS review, Bill Davidsen, (Wed Aug 29, 6:11 am)
Re: CFS review, Keith Packard, (Wed Aug 29, 8:57 am)
Re: CFS review, Rene Herman, (Wed Aug 29, 12:56 pm)
Re: CFS review, Rene Herman, (Thu Aug 30, 12:05 am)
Re: CFS review, Ingo Molnar, (Thu Aug 30, 12:20 am)
Re: CFS review, Chuck Ebbert, (Thu Aug 30, 9:06 am)
Re: CFS review, Rene Herman, (Thu Aug 30, 9:48 am)
Re: CFS review, Tilman Sauerbeck, (Thu Aug 30, 11:46 pm)
DRM and/or X trouble (was Re: CFS review), Rene Herman, (Fri Aug 31, 3:44 am)
Re: DRM and/or X trouble, Satyam Sharma, (Fri Aug 31, 7:55 am)