On Friday 24 August 2007 00:52, Jesper Juhl wrote:
quoted text
> kmalloc() returns a void pointer.
> No need to cast it.

quoted text
> -	msp_flash = (struct mtd_info **)kmalloc(
> -			fcnt * sizeof(struct map_info *), GFP_KERNEL);
> -	msp_parts = (struct mtd_partition **)kmalloc(
> -			fcnt * sizeof(struct mtd_partition *), GFP_KERNEL);
> -	msp_maps = (struct map_info *)kmalloc(
> -			fcnt * sizeof(struct mtd_info), GFP_KERNEL);
> +	msp_flash = kmalloc(fcnt * sizeof(struct map_info *), GFP_KERNEL);
> +	msp_parts = kmalloc(fcnt * sizeof(struct mtd_partition *), GFP_KERNEL);
> +	msp_maps = kmalloc(fcnt * sizeof(struct mtd_info), GFP_KERNEL);
>  	memset(msp_maps, 0, fcnt * sizeof(struct mtd_info));

This one wants kzalloc.

quoted text
> -		msp_parts[i] = (struct mtd_partition *)kmalloc(
> -			pcnt * sizeof(struct mtd_partition), GFP_KERNEL);
> +		msp_parts[i] = kmalloc(pcnt * sizeof(struct mtd_partition),
> +			GFP_KERNEL);
>  		memset(msp_parts[i], 0, pcnt * sizeof(struct mtd_partition));
>
>  		/* now initialize the devices proper */

Same
--
vda
-
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/