[PATCH] clean up exports in fs/{open,read_write}.c

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <linux-kernel@...>
Cc: Takashi Iwai <tiwai@...>, Arjan van de Ven <arjan@...>, Christoph Hellwig <hch@...>
Date: Thursday, August 23, 2007 - 11:33 pm

Takashi-san fixed sound/isa/wavefront/wavefront_synth.c to use
request_firmware instead of sys_*. Since that is the last driver in the
kernel that uses sys_{read,close}, this patch kills these exports. sys_open
is left exported for sparc64 only.

Cc: Takashi Iwai <tiwai@suse.de>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Arjan van de Ven <arjan@linux.intel.com>
Signed-off-by: Eugene Teo <eugeneteo@kernel.sg>
---
 fs/open.c       |    4 ++--
 fs/read_write.c |    1 -
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/fs/open.c b/fs/open.c
index 1d9e5e9..dc121ce 100644
--- a/fs/open.c
+++ b/fs/open.c
@@ -1056,7 +1056,9 @@ asmlinkage long sys_open(const char __user *filename, int flags, int mode)
 	prevent_tail_call(ret);
 	return ret;
 }
+#ifdef CONFIG_SPARC64
 EXPORT_SYMBOL_GPL(sys_open);
+#endif
 
 asmlinkage long sys_openat(int dfd, const char __user *filename, int flags,
 			   int mode)
@@ -1148,8 +1150,6 @@ out_unlock:
 	return -EBADF;
 }
 
-EXPORT_SYMBOL(sys_close);
-
 /*
  * This routine simulates a hangup on the tty, to arrange that users
  * are given clean terminals at login time.
diff --git a/fs/read_write.c b/fs/read_write.c
index 507ddff..d913d1e 100644
--- a/fs/read_write.c
+++ b/fs/read_write.c
@@ -370,7 +370,6 @@ asmlinkage ssize_t sys_read(unsigned int fd, char __user * buf, size_t count)
 
 	return ret;
 }
-EXPORT_SYMBOL_GPL(sys_read);
 
 asmlinkage ssize_t sys_write(unsigned int fd, const char __user * buf, size_t count)
 {

-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] clean up exports in fs/{open,read_write}.c, Eugene Teo, (Thu Aug 23, 11:33 pm)
Re: [PATCH] clean up exports in fs/{open,read_write}.c, Adrian Bunk, (Mon Aug 27, 7:16 pm)
Re: [PATCH] clean up exports in fs/{open,read_write}.c, Christoph Hellwig, (Mon Aug 27, 5:37 pm)
Re: [PATCH] clean up exports in fs/{open,read_write}.c, Arjan van de Ven, (Mon Aug 27, 6:49 pm)
Re: [PATCH] clean up exports in fs/{open,read_write}.c, Christoph Hellwig, (Tue Aug 28, 8:26 am)