[PATCH] Redefine register_hotcpu_notifier() !HOTPLUG_CPU stub as static inline function

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Andrew Morton <akpm@...>
Cc: Linux Kernel Mailing List <linux-kernel@...>
Date: Wednesday, August 22, 2007 - 6:47 pm

The present do {} while stub's return cannot be checked, but the real
HOTPLUG_CPU=y implementation of register_hotcpu_notifier() is int-
returning. So let us make this stub consistent with the full version.
Redefining this as such will also help us remove some #ifdef-ery
elsewhere in kernel code, as shown in forthcoming patch.

Signed-off-by: Satyam Sharma <satyam@infradead.org>

---

 include/linux/cpu.h |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/include/linux/cpu.h b/include/linux/cpu.h
index 1d5ded0..ed6fa22 100644
--- a/include/linux/cpu.h
+++ b/include/linux/cpu.h
@@ -119,7 +119,10 @@ static inline void cpuhotplug_mutex_unlock(struct mutex *cpu_hp_mutex)
 #define lock_cpu_hotplug()	do { } while (0)
 #define unlock_cpu_hotplug()	do { } while (0)
 #define hotcpu_notifier(fn, pri)	do { (void)(fn); } while (0)
-#define register_hotcpu_notifier(nb)	do { (void)(nb); } while (0)
+static inline int register_hotcpu_notifier(struct notifier_block *nb)
+{
+	return 0;
+}
 #define unregister_hotcpu_notifier(nb)	do { (void)(nb); } while (0)
 
 /* CPUs don't go offline once they're online w/o CONFIG_HOTPLUG_CPU */
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] Redefine register_hotcpu_notifier() !HOTPLUG_CPU stu..., Satyam Sharma, (Wed Aug 22, 6:47 pm)