[PATCH] Fix warnings in selection.h

Previous thread: lists by Xu Yang on Wednesday, August 22, 2007 - 11:10 am. (2 messages)

Next thread: Linux Foundation Technical Advisory Board Elections by James Bottomley on Wednesday, August 22, 2007 - 11:22 am. (62 messages)
To: <adaplas@...>, Andrew Morton <akpm@...>, <linux-kernel@...>
Date: Wednesday, August 22, 2007 - 11:15 am

<linux/selection.h> assumes that struct tty_struct has previously been
included. If not, this pile of warnings will result:

CC [M] drivers/video/console/newport_con.o
In file included from drivers/video/console/newport_con.c:18:
include/linux/selection.h:16: warning: 'struct tty_struct' declared inside param
eter list
include/linux/selection.h:16: warning: its scope is only this definition or decl
aration, which is probably not what you want
include/linux/selection.h:17: warning: 'struct tty_struct' declared inside param
eter list
include/linux/selection.h:20: warning: 'struct tty_struct' declared inside param
eter list

Fixed by adding a forward declaration of struct tty_struct.

Signed-off-by: Ralf Baechle <ralf@linux-mips.org>

diff --git a/include/linux/selection.h b/include/linux/selection.h
index ed3408b..16184d6 100644
--- a/include/linux/selection.h
+++ b/include/linux/selection.h
@@ -11,6 +11,7 @@
#include <linux/vt_buffer.h>

extern struct vc_data *sel_cons;
+struct tty_struct;

extern void clear_selection(void);
extern int set_selection(const struct tiocl_selection __user *sel, struct tty_struct *tty);
-

Previous thread: lists by Xu Yang on Wednesday, August 22, 2007 - 11:10 am. (2 messages)

Next thread: Linux Foundation Technical Advisory Board Elections by James Bottomley on Wednesday, August 22, 2007 - 11:22 am. (62 messages)