* Eric W. Biederman <ebiederm@xmission.com> wrote:
quoted text > Ok. I missed that. Duh. I just saw Andrews drop message.
>
> This looks like Alexey respun my patch, or else we were thinking on
> parallel paths. Probably parallel given Alexey's dislike of using the
> CTL_UNNUMBERED define.
>
> There are two remaining gotchas:
> - The directories have impossible permissions (writeable).
>
> - The ctl_name for the kernel directory is inconsistent with
> everything else. It should be CTL_KERN.
thx, i've applied your patch to my tree.
quoted text > I kind of feel bad about being so picky but the this code is the only
> place in the kernel where I have seen us violate either of those
> rules, and it is a lot easier to deal with things when they are
> consistent.
sure enough, i'm not opposed at all to fixing these issues. We should
move your debug-sysctl-bugs patch upstream ASAP.
Ingo
-
unsubscribe notice To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Messages in current thread:
Re: 2.6.23-rc2-mm2 , Ingo Molnar , (Tue Aug 21, 3:41 am)