Home » Mailing list archives » linux-kernel » 2007 » August » 2

[PATCH] do_sigaction: remove now unneeded recalc_sigpending()

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Oleg Nesterov <oleg@...>
To: Andrew Morton <akpm@...>
Cc: Ingo Molnar <mingo@...>, Roland McGrath <roland@...>, <linux-kernel@...>
Subject: [PATCH] do_sigaction: remove now unneeded recalc_sigpending()
Date: Thursday, August 2, 2007 - 6:37 pm

With the recent changes, do_sigaction()->recalc_sigpending_and_wake() can
never clear TIF_SIGPENDING. Instead, it can set this flag and wake up the
thread without any reason. Harmless, but unneeded and wastes CPU.

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>

--- t/kernel/signal.c~	2007-08-03 02:26:30.000000000 +0400
+++ t/kernel/signal.c	2007-08-03 02:28:50.000000000 +0400
@@ -2342,7 +2342,6 @@ int do_sigaction(int sig, struct k_sigac
 			rm_from_queue_full(&mask, &t->signal->shared_pending);
 			do {
 				rm_from_queue_full(&mask, &t->pending);
-				recalc_sigpending_and_wake(t);
 				t = next_thread(t);
 			} while (t != current);
 		}

-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] do_sigaction: remove now unneeded recalc_sigpending(), Oleg Nesterov, (Thu Aug 2, 6:37 pm)
Re: [PATCH] do_sigaction: remove now unneeded recalc_sigpend..., Roland McGrath, (Thu Aug 2, 6:40 pm)