Re: VIA EPIA EK: strange eth dev numbering

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Michael Tokarev <mjt@...>
Cc: Herbert Rosmanith <kernel@...>, <linux-kernel@...>
Date: Thursday, August 2, 2007 - 2:37 pm

Hey,


I know I have seen my kernel outputting "A renamed to B". Since you two 
however wanted that information in the first place, I grepped a bit 
around, and actually found, (drumroll), that the SUSE kernel has had a 
proper patch for [I can't remember how long] quite some time. (At least 
one distro which does the right thing.) I copied it below.


	Jan
===
Name: patches.suse/nameif-track-rename.patch
Subject: [PATCH] keep track of network interface renaming
From: Olaf Hering <olh@suse.de>

Keep track about which network interface names were renamed after the
network device driver printed its banner. Example insanity:

honeydew:~ # dmesg| grep -Ew '(eth[0-9]|rename|renamed)'
e1000: eth0: e1000_probe: Intel(R) PRO/1000 Network Connection
e1000: eth1: e1000_probe: Intel(R) PRO/1000 Network Connection
e1000: eth2: e1000_probe: Intel(R) PRO/1000 Network Connection
e1000: eth3: e1000_probe: Intel(R) PRO/1000 Network Connection
dev_change_name: about to rename 'eth3' to 'eth0'
dev_change_name: about to rename 'eth3' to 'ethxx3'
eth3 renamed to ethxx3
dev_change_name: about to rename 'ethxx3' to 'eth0'
dev_change_name: about to rename 'eth0' to 'eth3'
eth0 renamed to eth3
dev_change_name: about to rename 'eth1' to 'eth2'
dev_change_name: about to rename 'eth1' to 'ethxx1'
eth1 renamed to ethxx1
dev_change_name: about to rename 'ethxx1' to 'eth2'
dev_change_name: about to rename 'eth2' to 'eth1'
eth2 renamed to eth1
dev_change_name: about to rename 'ethxx3' to 'eth0'
ethxx3 renamed to eth0
dev_change_name: about to rename 'ethxx1' to 'eth2'
ethxx1 renamed to eth2
e1000: eth0: e1000_watchdog_task: NIC Link is Up 100 Mbps Full Duplex



Signed-off-by: Olaf Hering <olh@suse.de>

 net/core/dev.c |    4 ++++
 1 files changed, 4 insertions(+)

--- linux-2.6.21.orig/net/core/dev.c
+++ linux-2.6.21/net/core/dev.c
@@ -822,7 +822,11 @@ int dev_change_name(struct net_device *d
 	else if (__dev_get_by_name(newname))
 		return -EEXIST;
 	else
+	{
+		if (strncmp(newname, dev->name, IFNAMSIZ))
+			printk(KERN_INFO "%s renamed to %s\n", dev->name, newname);
 		strlcpy(dev->name, newname, IFNAMSIZ);
+	}
 
 	device_rename(&dev->dev, dev->name);
 	hlist_del(&dev->name_hlist);
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
VIA EPIA EK: strange eth dev numbering, Herbert Rosmanith, (Thu Aug 2, 6:20 am)
Re: VIA EPIA EK: strange eth dev numbering, Jan Engelhardt, (Thu Aug 2, 6:44 am)
Re: VIA EPIA EK: strange eth dev numbering, Michael Tokarev, (Thu Aug 2, 6:26 am)
Re: VIA EPIA EK: strange eth dev numbering, Herbert Rosmanith, (Thu Aug 2, 6:42 am)
Re: VIA EPIA EK: strange eth dev numbering, Jan Engelhardt, (Thu Aug 2, 6:49 am)
Re: VIA EPIA EK: strange eth dev numbering, Herbert Rosmanith, (Thu Aug 2, 7:12 am)
Re: VIA EPIA EK: strange eth dev numbering, Herbert Rosmanith, (Thu Aug 2, 6:56 am)
Re: VIA EPIA EK: strange eth dev numbering, Jan Engelhardt, (Thu Aug 2, 7:47 am)
Re: VIA EPIA EK: strange eth dev numbering, Michael Tokarev, (Thu Aug 2, 9:07 am)
Re: VIA EPIA EK: strange eth dev numbering, Jan Engelhardt, (Thu Aug 2, 9:38 am)
Re: VIA EPIA EK: strange eth dev numbering, Jan Engelhardt, (Thu Aug 2, 2:37 pm)
Re: VIA EPIA EK: strange eth dev numbering, Kay Sievers, (Thu Aug 2, 6:00 pm)
Re: VIA EPIA EK: strange eth dev numbering, Jan Engelhardt, (Thu Aug 2, 6:39 pm)
Re: VIA EPIA EK: strange eth dev numbering, Kay Sievers, (Thu Aug 2, 6:49 pm)
Re: VIA EPIA EK: strange eth dev numbering, Jan Engelhardt, (Fri Aug 3, 3:46 am)
Re: VIA EPIA EK: strange eth dev numbering, Herbert Rosmanith, (Thu Aug 2, 8:00 am)
Re: VIA EPIA EK: strange eth dev numbering, Jan Engelhardt, (Thu Aug 2, 8:06 am)