> The working board has a different version of the Marvell chip: > $ grep Marvell working-MB > 04:00.0 Ethernet controller: Marvell Technology Group Ltd. 88E8056 PCI-E Gigabit Ethernet Controller (rev 14) > $ grep Marvell broken-MB > 04:00.0 Ethernet controller: Marvell Technology Group Ltd. 88E8056 PCI-E Gigabit Ethernet Controller (rev 12) Just to add a bit more information, I've just build up a GA-965P-DS3 with a Q6600 and the onboard Marvell doesn't seem to be wor...

(untested) There are several files that #include "linux/file" not #include <linux/file> #include "asm/file" not #include <asm/file> Here's a little script that converts them: egrep -i -r -l --include=*.[ch] \ "^[[:space:]]*\#[[:space:]]*include[[:space:]]*\"(linux|asm)/(.*)\"" * \ | xargs sed -i -e 's/^[[:space:]]*#[[:space:]]*include[[:space:]]*"\(linux\|asm\)\/\(.*\)"/#include <\1\/\2>/g' Signed-off-by: Joe Perches <joe@perches.com> diff --git a/mm/slab.c b/mm/s...

--- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** -

It's not only included in that directory. I find it included in 88 source files throughout the kernel tree. --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** -

(untested) There are several files that #include "linux/file" not #include <linux/file> #include "asm/file" not #include <asm/file> Here's a little script that converts them: egrep -i -r -l --include=*.[ch] \ "^[[:space:]]*\#[[:space:]]*include[[:space:]]*\"(linux|asm)/(.*)\"" * \ | xargs sed -i -e 's/^[[:space:]]*#[[:space:]]*include[[:space:]]*"\(linux\|asm\)\/\(.* \)"/#include <\1\/\2>/g' Signed-off-by: Joe Perches <joe@perches.com> diff --git a/drivers/char/...

Not only that. All directories in include should be checked against (e.g. <net/*>) Jan -- -

Except that some instances are legitimate (e.g. there was a bunch in arch/um, IIRC)... -

It would be a better thing if you * did builds of the patched trees (allmodconfig for uml/i386 and uml/amd64 in this case) * figured out that one can send a reference to branch in git tree (with summary/shortlog/diffstat) using somewhat less than 140KB... -

Hi, According to dmesg, I encountered a kernel bug on my system. I'm not sure if this is the appropriate place to report this problem as this occured on a Fedora kernel. Maybe its a general problem? kernel BUG at lib/list_debug.c:27! invalid opcode: 0000 [2] SMP =========================================== = What was I doing when this happened. ========================================== I was doing a rm -rf /media/somedir/ command on a USB harddisk. This USB harddisk casing contai...

[Felix Marti] You're not at all addressing the fact that RDMA does solve the memory BW problem and stateless offload doesn't. Apart from that, I don't quite understand your argument with respect to the benefits of the RDMA infrastructure; what benefits does the TSO infrastructure give the non-TSO capable devices? Isn't the answer none and yet you added TSO support?! I don't think that the argument is stateless _versus_ stateful offload both have their advantages and disadvantages. Stateless offload d...

From: Andi Kleen <andi@firstfloor.org> And also, you can enable TSO generation for a non-TSO-hw device and get all of the segmentation overhead reduction gains which works out as a pure win as long as the device can at a minimum do checksumming. -

The Marvell bridge chips used on HighPoint SATA cards do not seem to support the UltraDMA modes 1, 2, and 3 as well as any MWDMA modes, so the driver needs to account for this in the udma_filter() method. In order to achieve that, do the following changes: - install the method for all chips, not only HPT36x/370 and impove the code formatting by killing the extra tabs while at it; - add to the end of the 'switch' statement in the method cases for HPT372[AN] and HPT374 chips upon which the kno...

The driver prints some chip version info at startup, that might be helpful in disambiguating good/bad versions: dmesg | grep sky2 -

--- Stephen Hemminger Here's the output from the working MB: sky2 0000:04:00.0: v1.14 addr 0xf8000000 irq 16 Yukon-EC Ultra (0xb4) rev 3 sky2 eth0: addr 00:1a:4d:42:61:46 sky2 eth0: enabling interface sky2 eth0: ram buffer 0K sky2 eth0: Link is up at 100 Mbps, full duplex, flow control both The broken MB there's no output in dmesg but there is in /var/log/messages (I just rebooted the machine to get the output): Aug 19 14:56:42 www kernel: sky2 0000:04:00.0: v1.14 addr 0xf8000000 irq ...

Different types of ufs hold state in different places, to hide complexity of this, there is ufs_get_fs_state, it returns state according to "UFS_SB(sb)->s_flags", but during mount ufs_get_fs_state is called, before setting s_flags, this cause message for ufs types like sun ufs: "fs need fsck", and remount in readonly state. This patch depend on other patches that now in -mm branch. Signed-off-by: Evgeniy Dushistov <dushistov@mail.ru> --- Index: linux-2.6.23-rc3-git1/fs/ufs/super...

From: "Felix Marti" <felix@chelsio.com> This thing you call "sprinkled" is a necessity of any hardware offload when it is possible for a packet to later get "steered" to a device which cannot perform the offload. Therefore we need a software implementation of TSO so that those packets can still get output to the non-TSO-capable device. We do the same thing for checksum offloading. And for free we can use the software offloading mechanism to get batching to arbitrary network devices, ev...

Rene. -

There is a short description of the desired semantics in the link that was posted: http://lkml.org/lkml/2007/6/18/228 === The user now is allowed to send packages if either his euid or his egid matches the one specified via tunctl (via -u or -g respecitvely). If both gid and uid are set via tunctl, both have to match. === Paraphrasing the original code above, it's saying: if ((owner_is_set && does_not_match) || (group_is_set && does_not_match)) bugger_off_unless(CAP_N...

(Not for inclusion yet, against 2.6.23-rc2, untested) Currently, /sbin/init is protected from unhandled signals by the "current == child_reaper(current)" check in get_signal_to_deliver(). This is not enough, we have multiple problems: - this doesn't work for multi-threaded inits, and we can't fix this by simply making this check group-wide. - /sbin/init and kernel threads are not protected from handle_stop_signal(). Minor problem, but not good and allows to "steal" SIGCONT or change...

The driver erroneously "lets go" the mate IDE chip in init_setup_pdc20270() when ide_setup_pci_devices() call succeeds -- fix this, and drop a couple of useless assignments in this function while at it... Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com> --- This patch is against the current Linus' tree, it has only been compile tested since I do not have PDC2027x chips (and even less so behind DC21150 bridge :-). I'm reposting the patchset a wider audience now... drivers/ide/pci...

kernel/sched.c gets compiled with -fno-omit-frame-pointer, and this was already done in kernel 1.0 (sic). Later, it has been modified to be this way only on some architectures. It might not be an earthshaking amount, but removing it saves some bytes, and there's no visible breakage when running the modified kernel on i386. $ ls -la kernel/sched.o* -rw-rw-r-- 1 bunk bunk 25600 2007-08-19 16:10 kernel/sched.o -rw-rw-r-- 1 bunk bunk 26084 2007-08-19 16:03 kernel/sched.o.old $ size kernel/sche...

vague memory: this was needed for wchan to work properly -

The rtc-ds1553 platform driver name doesn't match its module name, which might prevent it from properly hotplugging. This driver has no in-tree users. Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp> --- The "take 2" of this patch was just a typo-fix ("1553" vs. "1742"). diff --git a/drivers/rtc/rtc-ds1553.c b/drivers/rtc/rtc-ds1553.c index 46da571..a4bcb34 100644 --- a/drivers/rtc/rtc-ds1553.c +++ b/drivers/rtc/rtc-ds1553.c @@ -395,7 +395,7 @@ static struct platform_driver ds1553_rt...

Hi, Pipes for the world... find . -type f -iname "*.[ch]" -print0 | \ xargs -0 grep -P '#\s*include' /dev/null | \ sort | \ uniq -c | \ sort -gr | \ less -MSi turns up all the double-inclusions. Needs someone to review, because odd things like /* meh */ #if defined(ABC) # include "foo.h" #elif defined(DEF) # include "foo.h" #else # whatever #endif are done. Or, that <foo.h> actually changes its meaning depending on a macro... /* ugly */ #defin...

When taking a cpu down, we need to hardware_disable() it. Unfortunately, the CPU_DYING notifier is called with interrupts disabled, which means we can't use smp_call_function_single(). Fortunately, the CPU_DYING notifier is always called on the dying cpu, so we don't need to use the function at all and can simply call hardware_disable() directly. Tested-by: Paolo Ornati <ornati@fastwebnet.it> Signed-off-by: Avi Kivity <avi@qumranet.com> --- Linus, please apply to -rc. drivers/k...