login
Login
/
Register
Search
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2007
»
August
»
19
Re: [PATCH 4/5] Documentation/firmware/... convert #include "linux/..." to #include <linux/...>
view
thread
!MAILaRCHIVE_VOTE_RePLACE
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From:
Randy Dunlap <randy.dunlap@...>
To: Joe Perches <joe@...>
Cc: <kernel-janitors@...>, <linux-kernel@...>, Greg Kroah-Hartman <gregkh@...>, Markus Rechberger <markus.rechberger@...>
Subject:
Re: [PATCH 4/5] Documentation/firmware/... convert #include "linux/..." to #include <linux/...>
Date: Sunday, August 19, 2007 - 6:34 pm
On Sun, 19 Aug 2007 15:19:32 -0700 Joe Perches wrote:
quoted text
> (untested) > > There are several files that > #include "linux/file" not #include <linux/file> > #include "asm/file" not #include <asm/file> > > Here's a little script that converts them: > > egrep -i -r -l --include=*.[ch] \ > "^[[:space:]]*\#[[:space:]]*include[[:space:]]*\"(linux|asm)/(.*)\"" * \ > | xargs sed -i -e 's/^[[:space:]]*#[[:space:]]*include[[:space:]]*"\(linux\|asm\)\/\(.*\)"/#include <\/>/g' > > This one is probably wrong. > > It should likely keep firmware.h in > the same directory as firmware.c > > Signed-off-by: Joe Perches <joe@perches.com> > > diff --git a/Documentation/firmware_class/firmware_sample_driver.c b/Documentation/firmware_class/firmware_sample_driver.c > index 6865cbe..754ded2 100644 > --- a/Documentation/firmware_class/firmware_sample_driver.c > +++ b/Documentation/firmware_class/firmware_sample_driver.c > @@ -13,7 +13,7 @@ > #include <linux/device.h> > #include <linux/string.h> > > -#include "linux/firmware.h" > +#include "firmware.h"
I believe that it should be <linux/firmware.h>.
quoted text
> static struct device ghost_device = { > .bus_id = "ghost0",
--- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** -
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[PATCH 4/5] Documentation/firmware/... convert #include "lin...
, Joe Perches
, (Sun Aug 19, 6:19 pm)
Re: [PATCH 4/5] Documentation/firmware/... convert #include ...
, Randy Dunlap
, (Sun Aug 19, 6:34 pm)
Re: [PATCH 4/5] Documentation/firmware/... convert #include ...
, Joe Perches
, (Sun Aug 19, 6:31 pm)
Re: [PATCH 4/5] Documentation/firmware/... convert #include ...
, Randy Dunlap
, (Sun Aug 19, 6:41 pm)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Sunil Naidu
Re: Linux 2.6.20-rc6
david
Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Jan Engelhardt
intel iommu (Re: -mm merge plans for 2.6.23)
Linus Torvalds
Re: init's children list is long and slows reaping children.
linux-netdev
:
David Miller
Re: [GIT]: Networking
Jarek Poplawski
[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Gerrit Renker
[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
Andrew Morton
Re: [BUG] New Kernel Bugs
git
:
openbsd-misc
:
Colocation donated by:
Who's online
There are currently
2 users
and
844 guests
online.
Online users
strcmp
tyhxcv
Syndicate