login
Login
/
Register
Search
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2007
»
August
»
19
Re: group ownership of tun devices -- nonfunctional?
view
thread
!MAILaRCHIVE_VOTE_RePLACE
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From:
Rene Herman <rene.herman@...>
To: <7eggert@...>
Cc: Mike Mohr <akihana@...>, <linux-kernel@...>
Subject:
Re: group ownership of tun devices -- nonfunctional?
Date: Sunday, August 19, 2007 - 12:10 pm
On 08/19/2007 06:05 PM, Bodo Eggert wrote:
quoted text
> IMHO the check is broken: > > + if (((tun->owner != -1 && > + current->euid != tun->owner) || > + (tun->group != -1 && > + current->egid != tun->group)) && > + !capable(CAP_NET_ADMIN)) > return -EPERM; > > It should be something like: > > + if (!((tun->owner == tun->owner) || > + (tun->group == tun->group) ||
???
quoted text
> + capable(CAP_NET_ADMIN))) > return -EPERM; > > Please verify and forward to the maintainers if my guess appears to be correct.
Rene. -
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
Re: group ownership of tun devices -- nonfunctional?
, Bodo Eggert
, (Sun Aug 19, 12:05 pm)
Re: group ownership of tun devices -- nonfunctional?
, Rene Herman
, (Sun Aug 19, 12:10 pm)
Re: group ownership of tun devices -- nonfunctional?
, Bodo Eggert
, (Sun Aug 19, 5:42 pm)
Re: group ownership of tun devices -- nonfunctional?
, Jeff Dike
, (Wed Aug 22, 4:42 pm)
Re: group ownership of tun devices -- nonfunctional?
, Guido Guenther
, (Thu Aug 23, 3:13 am)
Re: group ownership of tun devices -- nonfunctional?
, Rene Herman
, (Sun Aug 19, 7:24 pm)
Re: group ownership of tun devices -- nonfunctional?
, Bodo Eggert
, (Mon Aug 20, 7:45 am)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Greg Kroah-Hartman
[PATCH 001/196] Chinese: Add the known_regression URI to the HOWTO
Linus Torvalds
Linux 2.6.21-rc1
Tarkan Erimer
Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
pageexec
Re: [stable] Linux 2.6.25.10
linux-netdev
:
Linus Torvalds
Re: [GIT]: Networking
Gerrit Renker
[PATCH 15/37] dccp: Set per-connection CCIDs via socket options
Natalie Protasevich
[BUG] New Kernel Bugs
Jarek Poplawski
[PATCH take 2] pkt_sched: Protect gen estimators under est_lock.
git
:
openmoko-community
:
Colocation donated by:
Who's online
There are currently
10 users
and
762 guests
online.
Online users
blacklightteet
maximumprostat
beatlesgiftswta
fragysy59
naetallergyeli
pattifeder123
larryfctva
outdoorhomelig
musclebuilding
kidsshowercurt
Syndicate