sched.c: why -fno-omit-frame-pointer?

Previous thread: [PATCH] rtc: Make rtc-ds1742 driver hotplug-aware (take 2) by Atsushi Nemoto on Sunday, August 19, 2007 - 9:32 am. (1 message)

Next thread: [PATCH] Fix tsk->exit_state usage (resend) by Eugene Teo on Sunday, August 19, 2007 - 10:24 am. (2 messages)
To: Ingo Molnar <mingo@...>
Cc: <linux-kernel@...>, Andreas Schwab <schwab@...>, Alan Modra <alan@...>, David Mosberger-Tang <davidm@...>
Date: Sunday, August 19, 2007 - 10:17 am

kernel/sched.c gets compiled with -fno-omit-frame-pointer, and this was
already done in kernel 1.0 (sic).

Later, it has been modified to be this way only on some architectures.

It might not be an earthshaking amount, but removing it saves some
bytes, and there's no visible breakage when running the modified kernel
on i386.

$ ls -la kernel/sched.o*
-rw-rw-r-- 1 bunk bunk 25600 2007-08-19 16:10 kernel/sched.o
-rw-rw-r-- 1 bunk bunk 26084 2007-08-19 16:03 kernel/sched.o.old
$ size kernel/sched.o*
text data bss dec hex filename
11835 184 2000 14019 36c3 kernel/sched.o
12321 184 2000 14505 38a9 kernel/sched.o.old
$

Is the -fno-omit-frame-pointer still required for some reason, or is
this a relict that could be removed?

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

-

To: Adrian Bunk <bunk@...>
Cc: Ingo Molnar <mingo@...>, <linux-kernel@...>, Andreas Schwab <schwab@...>, Alan Modra <alan@...>, David Mosberger-Tang <davidm@...>
Date: Sunday, August 19, 2007 - 7:00 pm

It's needed so that the WCHAN /proc display can backtrace one
level up out of schedule()

-Andi
-

To: Andi Kleen <andi@...>
Cc: Adrian Bunk <bunk@...>, <linux-kernel@...>, Andreas Schwab <schwab@...>, Alan Modra <alan@...>, David Mosberger-Tang <davidm@...>
Date: Thursday, August 23, 2007 - 7:30 am

it's not just one level - we'll back out until we are in scheduler
functions (up to 16 levels). So it will back out of io_schedule() and
other functions as well.

Ingo
-

To: Adrian Bunk <bunk@...>
Cc: Ingo Molnar <mingo@...>, <linux-kernel@...>, Andreas Schwab <schwab@...>, Alan Modra <alan@...>, David Mosberger-Tang <davidm@...>
Date: Sunday, August 19, 2007 - 5:05 pm

vague memory: this was needed for wchan to work properly

-

Previous thread: [PATCH] rtc: Make rtc-ds1742 driver hotplug-aware (take 2) by Atsushi Nemoto on Sunday, August 19, 2007 - 9:32 am. (1 message)

Next thread: [PATCH] Fix tsk->exit_state usage (resend) by Eugene Teo on Sunday, August 19, 2007 - 10:24 am. (2 messages)