[-mm patch] fs/reiser4/plugin/: make 3 functions static

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Andrew Morton <akpm@...>, Edward Shishkin <edward@...>
Cc: <linux-kernel@...>, <reiserfs-devel@...>
Date: Tuesday, August 14, 2007 - 5:21 pm

On Tue, Jul 31, 2007 at 11:09:32PM -0700, Andrew Morton wrote:

This patch makes the following needlessly global functions static:
- file/cryptcompress.c: __put_page_cluster()
- file/cryptcompress.c: put_hint_cluster()
- item/ctail.c: ctail_read_disk_cluster()

Signed-off-by: Adrian Bunk <bunk@kernel.org>

---

 fs/reiser4/plugin/cluster.h            |    4 ----
 fs/reiser4/plugin/file/cryptcompress.c |    8 ++++----
 fs/reiser4/plugin/file/cryptcompress.h |    2 --
 fs/reiser4/plugin/item/ctail.c         |    5 +++--
 4 files changed, 7 insertions(+), 12 deletions(-)

dcbd29fcda0d6143ab0ec5f91e347d6e540f27bd 
diff --git a/fs/reiser4/plugin/cluster.h b/fs/reiser4/plugin/cluster.h
index 7856074..af7a305 100644
--- a/fs/reiser4/plugin/cluster.h
+++ b/fs/reiser4/plugin/cluster.h
@@ -326,8 +326,6 @@ int reiser4_deflate_cluster(struct cluster_handle *, struct inode *);
 void truncate_complete_page_cluster(struct inode *inode, cloff_t start,
 					 int even_cows);
 void invalidate_hint_cluster(struct cluster_handle * clust);
-void put_hint_cluster(struct cluster_handle * clust, struct inode *inode,
-		      znode_lock_mode mode);
 int get_disk_cluster_locked(struct cluster_handle * clust, struct inode * inode,
 			    znode_lock_mode lock_mode);
 void reset_cluster_params(struct cluster_handle * clust);
@@ -335,8 +333,6 @@ int set_cluster_by_page(struct cluster_handle * clust, struct page * page,
 			int count);
 int prepare_page_cluster(struct inode *inode, struct cluster_handle * clust,
 			 rw_op rw);
-void __put_page_cluster(int from, int to, struct page ** pages,
-			struct inode * inode);
 void put_page_cluster(struct cluster_handle * clust,
 		      struct inode  * inode, rw_op rw);
 void put_cluster_handle(struct cluster_handle * clust);
diff --git a/fs/reiser4/plugin/file/cryptcompress.c b/fs/reiser4/plugin/file/cryptcompress.c
index f0f0bee..9724d64 100644
--- a/fs/reiser4/plugin/file/cryptcompress.c
+++ b/fs/reiser4/plugin/file/cryptcompress.c
@@ -1378,8 +1378,8 @@ static void truncate_page_cluster_range(struct inode * inode,
 }
 
 /* Put @count pages starting from @from offset */
-void __put_page_cluster(int from, int count,
-			struct page ** pages, struct inode  * inode)
+static void __put_page_cluster(int from, int count,
+			       struct page ** pages, struct inode  * inode)
 {
 	int i;
 	assert("edward-1468", pages != NULL);
@@ -1975,8 +1975,8 @@ void invalidate_hint_cluster(struct cluster_handle * clust)
 	hint_clr_valid(clust->hint);
 }
 
-void put_hint_cluster(struct cluster_handle * clust, struct inode *inode,
-		      znode_lock_mode mode)
+static void put_hint_cluster(struct cluster_handle * clust,
+			     struct inode *inode, znode_lock_mode mode)
 {
 	assert("edward-1286", clust != NULL);
 	assert("edward-1287", clust->hint != NULL);
diff --git a/fs/reiser4/plugin/file/cryptcompress.h b/fs/reiser4/plugin/file/cryptcompress.h
index 5984e3c..117d377 100644
--- a/fs/reiser4/plugin/file/cryptcompress.h
+++ b/fs/reiser4/plugin/file/cryptcompress.h
@@ -530,8 +530,6 @@ int equal_to_rdk(znode *, const reiser4_key *);
 int goto_right_neighbor(coord_t *, lock_handle *);
 int cryptcompress_inode_ok(struct inode *inode);
 int coord_is_unprepped_ctail(const coord_t * coord);
-extern int ctail_read_disk_cluster (struct cluster_handle *, struct inode *,
-				    struct page *, znode_lock_mode mode);
 extern int do_readpage_ctail(struct inode *, struct cluster_handle *,
 			     struct page * page, znode_lock_mode mode);
 extern int ctail_insert_unprepped_cluster(struct cluster_handle * clust,
diff --git a/fs/reiser4/plugin/item/ctail.c b/fs/reiser4/plugin/item/ctail.c
index a931392..33ab44a 100644
--- a/fs/reiser4/plugin/item/ctail.c
+++ b/fs/reiser4/plugin/item/ctail.c
@@ -551,8 +551,9 @@ int read_ctail(struct file *file UNUSED_ARG, flow_t * f, hint_t * hint)
  * Prepare transform stream with plain text for page
  * @page taking into account synchronization issues.
  */
-int ctail_read_disk_cluster(struct cluster_handle * clust, struct inode * inode,
-			    struct page * page, znode_lock_mode mode)
+static int ctail_read_disk_cluster(struct cluster_handle * clust,
+				   struct inode * inode, struct page * page,
+				   znode_lock_mode mode)
 {
 	int result;
 

-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
2.6.23-rc1-mm2, Andrew Morton, (Wed Aug 1, 2:09 am)
[-mm patch] fs/reiser4/plugin/: make 3 functions static, Adrian Bunk, (Tue Aug 14, 5:21 pm)
[-mm patch] make pm3fb_init() static again, Adrian Bunk, (Tue Aug 14, 5:21 pm)
2.6.23-rc1-mm2: MMC_ARMMMCI compile error, Adrian Bunk, (Wed Aug 8, 5:31 pm)
Re: 2.6.23-rc1-mm2: MMC_ARMMMCI compile error, Pierre Ossman, (Thu Aug 9, 8:03 am)
Re: 2.6.23-rc1-mm2, Marc Dietrich, (Fri Aug 3, 7:00 am)
Re: 2.6.23-rc1-mm2, Andrew Morton, (Fri Aug 3, 12:38 pm)
Re: [NFS] 2.6.23-rc1-mm2, Trond Myklebust, (Fri Aug 3, 1:03 pm)
Re: [NFS] 2.6.23-rc1-mm2, Oleg Nesterov, (Fri Aug 3, 1:21 pm)
Re: [NFS] 2.6.23-rc1-mm2, Trond Myklebust, (Tue Aug 7, 5:08 pm)
Re: [NFS] 2.6.23-rc1-mm2, Oleg Nesterov, (Tue Aug 7, 5:37 pm)
Re: [NFS] 2.6.23-rc1-mm2, Trond Myklebust, (Tue Aug 7, 6:05 pm)
Re: [NFS] 2.6.23-rc1-mm2, Oleg Nesterov, (Tue Aug 7, 6:20 pm)
Re: [NFS] 2.6.23-rc1-mm2, Trond Myklebust, (Tue Aug 7, 7:08 pm)
Re: [NFS] 2.6.23-rc1-mm2, Oleg Nesterov, (Tue Aug 7, 7:14 pm)
Re: [NFS] 2.6.23-rc1-mm2, Johannes Berg, (Mon Aug 6, 2:24 am)
Re: [NFS] 2.6.23-rc1-mm2, Marc Dietrich, (Mon Aug 6, 7:05 am)
Re: [NFS] 2.6.23-rc1-mm2, Trond Myklebust, (Mon Aug 6, 12:24 pm)
Re: [NFS] 2.6.23-rc1-mm2, Marc Dietrich, (Tue Aug 7, 8:09 am)
Re: [NFS] 2.6.23-rc1-mm2, Johannes Berg, (Mon Aug 6, 7:13 am)
Re: [NFS] 2.6.23-rc1-mm2, Oleg Nesterov, (Mon Aug 6, 6:53 am)
Re: [NFS] 2.6.23-rc1-mm2, Johannes Berg, (Mon Aug 6, 6:58 am)
Re: 2.6.23-rc1-mm2: Fix crash in sysfs_hash_and_remove, Rafael J. Wysocki, (Thu Aug 2, 1:31 pm)
Re: 2.6.23-rc1-mm2: Fix crash in sysfs_hash_and_remove, Eric W. Biederman, (Thu Aug 2, 2:19 pm)
[PATCH -mm] linux-audit list is subscribers-only , Gabriel C, (Wed Aug 1, 7:59 pm)
Re: [PATCH -mm] linux-audit list is subscribers-only, Randy Dunlap, (Wed Aug 1, 9:30 pm)
INOTIFY=n , AUDIT*=y compile error, Gabriel C, (Wed Aug 1, 7:40 pm)
Re: 2.6.23-rc1-mm2, , (Wed Aug 1, 4:30 pm)
Re: 2.6.23-rc1-mm2, Andrew Morton, (Wed Aug 1, 4:40 pm)
Re: 2.6.23-rc1-mm2, Torsten Kaiser, (Wed Aug 1, 4:52 pm)
Re: 2.6.23-rc1-mm2, Mel Gorman, (Wed Aug 1, 7:40 pm)
Re: 2.6.23-rc1-mm2, Andy Whitcroft, (Thu Aug 2, 10:01 am)
Re: 2.6.23-rc1-mm2, Torsten Kaiser, (Thu Aug 2, 1:44 pm)
Re: 2.6.23-rc1-mm2, Torsten Kaiser, (Thu Aug 2, 12:38 am)
Re: 2.6.23-rc1-mm2, Andrew Morton, (Wed Aug 1, 5:17 pm)
[PATCH -mm] Fix a section mismatch warning, Gabriel C, (Wed Aug 1, 11:19 am)
[PATCH] fix slown down printk on boot compile error, Heiko Carstens, (Wed Aug 1, 7:16 am)
Re: [PATCH] fix slown down printk on boot compile error, Randy Dunlap, (Wed Aug 1, 12:32 pm)
Re: 2.6.23-rc1-mm2, Gabriel C, (Wed Aug 1, 6:56 am)
Re: 2.6.23-rc1-mm2, Andrew Morton, (Wed Aug 1, 1:26 pm)
Re: 2.6.23-rc1-mm2, Gabriel C, (Wed Aug 1, 1:39 pm)
unionfs compile error ( Re: 2.6.23-rc1-mm2 ), Gabriel C, (Wed Aug 1, 6:33 am)
Re: unionfs compile error ( Re: 2.6.23-rc1-mm2 ), Andrew Morton, (Wed Aug 1, 1:22 pm)
Re: unionfs compile error ( Re: 2.6.23-rc1-mm2 ), Gabriel C, (Wed Aug 1, 1:35 pm)
Re: unionfs compile error ( Re: 2.6.23-rc1-mm2 ), Josef Sipek, (Wed Aug 1, 1:27 pm)
Re: unionfs compile error ( Re: 2.6.23-rc1-mm2 ) , Erez Zadok, (Thu Aug 2, 12:29 pm)
[PATCH] prevent SSB compilation on s390 part 2, Heiko Carstens, (Wed Aug 1, 5:34 am)
Re: [PATCH] prevent SSB compilation on s390 part 2, Heiko Carstens, (Wed Aug 1, 10:43 am)
Re: [PATCH] prevent SSB compilation on s390 part 2, Michael Buesch, (Wed Aug 1, 10:54 am)
Re: [PATCH] prevent SSB compilation on s390 part 2, John W. Linville, (Wed Aug 1, 8:24 am)
Re: 2.6.23-rc1-mm2, Mariusz Kozlowski, (Wed Aug 1, 4:02 am)
Re: 2.6.23-rc1-mm2, Segher Boessenkool, (Mon Aug 6, 3:08 pm)
Re: 2.6.23-rc1-mm2, Mariusz Kozlowski, (Mon Aug 6, 3:34 pm)
Re: 2.6.23-rc1-mm2, Segher Boessenkool, (Mon Aug 6, 5:25 pm)
Re: 2.6.23-rc1-mm2, Mariusz Kozlowski, (Mon Aug 6, 6:34 pm)
Re: 2.6.23-rc1-mm2, Segher Boessenkool, (Mon Aug 6, 7:12 pm)
Re: 2.6.23-rc1-mm2, Greg KH, (Wed Aug 1, 12:36 pm)
Re: 2.6.23-rc1-mm2, Paul Mackerras, (Wed Aug 1, 6:32 am)
Re: 2.6.23-rc1-mm2, Mariusz Kozlowski, (Thu Aug 2, 6:14 am)
Re: 2.6.23-rc1-mm2, Segher Boessenkool, (Mon Aug 6, 3:10 pm)
Re: 2.6.23-rc1-mm2, Kumar Gala, (Fri Aug 3, 5:39 am)
Re: 2.6.23-rc1-mm2, Segher Boessenkool, (Mon Aug 6, 3:12 pm)
Re: 2.6.23-rc1-mm2, Andrew Morton, (Wed Aug 1, 4:13 am)
Re: 2.6.23-rc1-mm2, Jiri Kosina, (Wed Aug 1, 6:23 am)
Re: 2.6.23-rc1-mm2, Mariusz Kozlowski, (Thu Aug 2, 5:47 am)
Re: [linux-usb-devel] 2.6.23-rc1-mm2, Alan Stern, (Thu Aug 2, 10:20 am)
Re: [linux-usb-devel] 2.6.23-rc1-mm2, Mariusz Kozlowski, (Thu Aug 2, 10:32 am)
Re: [linux-usb-devel] 2.6.23-rc1-mm2, Jiri Kosina, (Thu Aug 2, 10:26 am)
Re: 2.6.23-rc1-mm2, Ingo Molnar, (Wed Aug 1, 4:16 am)
Re: 2.6.23-rc1-mm2, Paul Mundt, (Wed Aug 1, 2:25 am)
Re: 2.6.23-rc1-mm2, Jason Wessel, (Wed Aug 1, 8:22 am)
Re: 2.6.23-rc1-mm2, Mike Frysinger, (Wed Aug 1, 3:58 am)
Re: 2.6.23-rc1-mm2, Paul Mundt, (Wed Aug 1, 4:15 am)
Re: 2.6.23-rc1-mm2, Mike Frysinger, (Wed Aug 1, 5:04 am)
Re: 2.6.23-rc1-mm2, Andrew Morton, (Wed Aug 1, 4:10 am)
Re: 2.6.23-rc1-mm2, Christoph Hellwig, (Wed Aug 1, 9:45 am)
Re: 2.6.23-rc1-mm2, Jason Wessel, (Wed Aug 1, 9:57 am)