[PATCH 16/23] make atomic_read() and atomic_set() behavior consistent on s390

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Chris Snook
Date: Monday, August 13, 2007 - 4:33 am

From: Chris Snook <csnook@redhat.com>

Use volatile consistently in atomic.h on s390.

Signed-off-by: Chris Snook <csnook@redhat.com>

--- linux-2.6.23-rc3-orig/include/asm-s390/atomic.h	2007-08-13 03:14:13.000000000 -0400
+++ linux-2.6.23-rc3/include/asm-s390/atomic.h	2007-08-13 06:04:58.000000000 -0400
@@ -67,8 +67,15 @@ typedef struct {
 
 #endif /* __GNUC__ */
 
-#define atomic_read(v)          ((v)->counter)
-#define atomic_set(v,i)         (((v)->counter) = (i))
+static __inline__ int atomic_read(atomic_t *v)
+{
+        return *(volatile int *)&v->counter;
+}
+
+static __inline__ void atomic_set(atomic_t *v, int i)
+{
+        *(volatile int *)&v->counter = i;
+}
 
 static __inline__ int atomic_add_return(int i, atomic_t * v)
 {
@@ -182,8 +189,15 @@ typedef struct {
 
 #endif /* __GNUC__ */
 
-#define atomic64_read(v)          ((v)->counter)
-#define atomic64_set(v,i)         (((v)->counter) = (i))
+static __inline__ long long atomic64_read(atomic64_t *v)
+{
+        return *(volatile long long *)&v->counter;
+}
+
+static __inline__ void atomic64_set(atomic64_t *v, long long i)
+{
+        *(volatile long long *)&v->counter = i;
+}
 
 static __inline__ long long atomic64_add_return(long long i, atomic64_t * v)
 {
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 16/23] make atomic_read() and atomic_set() behavior ..., Chris Snook, (Mon Aug 13, 4:33 am)
RE: [PATCH 10/23] make atomic_read() and atomic_set() beha ..., Christoph Lameter, (Tue Aug 14, 3:11 pm)
Re: [PATCH 1/23] document preferred use of volatile with a ..., Christoph Lameter, (Tue Aug 14, 3:45 pm)
Re: [PATCH 1/23] document preferred use of volatile with a ..., Christoph Lameter, (Tue Aug 14, 3:56 pm)
Re: [PATCH 1/23] document preferred use of volatile with a ..., Segher Boessenkool, (Thu Aug 16, 2:36 pm)
Re: [PATCH 11/23] make atomic_read() and atomic_set() beha ..., Segher Boessenkool, (Wed Aug 22, 7:24 am)
Re: [PATCH 11/23] make atomic_read() and atomic_set() beha ..., Segher Boessenkool, (Thu Aug 23, 12:29 pm)